aleleba/wordcraft
1
0
Fork 0
mirror of https://github.com/storytold/wordcraft.git synced 2026-10-24 02:17:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

ci: File Close test expects the window kept (#1712); Polish coverage test skips French's newer strings

Browse Source 
#2448's imported-Word close test predates #1996 (File › Close keeps the window), and #2492's French catalog carries keys the Polish catalog lacks, as the PR's own test change said.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Brandon Thomas
2026-10-18 10:37:08 -04:00
co-authored by Claude Opus 5.5
parent c9a5191b70
commit 7333a302f5
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/file_dialogs.rs
+2 -1
View File
@@ -504,7 +504,8 @@ mod tests {
let saved = dir.join("contract.docx");
answer(&shown, Some(&saved.to_string_lossy()));
assert_eq!(a.poll_file_dialog().unwrap().unwrap()["done"], true);
assert!(a.quit_requested, "Close runs only after the DOCX save succeeds");
// File › Close keeps the window (#1712): the document closes once the DOCX save succeeds.
assert!(!a.has_document() && !a.quit_requested, "Close runs only after the DOCX save succeeds");
assert!(saved_text(&saved).contains("Revised Legacy contract"));
assert_eq!(std::fs::read(&original).unwrap(), bytes);
let _ = std::fs::remove_dir_all(dir);
crates/ui-egui/src/i18n/tests.rs
+3 -2
View File
@@ -990,8 +990,9 @@ fn polish_covers_every_key_of_every_other_catalog() {
// Italian and Hungarian still carry "Style: APA", which the interface no longer shows;
// Hungarian and Bulgarian also name the citation styles, and Bulgarian has a few one-line
// pieces of gallery labels. Polish matches every other catalog, including the built-in style
// names, citation styles and equation gallery.
for other in Lang::all().filter(|l| *l != Lang::EN && !matches!(l.code(), "pl" | "it" | "hu" | "bg" | "vi" | "sv" | "hr")) {
// names, citation styles and equation gallery. French carries newer strings (paper sizes,
// bookmarks, printing) the Polish catalog hasn't caught up with yet.
for other in Lang::all().filter(|l| *l != Lang::EN && !matches!(l.code(), "pl" | "it" | "hu" | "bg" | "vi" | "sv" | "hr" | "fr")) {
let mut missing: Vec<String> = keys(other.0.source).difference(&polish).cloned().collect();
missing.sort();
assert!(missing.is_empty(), "pl lacks {}'s {missing:?}", other.code());