From 7333a302f560d594c75a4008a4ffe1b9d9072d52 Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Sun, 18 Oct 2026 10:37:08 -0400 Subject: [PATCH] ci: File Close test expects the window kept (#1712); Polish coverage test skips French's newer strings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #2448's imported-Word close test predates #1996 (File › Close keeps the window), and #2492's French catalog carries keys the Polish catalog lacks, as the PR's own test change said. Co-Authored-By: Claude Opus 5.5 --- crates/ui-egui/src/file_dialogs.rs | 3 ++- crates/ui-egui/src/i18n/tests.rs | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/crates/ui-egui/src/file_dialogs.rs b/crates/ui-egui/src/file_dialogs.rs index 1316879a5..b95f4d238 100644 --- a/crates/ui-egui/src/file_dialogs.rs +++ b/crates/ui-egui/src/file_dialogs.rs @@ -504,7 +504,8 @@ mod tests { let saved = dir.join("contract.docx"); answer(&shown, Some(&saved.to_string_lossy())); assert_eq!(a.poll_file_dialog().unwrap().unwrap()["done"], true); - assert!(a.quit_requested, "Close runs only after the DOCX save succeeds"); + // File › Close keeps the window (#1712): the document closes once the DOCX save succeeds. + assert!(!a.has_document() && !a.quit_requested, "Close runs only after the DOCX save succeeds"); assert!(saved_text(&saved).contains("Revised Legacy contract")); assert_eq!(std::fs::read(&original).unwrap(), bytes); let _ = std::fs::remove_dir_all(dir); diff --git a/crates/ui-egui/src/i18n/tests.rs b/crates/ui-egui/src/i18n/tests.rs index f43f1b216..42ff1c606 100644 --- a/crates/ui-egui/src/i18n/tests.rs +++ b/crates/ui-egui/src/i18n/tests.rs @@ -990,8 +990,9 @@ fn polish_covers_every_key_of_every_other_catalog() { // Italian and Hungarian still carry "Style: APA", which the interface no longer shows; // Hungarian and Bulgarian also name the citation styles, and Bulgarian has a few one-line // pieces of gallery labels. Polish matches every other catalog, including the built-in style - // names, citation styles and equation gallery. - for other in Lang::all().filter(|l| *l != Lang::EN && !matches!(l.code(), "pl" | "it" | "hu" | "bg" | "vi" | "sv" | "hr")) { + // names, citation styles and equation gallery. French carries newer strings (paper sizes, + // bookmarks, printing) the Polish catalog hasn't caught up with yet. + for other in Lang::all().filter(|l| *l != Lang::EN && !matches!(l.code(), "pl" | "it" | "hu" | "bg" | "vi" | "sv" | "hr" | "fr")) { let mut missing: Vec = keys(other.0.source).difference(&polish).cloned().collect(); missing.sort(); assert!(missing.is_empty(), "pl lacks {}'s {missing:?}", other.code());