aleleba/pdfcraft
1
0
Fork 0
mirror of https://github.com/storytold/pdfcraft.git synced 2026-11-01 05:58:12 -06:00
Code Issues Packages Projects Releases Wiki Activity

M6: form_set_props' refusals are argument errors, so the tool's own notation guard is tested

Browse Source 
The test only checked each refusal's message. Without the tool's notation guard, set_props
refuses the same notation with the same message as a failed edit, so the test passed with the
guard removed. It now asserts InvalidArgs for every row, and fails on "a EVCALC b" without the
guard.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Grzegorz Martens
2026-10-29 20:48:48 +01:00
co-authored by Claude Opus 5.5
parent 2055f48f5f
commit ebad7f849d
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/automation/tests/it/automation.rs
+7 -4
View File
@@ -5154,8 +5154,9 @@ fn every_calculation_op_can_be_read_and_given_back() {
}
/// form_set_props refuses a calculate or validate it would only partly apply (a key it doesn't
/// know, a value of the wrong type, a notation beside op and fields) and changes nothing. A
/// validate read back from form_fields, with null for the bound it doesn't have, is taken back.
/// know, a value of the wrong type, a notation beside op and fields) as a bad argument, before
/// the edit runs, and changes nothing. A validate read back from form_fields, with null for the
/// bound it doesn't have, is taken back.
#[test]
fn calculate_and_validate_refuse_what_they_would_drop() {
let dir = workdir("calcstrict");
@@ -5185,12 +5186,14 @@ fn calculate_and_validate_refuse_what_they_would_drop() {
(json!({ "fields": ["a"] }), "needs op"),
(json!({ "op": "sum", "feilds": ["a"] }), "unknown key \"feilds\""),
] {
// InvalidArgs, not Failed: an unstorable notation is refused by the tool itself, not
// only by the edit underneath it.
let e = err(&mut a, "form_set_props", json!({ "doc": doc, "field": "total", "calculate": calculate }));
assert!(e.to_string().contains(says), "{calculate}: {e}");
assert!(matches!(e, ToolError::InvalidArgs(_)) && e.to_string().contains(says), "{calculate}: {e:?}");
}
for (validate, says) in [(json!({ "min": 0, "max": "100" }), "max must be a number"), (json!({ "min": 0, "mxa": 5 }), "unknown key \"mxa\"")] {
let e = err(&mut a, "form_set_props", json!({ "doc": doc, "field": "total", "validate": validate }));
assert!(e.to_string().contains(says), "{validate}: {e}");
assert!(matches!(e, ToolError::InvalidArgs(_)) && e.to_string().contains(says), "{validate}: {e:?}");
}
let t = total(&mut a);
assert_eq!((&t["calculate"], &t["validate"]), (&set, &json!({ "min": 0.0, "max": 10.0 })), "nothing changed");