aleleba/pdfcraft
1
0
Fork 0
mirror of https://github.com/storytold/pdfcraft.git synced 2026-10-27 19:48:14 -06:00
Code Issues Packages Projects Releases Wiki Activity

M2: the vendor note names the function and the flag the code tests (#4156)

Browse Source 
Review on #4157 (CodeRabbit): the symbolic branch of EmbeddedKind::map_code is taken whenever the
Nonsymbolic flag is not set; it doesn't look at /Encoding.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
mtlcl410
2026-10-23 07:25:55 +08:00
co-authored by Claude Opus 5.5
parent 4118f47991
commit be60c6d27f
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
vendor/README.md
Vendored
+4 -3
View File
@@ -100,9 +100,10 @@ and `japanese_substitute_spaces_keep_pdf_widths_and_unicode` use the synthetic
MS-Mincho / UniJIS-UCS2-HW-H fixture with craft-fonts, including `/W` and `/DW`
placement controls.
Symbolic TrueType `cmap` order (#4156): in `hayro-interpret` `TrueTypeFont::map_code`, a
symbolic font (no `/Encoding`, or the Symbolic flag) looks a code up in its Windows (3, 0) or
(3, 1) subtables before its Macintosh and Unicode ones, as ISO 32000-2 §9.6.5.4 prescribes; the
Symbolic TrueType `cmap` order (#4156): in `hayro-interpret` `EmbeddedKind::map_code`, an
embedded TrueType font whose Nonsymbolic flag is not set (the branch `is_non_symbolic()` does not
take) looks a code up in its Windows (3, 0) or (3, 1) subtables before its Macintosh and Unicode
ones, as ISO 32000-2 §9.6.5.4 prescribes for symbolic fonts; the
(1, 0) subtable still serves codes the (3, x) ones leave out. The records were tried in the
order the font lists them, platform ID first, so a wrong (1, 0) table (SAS 9.4's AMT fonts)
drew "8" as "p" and "+" as "V". Covered by `raster::tests::symbolic_truetype_cmap`, whose font