From be60c6d27fd67442f88e5bc8bff560880e4186da Mon Sep 17 00:00:00 2001 From: mtlcl410 <2368091+mtlcl410@users.noreply.github.com> Date: Fri, 23 Oct 2026 07:25:55 +0800 Subject: [PATCH] M2: the vendor note names the function and the flag the code tests (#4156) Review on #4157 (CodeRabbit): the symbolic branch of EmbeddedKind::map_code is taken whenever the Nonsymbolic flag is not set; it doesn't look at /Encoding. Co-Authored-By: Claude Opus 5.5 --- vendor/README.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/vendor/README.md b/vendor/README.md index 98ef1b4c1..3ea194811 100644 --- a/vendor/README.md +++ b/vendor/README.md @@ -100,9 +100,10 @@ and `japanese_substitute_spaces_keep_pdf_widths_and_unicode` use the synthetic MS-Mincho / UniJIS-UCS2-HW-H fixture with craft-fonts, including `/W` and `/DW` placement controls. -Symbolic TrueType `cmap` order (#4156): in `hayro-interpret` `TrueTypeFont::map_code`, a -symbolic font (no `/Encoding`, or the Symbolic flag) looks a code up in its Windows (3, 0) or -(3, 1) subtables before its Macintosh and Unicode ones, as ISO 32000-2 §9.6.5.4 prescribes; the +Symbolic TrueType `cmap` order (#4156): in `hayro-interpret` `EmbeddedKind::map_code`, an +embedded TrueType font whose Nonsymbolic flag is not set (the branch `is_non_symbolic()` does not +take) looks a code up in its Windows (3, 0) or (3, 1) subtables before its Macintosh and Unicode +ones, as ISO 32000-2 §9.6.5.4 prescribes for symbolic fonts; the (1, 0) subtable still serves codes the (3, x) ones leave out. The records were tried in the order the font lists them, platform ID first, so a wrong (1, 0) table (SAS 9.4's AMT fonts) drew "8" as "p" and "+" as "V". Covered by `raster::tests::symbolic_truetype_cmap`, whose font