Commit Graph
3530 Commits
Author SHA1 Message Date
francoisgn 4e75723da5 Merge PR #2327: #2312: culling goes on from a photo rated out of the view
# Conflicts:
#	docs/parity-checklist.md
#	docs/whats-new.md
2026-10-22 22:28:40 +03:00
francoisgn be5735abf4 Merge PR #2501: LR-VIEW-INFOOVERLAY: the info overlay clears the macOS windo 2026-10-22 22:28:40 +03:00
francoisgn b32b4383f5 Merge PR #1074: LR-VIEW-ZOOM: diagnostic overlays render zoom windows; soft
# Conflicts:
#	docs/gaps.md
#	docs/parity-checklist.md
#	docs/ui-parity.md
2026-10-22 22:28:28 +03:00
francoisgn 3e273e9fbb Merge PR #1922: LR-VIEW-ZOOM: a middle-button drag pans the photo whatever t
# Conflicts:
#	docs/parity-checklist.md
2026-10-22 22:27:59 +03:00
francoisgn 878f49cac6 Merge PR #1979: LR-EDIT-COLOR-GRADING: a wheel drag holds the pointer and pu
# Conflicts:
#	crates/ui-egui/src/lib.rs
2026-10-22 22:27:59 +03:00
francoisgn 5bbf12dfcd Merge PR #1914: LR-BEHAV-DIALOGS: optionally close a dialog by clicking outs 2026-10-22 22:27:50 +03:00
francoisgn e08255a825 Merge PR #1313: Help ▸ Debug ▸ Show Frame Rate: a frame-rate display for wat 2026-10-22 22:27:50 +03:00
francoisgn 86c650f840 Merge PR #2195: MENU-BAR: menu switches are named for what they show, and no
# Conflicts:
#	docs/parity-checklist.md
#	docs/whats-new.md
2026-10-22 22:27:50 +03:00
francoisgn 1489f47384 Merge PR #2077: LR-BEHAV-BG-TASKS: one progress bar, spinner and busy button
# Conflicts:
#	crates/ui-egui/src/lib.rs
#	docs/whats-new.md
2026-10-22 22:27:49 +03:00
francoisgn a05bc77ce0 Merge PR #2076: LR-LIB-RATING: one shared star rating for every rating on sc
# Conflicts:
#	docs/whats-new.md
2026-10-22 22:27:34 +03:00
francoisgn 9556aaf921 Merge PR #1287: LR-PREF-GENERAL: the Settings window is one size on every ta 2026-10-22 22:27:19 +03:00
Nathaniel Ledford 5626550640 LR-BEHAV-BG-TASKS: one whole-percent rule for the bar text and its announced value 2026-10-22 13:46:24 -04:00
Nathaniel Ledford 0198375edf LR-BEHAV-BG-TASKS: activity bars are named after their task, denoise percentage matches its announced value, Describe waits for a pending detail pass 2026-10-22 13:23:53 -04:00
Nathaniel Ledford 0457d38a76 LR-BEHAV-BG-TASKS: a failed filmstrip thumbnail with no file name is announced without a leading comma 2026-10-22 11:13:29 -04:00
Nathaniel Ledford 66a4cf8a5c MENU-BAR: drop the two renamed menu labels the cs, it and pl catalogs still carry 2026-10-22 10:48:11 -04:00
Nathaniel Ledford 2525613e3e LR-PREF-GENERAL: the slide preview stays above the Slideshow page while the templates are browsed 2026-10-22 08:26:54 -04:00
Nathaniel Ledford f76680dc3b LR-LIB-RATING: a test paints the hover state through Rating::show 2026-10-22 07:17:57 -04:00
BFlat c66014e65f Merge pull request #2548 from storytold/readme/app-icon
README: the app icon above the title
2026-10-22 18:02:01 +07:00
bflatastic c810a51047 README: the app icon above the title 2026-10-22 17:58:01 +07:00
Nathaniel Ledford d005ff76bc LR-PREF-GENERAL: the smart previews note test reaches the fix 2026-10-22 02:07:32 -04:00
Nathaniel LedfordandClaude Opus 5.5 5d1f9da46c LR-LIB-RATING: say which surfaces share the star row
The parity row and the What's New heading said one star rating 'everywhere', but the
Set Rating / Select By Rating menu rows and the grid context menu are separate menu
items with star text and are unchanged. Name the real scope.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 02:03:25 -04:00
Nathaniel LedfordandClaude Opus 5.5 5947667c6c LR-LIB-RATING: focus follows the Tab stop when the rating changes elsewhere
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 02:03:17 -04:00
Nathaniel LedfordandClaude Opus 5.5 0885ba5fd2 LR-LIB-RATING: format
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 02:03:17 -04:00
Nathaniel LedfordandClaude Opus 5.5 8720bbcfef LR-LIB-RATING: one Tab stop per rating row, visible-only favourite registration, true docs
The star row is a single Tab stop (the current rating's star, or the first) with the arrow keys
stepping inside it and the focus following. favorite_button registers its automation id only while
on screen again. The module and test docs no longer mention a size/read-only API that doesn't exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 02:03:17 -04:00
Nathaniel LedfordandClaude e161744d70 LR-LIB-RATING: first arrow after Tab steps the rating
egui picks the neighbour to focus from the arrow key in begin_pass,
before a widget can set a focus lock for the frame it just gained
focus (set_focus_lock_filter needs a frame of focus first). A focused
star that consumes an arrow now cancels that pending focus move. The
favourite toggle is one interact-height line square again, so Manage
Effect Presets rows keep their height.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-22 02:03:17 -04:00
Nathaniel LedfordandClaude 0e04000f60 LR-LIB-RATING: keep arrow keys on a focused star, draw its ring
Left/right moved egui focus to the neighbouring widget after one or
two steps. A focused star now locks horizontal arrows (as the slider
does) and draws the accent focus ring. Rating drops the options no
caller uses (size, read_only, enabled). The mask-effect favourite
stars use paint_star and a shared favorite_button instead of a raw
egui::Button and a "★" glyph.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-22 02:03:17 -04:00
Nathaniel LedfordandClaude d04633d308 LR-LIB-RATING: one shared star rating component
The bottom bar, the Info panel and the filter bar each drew their own
row of stars, and the grid badge, filmstrip badges and compare caption
had private painter loops. They now share rating::Rating (a clickable
row: hover previews, clicking the current rating clears it, read-only
and disabled states, left/right arrows on a focused star) and
rating::paint_rating / paint_star for painter-only contexts.

Existing automation ids (star:bottom:n, star:info:n, filter:starN) are
unchanged. The preset, profile and theme favourite stars use
paint_star too, so Icon::Star lives only in rating.rs.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-22 02:03:17 -04:00
Nathaniel Ledford f36abff3e1 LR-BEHAV-BG-TASKS: a detail pass counts as the segmenter working 2026-10-22 02:02:48 -04:00
Nathaniel Ledford 1e65f52e79 LR-BEHAV-BG-TASKS: the SAM download bar keeps its name while the size is unknown 2026-10-22 02:02:48 -04:00
Nathaniel Ledford ee2559c60f LR-BEHAV-BG-TASKS: unknown totals sweep, denoise bars keep their widths, Enter waits for the segmenter 2026-10-22 02:02:48 -04:00
Nathaniel LedfordandClaude Opus 5.5 316f82dbd2 LR-BEHAV-BG-TASKS: name the failed filmstrip thumbnail, firmer light placeholders, paper print cells
A failed thumbnail in the detail view's filmstrip is announced with the
file name and "This photo can't be opened" (the painted ! had no name).
The skeleton placeholder is set further off the surfaces in Silver and
Paper (1.3 / 1.2 : 1 on the grid before, about 1.7 / 1.6 after) and the
test floor for the light themes is 1.15. The print preview's empty and
loading cells go back to fixed greys: its page is paper in every theme.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 02:02:48 -04:00
Nathaniel LedfordandClaude 3de9654e39 LR-BEHAV-BG-TASKS: review fixes for progress and busy buttons
Model-row bars keep Cancel in its place, a busy button stays focusable
and draws its spinner only when visible, the skeleton colour stands
apart from selected cells too, the filmstrip shows the failed-thumbnail
mark, and more placeholders and waits use the skeleton token and the
spinner.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-22 02:02:48 -04:00
Nathaniel LedfordandClaude 05b653995b LR-BEHAV-BG-TASKS: busy buttons where work starts
Install from file… (denoise) shows busy while the model installs, and
the describe-mask Select button while the AI works.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-22 02:02:48 -04:00
Nathaniel LedfordandClaude bbd9a35237 LR-BEHAV-BG-TASKS: a busy text button keeps its padding
The spinner in a text-only busy button is smaller and sits closer to the
text, so the text no longer touches the button's border while the width
stays the same.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-22 02:02:48 -04:00
Nathaniel LedfordandClaude b0f184da33 LR-BEHAV-BG-TASKS: one progress bar, spinner and busy button
Progress bars were five raw egui::ProgressBar calls with fixed widths
(240, 260, 380), one hand-drawn bar in the activity stack, and a stock
spinner; text-only waits had no sign of life. progress.rs now has
Progress (a clamped, NaN-safe fraction or a gentle sweep when unknown,
fills the layout's width, announced as a progress indicator with its
percentage and registered by id) and a vector-arc spinner. Button::busy
shows the spinner in the icon's place, keeps the width, ignores clicks
and is announced busy.

Thumbnails still being made draw a themed skeleton colour (a Tokens
field, static) in the grid, the filmstrip and Compare, instead of a
literal grey that was nearly black on the light themes.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-22 02:02:47 -04:00
Nathaniel Ledford 870106a6df MENU-BAR: the new fi, id, sv and vi catalogs carry the renamed menu entries; Parity checklist header names the rename 2026-10-22 02:01:37 -04:00
Nathaniel LedfordandClaude Opus 5.5 5b4f120e8d MENU-BAR: edit-a-photo guide names the view Detail View
Step 1 now uses the current menu label. verified stays 0.7.1 until a release
contains the renamed labels (docs/user/AGENTS.md).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 02:00:58 -04:00
Nathaniel LedfordandClaude 9073cec3a2 MENU-BAR: Settings calls the view Detail View too; translation fixes from review
zh-hant used 詳細檢視 for both the Detail section and the view: the section is
細節 now, and Settings' Open in choice and heading use Detail View. Also
zh-hans 详细视图, consistent fr/ja/uk All Mask Overlays, de/it Clipping.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-22 02:00:58 -04:00
Nathaniel LedfordandClaude 434da7ae68 MENU-BAR: menu switches are named for what they show, and no two commands share a name
Switches read "Show Focus Point ✓" next to "Filmstrip ✓"; now every switch
is named for the thing and the check mark says whether it is on (Focus
Point, Clipping, Photo Counts, Mask Overlay, All Mask Overlays, Mask Pins,
Layout Image). Show Original stays: it is a view, not a switch.

Names that meant two things: View ▸ Detail and the Edit section Detail
(Detail View now, like Reference View), Window ▸ Edit and the Edit menu
(Edit Panel), Compare and Compare Before and After (Before/After Side by
Side, next to Split and Top/Bottom), and Clear/Discard Preview Cache (one
command, now Discard Preview Cache everywhere). New labels in all 13
catalogs. Tests: no "Show …" switch; no two menu commands share a label or
a menu's name.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-22 02:00:54 -04:00
chordpli 52ff2b5c4f LR-VIEW-INFOOVERLAY: the info overlay clears the macOS window controls and shows the rating and flag (#2460)
The full-screen preview hides the top bar, but on macOS the window controls
stay at the top-left, where the info overlay drew the file name. When they
are visible, the overlay now starts below them. In macOS full screen they
are gone and the overlay keeps the corner.

The overlay also shows the photo's star rating and flag under its lines,
when the photo has them.
2026-10-22 14:10:22 +09:00
Nathaniel LedfordandClaude Opus 5.5 5863025e50 LR-PREF-GENERAL: the Settings window is one size on every tab, and nothing in it runs off the side
- settings::window draws the tab bar, which stays put, above the page of the open tab, which
  scrolls: 560 pt wide and up to 640 pt tall on every tab (less in a smaller app window), each
  page with a scroll position of its own and a handle that shows without the pointer on it.
- A row's controls wrap in the room beside the label; a label longer than its column wraps.
- Paths (the library's location, the Auto Import folder, the smart previews folder, a monitor
  profile's file) are one line shortened from the front, the whole path in a tooltip only when cut.
- The Slideshow tab is one column the width of the page, the preview first; pointing at a
  template no longer moves the page, and the Export buttons wrap.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 01:08:11 -04:00
aiongg 31ee2643cf Merge PR #2515: integration of 85 reviewed PRs (round 2) 2026-10-22 00:25:29 -04:00
aiongg 3dd1b88ff9 Merge PR #2349: the sidebar trees narrow their indent step before names are cut (test follow-ups) 2026-10-22 03:45:54 +00:00
aiongg 1847cbd3e3 Integration: #1997 test picks the 3:4 crop by its named ratio, which follows the photo's orientation 2026-10-22 03:28:46 +00:00
aiongg 04275ce9da Integration: #1484 vi format messages use → instead of the unpaintable ▸ 2026-10-22 03:28:46 +00:00
helgehelge123andClaude Opus 5.5 eb7513c5d2 LRC-LIB-LIBFOLDERS: deep_folders_app waits for each row before opening it
On the FreeBSD runner a click's synthetic input can arrive a frame or two late, so after opening
`/a/b/c/d` the row of `/a/b/c/d/e` was not drawn yet when the next click asked for it. The
fixture now steps until each level's chevron is drawn before clicking it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 05:10:04 +02:00
aiongg c25f7a238f Integration: list Bahasa Indonesia and Tiếng Việt in the README's interface languages 2026-10-22 03:00:44 +00:00
aiongg bf96159526 Integration: regenerate the parity checklist summary 2026-10-22 02:59:01 +00:00
aiongg ec264876fc Integration: English text for the folder-listing message in the fi, id, sv and vi format catalogues 2026-10-22 02:57:56 +00:00
aiongg 8daa25c4c9 Merge track r2-t04 into next
# Conflicts:
#	ROADMAP.md
#	docs/gaps.md
#	docs/parity-checklist.md
#	docs/target-app-parity.md
#	docs/whats-new.md
2026-10-22 02:53:42 +00:00