aleleba/gridcraft
1
0
Fork 0
mirror of https://github.com/storytold/gridcraft.git synced 2026-11-13 17:35:01 -06:00
Code Issues Packages Projects Releases Wiki Activity

Keytips: NW runs insert.wordArt now that the command exists; pending-sequence test uses NJ (insert.object)

Browse Source 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
vangel76
2026-10-12 21:47:39 +02:00
co-authored by Claude Sonnet 5.5
parent a39c6b8977
commit 3109f2a9e0
4 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/keytips/keytip_table/generated.rs
+1 -1
View File
@@ -189,7 +189,7 @@ pub const SEQUENCES: &[(&str, Entry)] = &[
("NU", Entry::Finish(Action::Command("insert.symbol"))), // Excel: Symbols; containment(Symbol)
("NZS", Entry::Finish(Action::Command("insert.symbol"))), // Excel: Excel: Symbol (modern)
("NV", Entry::Finish(Action::Command("insert.pivotTable"))), // Excel: PivotTable
("NW", Entry::Finish(Action::Pending("insert.wordArt"))), // pending; Excel: WordArt; WordArt; reserved until the command lands
("NW", Entry::Finish(Action::Command("insert.wordArt"))), // Excel: WordArt
("NX", Entry::Finish(Action::Command("insert.textBox"))), // Excel: Text Box
("NZK", Entry::Continue), // Excel: Sparklines Menu; group level:
("NZKSL", Entry::Finish(Action::Dialog("sparkline"))), // Excel: Line Sparkline
crates/ui-egui/src/keytips/keytips.json
+1 -3
View File
@@ -1253,9 +1253,7 @@
"seq": "NW",
"kind": "command",
"target": "insert.wordArt",
"pending": true,
"excel": "WordArt",
"note": "WordArt; reserved until the command lands"
"excel": "WordArt"
},
{
"seq": "NX",
crates/ui-egui/tests/keytips.rs
+1 -1
View File
@@ -407,7 +407,7 @@ fn vertical_alignment_keytips_run_their_commands() {
fn pending_sequences_are_silent_no_ops() {
let mut h = harness(blank());
let journal = h.state().session.journal.len();
sequence(&mut h, &[Key::N, Key::W], false); // NW -> insert.wordArt (missing)
sequence(&mut h, &[Key::N, Key::J], false); // NJ -> insert.object (missing)
assert!(h.state().dialog.is_none(), "no dialog for a pending sequence");
assert!(h.state().message.is_none(), "no message box for a pending sequence");
assert!(h.state().toast.is_none(), "no toast for a pending sequence");
crates/ui-egui/tests/keytips_generated.rs
+1 -4
View File
@@ -1377,10 +1377,7 @@ fn keytip_nv_() {
fn keytip_nw_() {
let mut h = harness(blank());
sequence(&mut h, "NW", false);
assert!(h.state().dialog.is_none(), "NW must not open a dialog");
assert!(h.state().message.is_none(), "NW must not open a message box");
assert!(h.state().toast.is_none(), "NW must not raise a toast");
assert!(h.state().session.journal.is_empty(), "NW must not journal");
assert!(h.state().session.journal.iter().any(|(id, _)| id == "insert.wordArt"), "NW must journal insert.wordArt");
}
#[test]