From 3109f2a9e0e6050398bcd87ffa8111e5c9a5366a Mon Sep 17 00:00:00 2001 From: vangel76 Date: Mon, 12 Oct 2026 21:47:39 +0200 Subject: [PATCH] Keytips: NW runs insert.wordArt now that the command exists; pending-sequence test uses NJ (insert.object) Co-Authored-By: Claude Sonnet 5.5 --- crates/ui-egui/src/keytips/keytip_table/generated.rs | 2 +- crates/ui-egui/src/keytips/keytips.json | 4 +--- crates/ui-egui/tests/keytips.rs | 2 +- crates/ui-egui/tests/keytips_generated.rs | 5 +---- 4 files changed, 4 insertions(+), 9 deletions(-) diff --git a/crates/ui-egui/src/keytips/keytip_table/generated.rs b/crates/ui-egui/src/keytips/keytip_table/generated.rs index 143c15769..666a8c877 100644 --- a/crates/ui-egui/src/keytips/keytip_table/generated.rs +++ b/crates/ui-egui/src/keytips/keytip_table/generated.rs @@ -189,7 +189,7 @@ pub const SEQUENCES: &[(&str, Entry)] = &[ ("NU", Entry::Finish(Action::Command("insert.symbol"))), // Excel: Symbols; containment(Symbol) ("NZS", Entry::Finish(Action::Command("insert.symbol"))), // Excel: Excel: Symbol (modern) ("NV", Entry::Finish(Action::Command("insert.pivotTable"))), // Excel: PivotTable - ("NW", Entry::Finish(Action::Pending("insert.wordArt"))), // pending; Excel: WordArt; WordArt; reserved until the command lands + ("NW", Entry::Finish(Action::Command("insert.wordArt"))), // Excel: WordArt ("NX", Entry::Finish(Action::Command("insert.textBox"))), // Excel: Text Box ("NZK", Entry::Continue), // Excel: Sparklines Menu; group level: ("NZKSL", Entry::Finish(Action::Dialog("sparkline"))), // Excel: Line Sparkline diff --git a/crates/ui-egui/src/keytips/keytips.json b/crates/ui-egui/src/keytips/keytips.json index cbb8e0475..8e2e326bc 100644 --- a/crates/ui-egui/src/keytips/keytips.json +++ b/crates/ui-egui/src/keytips/keytips.json @@ -1253,9 +1253,7 @@ "seq": "NW", "kind": "command", "target": "insert.wordArt", - "pending": true, - "excel": "WordArt", - "note": "WordArt; reserved until the command lands" + "excel": "WordArt" }, { "seq": "NX", diff --git a/crates/ui-egui/tests/keytips.rs b/crates/ui-egui/tests/keytips.rs index 24be742a5..f1139c743 100644 --- a/crates/ui-egui/tests/keytips.rs +++ b/crates/ui-egui/tests/keytips.rs @@ -407,7 +407,7 @@ fn vertical_alignment_keytips_run_their_commands() { fn pending_sequences_are_silent_no_ops() { let mut h = harness(blank()); let journal = h.state().session.journal.len(); - sequence(&mut h, &[Key::N, Key::W], false); // NW -> insert.wordArt (missing) + sequence(&mut h, &[Key::N, Key::J], false); // NJ -> insert.object (missing) assert!(h.state().dialog.is_none(), "no dialog for a pending sequence"); assert!(h.state().message.is_none(), "no message box for a pending sequence"); assert!(h.state().toast.is_none(), "no toast for a pending sequence"); diff --git a/crates/ui-egui/tests/keytips_generated.rs b/crates/ui-egui/tests/keytips_generated.rs index 50c5731be..fe9700906 100644 --- a/crates/ui-egui/tests/keytips_generated.rs +++ b/crates/ui-egui/tests/keytips_generated.rs @@ -1377,10 +1377,7 @@ fn keytip_nv_() { fn keytip_nw_() { let mut h = harness(blank()); sequence(&mut h, "NW", false); - assert!(h.state().dialog.is_none(), "NW must not open a dialog"); - assert!(h.state().message.is_none(), "NW must not open a message box"); - assert!(h.state().toast.is_none(), "NW must not raise a toast"); - assert!(h.state().session.journal.is_empty(), "NW must not journal"); + assert!(h.state().session.journal.iter().any(|(id, _)| id == "insert.wordArt"), "NW must journal insert.wordArt"); } #[test]