aleleba/effectcraft
1
0
Fork 0
mirror of https://github.com/storytold/effectcraft.git synced 2026-10-30 13:08:07 -06:00
Code Issues Packages Projects Releases Wiki Activity
1,983 Commits 125 Branches 18 Tags
30e02b06caef9ca3d6bfc672bbd4110204d86db4
Commit Graph
1983 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
midasmatterhorn 30e02b06ca project: output_size clamps the scale, not the sides, and every renderer uses it 
Clamping each side on its own broke the aspect ratio (a 30000x15000 comp
at 4x came out 30000x30000). The effective scale min(s, MAX_SIZE/w,
MAX_SIZE/h) keeps both sides within the comp limit, and the export
pipeline and the locked-aspect width derivation render at that same
scale, so nothing requests a frame larger than output_size reports.
 2026-10-16 14:46:24 +03:00
midasmatterhorn 912f828aa3 project: output_size never asks for sides past the comp limit 
A 30 000 px comp (the repaired MAX_SIZE on load) at resolution 4.0
produced 120 000 px sides, which overflow u32 in the exporters'
w * h * 4 (debug panic, release wrap then slice panic) after already
requesting a ~57 GB frame. The resize path in the same file clamps to
30 000; output_size now does too.

Regression test: output_size_never_exceeds_the_comp_limit — on main it
returns (120000, 120000); with the clamp (30000, 30000), through both
RenderSettings and the OutputModule wrapper.
 2026-10-16 14:37:14 +03:00
BFlat 19d19a339e Merge pull request #1482 from midasmatterhorn/fix/font-offset-overflow 
pdf: checked_add for CFF Private DICT and Type 1 RD offsets from the file
 2026-10-16 18:15:10 +07:00
BFlat 57ea7c7886 Merge pull request #1608 from marcoarnulfo/credits/marcoarnulfo 
Contributors: add Marco Arnulfo
 2026-10-16 18:14:59 +07:00
BFlat de8f25b2eb Merge pull request #1379 from DWAA1660/fix/1252-layer-cache-scene-deps 
Layer cache: hash a selected layer's comp scene into its owner's key
 2026-10-16 18:14:48 +07:00
bflatastic 3ec09f20d4 Merge remote-tracking branch 'origin/main' into pr-1482 
# Conflicts:
#	crates/pdf/src/cff.rs
 2026-10-16 18:14:31 +07:00
bflatastic 2dcceeea90 Merge remote-tracking branch 'origin/main' into pr-1608 
# Conflicts:
#	contributors/people.toml
 2026-10-16 18:14:23 +07:00
bflatastic f85f34c089 Merge remote-tracking branch 'origin/main' into pr-1379 
# Conflicts:
#	crates/render/src/tests.rs
 2026-10-16 18:14:14 +07:00
BFlat 853a1b65ec Merge pull request #1454 from Hamza0101/fix/german-menu-terms 
i18n (de): fix two labels that name the wrong thing, and settle six terms
 2026-10-16 18:13:57 +07:00
BFlat a3b62822be Merge pull request #1331 from onlymoein/codex/fix-1303-benchmark-evidence 
Reject corrupt benchmark results and incomplete regression evidence
 2026-10-16 18:13:45 +07:00
BFlat 5bbd982c32 Merge pull request #1566 from midasmatterhorn/fix/r4-inline-len-overflow 
pdf: an inline image with absurd dimensions falls back to the EI scan
 2026-10-16 18:13:33 +07:00
BFlat 5ad71a24e6 Merge pull request #1294 from vbasky/fix/1068-loop-import 
Engine: sequence Interpret Footage loop regression coverage (#1068)
 2026-10-16 18:13:22 +07:00
BFlat c672542b73 Merge pull request #1367 from nanox333/fix/viewer-comp-settings-menu 
Viewer: Composition Settings… in the composition's right-click menu
 2026-10-16 18:13:11 +07:00
BFlat ba384b89cd Merge pull request #1295 from vbasky/fix/1059-demo-space 
UI: regression test — Space previews the demo opened from the start screen (#1059)
 2026-10-16 18:12:59 +07:00
BFlat 9eec6ea705 Merge pull request #1344 from dotCooCoo/fix/find-missing-fonts-postscript-names 
Find Missing Fonts: fonts found by their PostScript or full name are no longer listed
 2026-10-16 18:12:47 +07:00
BFlat 13bcaee916 Merge pull request #1622 from dylanmtaylor/ci/shared-nix-workflow 
ci: switch to shared nix workflow from craft-common-actions
 2026-10-16 18:12:36 +07:00
BFlat 79bfc23c69 Merge pull request #1447 from midasmatterhorn/fix/glyph-name-char-boundary 
pdf: don't slice glyph names at a non-char boundary in name_to_unicode
 2026-10-16 18:12:24 +07:00
BFlat eba2c7015e Merge pull request #1455 from tydude001/rpm-soname-requires 
packaging: RPM requires library sonames, so openSUSE can install it
 2026-10-16 18:12:13 +07:00
BFlat 04a60d7747 Merge pull request #1311 from MarekSpodBiedry/issue-1263 
Scripting: add the missing app.preferences.saveToDisk() so imported scripts like Duik get past startup (#1263)
 2026-10-16 18:12:02 +07:00
BFlat 470ac13463 Merge pull request #1312 from zitann2020/i18n/ja-proportional-grid 
i18n(ja): four labels After Effects contradicts
 2026-10-16 18:11:50 +07:00
BFlat eea030b547 Merge pull request #1307 from zitann2020/i18n/ja-resolution-labels 
i18n(ja): the resolution labels agree with the panel catalog and After Effects
 2026-10-16 18:11:39 +07:00
BFlat 2265651b69 Merge pull request #1480 from IanHollow/codex/artcraft-effectcraft-metainfo-screenshot-bffb3039 
Packaging: repair the AppStream screenshot reference
 2026-10-16 18:11:27 +07:00
BFlat 1071e57dfd Merge pull request #1520 from MatejKozlovsky/frame0-failfast 
GPU: stop drawing a frame once the device has failed
 2026-10-16 18:11:16 +07:00
BFlat 86239e0f0c Merge pull request #1397 from onlymoein/patch-1 
Update contributor key: moecr7 -> onlymoein
 2026-10-16 18:11:04 +07:00
BFlat 49be0eb6cf Merge pull request #1258 from pravdomil/claude/settings-sidebar-button-gap-c80466 
Settings: the page list's rows touch, with no gap between them
 2026-10-16 18:10:52 +07:00
BFlat 0953011664 Merge pull request #1549 from MatejKozlovsky/upload-cache-dead-entries 
gpu: upload cache drops textures of freed buffers on every insert
 2026-10-16 18:10:41 +07:00
BFlat 5db68bf34a Merge pull request #1302 from vbasky/fix/1194-liquify-offset 
Liquify: expose Distortion Mesh Offset in Effect Controls (#1194)
 2026-10-16 18:10:30 +07:00
BFlat 896710b4c9 Merge pull request #1477 from midasmatterhorn/fix/cff-seac-recursion-depth 
pdf: bound CFF endchar seac recursion so a cyclic font can't overflow the stack
 2026-10-16 18:10:19 +07:00
BFlat eac13d1cf1 Merge pull request #948 from Themolx/solo-outside-active-range 
Solo: exclude other layers even when the soloed layer is outside its time range
 2026-10-16 18:10:06 +07:00
BFlat da74ff378e Merge pull request #1496 from midasmatterhorn/fix/issue-1476-color-picker-flash-close 
ui-egui: a click that opens the colour picker no longer closes it in the same frame (#1476)
 2026-10-16 18:09:52 +07:00
BFlat c133e09e37 Merge pull request #1371 from marcoarnulfo/fix/layer-property-shortcuts 
Scripting: test that Layer.property() resolves AE's top-level shortcuts
 2026-10-16 18:09:39 +07:00
BFlat ab5c998c09 Merge pull request #1360 from Deeev201/fix/dmg-finderinfo 
macOS DMG: hdiutil create -srcfolder, so the installed app passes codesign --strict
 2026-10-16 18:09:27 +07:00
BFlat a2c2a1078a Merge pull request #1357 from iannitram/upstream-pr/cli-args-os 
CLI: an argument that is not Unicode is a usage error, not a panic
 2026-10-16 18:09:16 +07:00
BFlat 41037328a8 Merge pull request #1433 from Hamza0101/render-queue-bare-project-path 
Render Queue: resolve a bare project filename against the working directory
 2026-10-16 18:09:06 +07:00
BFlat d6c80f9078 Merge pull request #1569 from midasmatterhorn/fix/r4-roi-crop-overflow 
project: a hostile ROI cannot overflow the crop math
 2026-10-16 18:08:55 +07:00
BFlat d6a9ccfff7 Merge pull request #1435 from marcoarnulfo/fix/webm-metadata-frame-count 
Import: item.metadata counts a WebM's last frame when its duration is not a whole millisecond
 2026-10-16 18:08:44 +07:00
BFlat cbdd12b27a Merge pull request #1431 from marcoarnulfo/fix/aiff-import 
Import: AIFF files import, including EffectCraft's own AIFF renders
 2026-10-16 18:08:33 +07:00
BFlat 50fd8777bf Merge pull request #1349 from nanox333/fix/1063-first-use-line 
Undefined-name errors report the first use from the failing function
 2026-10-16 18:08:20 +07:00
BFlat 74ed4dc423 Merge pull request #1383 from marcoarnulfo/fix/1381-generators-alpha 
Effects: 4-Color Gradient keeps the layer's alpha with Blending Mode None (refs #1381)
 2026-10-16 18:08:08 +07:00
bflatasticandClaude Opus 5.5 6f2f98b398 pdf: inline_len returns the checked product directly (clippy) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-16 17:48:08 +07:00
bflatasticandClaude Opus 5.5 f8b587503d pdf: rustfmt the inline-image test 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-16 17:36:55 +07:00
bflatasticandClaude Opus 5.5 183fe652e4 pdf: an inline image just under usize::MAX bytes doesn't overflow its end offset 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-16 17:36:11 +07:00
bflatasticandClaude Opus 5.5 45eacf1b17 GPU: upload_buf keeps its own doc comment 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-16 17:33:50 +07:00
bflatasticandClaude Opus 5.5 fc38904b41 Liquify: saved projects show Distortion Mesh Offset too (#1194) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-16 17:33:31 +07:00
BFlat 7c733f4cc9 Merge pull request #1639 from storytold/fix/relink-windows-paths 
Footage: relinking a moved project keeps Windows separators and UNC shares
 2026-10-16 17:13:59 +07:00
bflatasticandClaude Opus 5.5 86dff3ce78 Footage: relinking a moved project keeps Windows separators and UNC shares 
project_dir rebuilt the folder with `/` and dropped a UNC share's leading
`\`, so a project opened from \server\share\Job looked for its moved
footage under the relative path server/share/Job and never found it. It now
keeps the path's own separator and its leading `/` or `\`.

The relink tests built mixed-separator paths (`…\Job/p.ecproj`) and so failed
on Windows; they now use native paths and check the separator is kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-16 17:13:40 +07:00
BFlat 592348b1d7 Merge pull request #1254 from vangel76/fix-1221-windows-test-paths 
#1221: two path-format test failures on Windows
 2026-10-16 17:09:16 +07:00
BFlat 08788b8aa7 Merge pull request #1638 from storytold/docs/vector-retain-layer-sizes 
Docs: PDF / Illustrator Composition - Retain Layer Sizes in the parity docs
 2026-10-16 17:06:09 +07:00
bflatasticandClaude Opus 5.5 bafc7e620d Docs: parity docs list Composition - Retain Layer Sizes for PDF / Illustrator (#1536) 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-16 17:05:49 +07:00
BFlat 1abaabfb8b Merge pull request #1472 from arnav-hiwarkar/fix/1456-properties-reveal 
fix(properties): reveal transform rows on double-click
 2026-10-16 17:04:07 +07:00