Fix #1339 checks after merging main

- ui_accessibility_audit: main's new Character panel controls (stroke width presets, line
  join, stroke order) raise Character:default to 46 findings (22 unnamed); the ratchet entry
  follows, since that panel is not yet audited. The control filter is written as clippy's
  nonminimal_bool asks.
- ui_timeline_shapes (main's #2513 test): this PR names the Properties panel's Position row,
  so "Position" is no longer unique; the test takes the Animate menu's new entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
bflatastic
2026-10-30 12:04:32 +07:00
co-authored by Claude Opus 5.5
parent eef9997889
commit 4c62cdeefa
2 changed files with 5 additions and 3 deletions
@@ -503,8 +503,10 @@ fn text_animate_menu_adds_an_animator_with_the_property() {
let mut h = harness(s);
h.state_mut().ui.timeline.open_groups.insert(text);
open_layer(&mut h, l);
// The Properties panel's Position row has the same accessible name: take the menu's new entry.
let shown: Vec<_> = h.query_all_by_label("Position").map(|n| n.rect()).collect();
click(&mut h, &format!("timeline.group.{text}.animate"));
let entry = h.get_by_label("Position").rect();
let entry = h.query_all_by_label("Position").map(|n| n.rect()).find(|r| !shown.contains(r)).expect("the Animate menu's Position entry");
click_at(&mut h, entry.center());
let animators = |h: &Harness<'_, EffectcraftApp>| {
h.state().session.active_comp().unwrap().layer(LayerId(l)).unwrap().props.sub("text").unwrap().sub("animators").cloned()
@@ -44,7 +44,7 @@ const BASELINE: &[(&str, usize, usize)] = &[
("Timeline:default", 89, 42),
("Audio:default", 4, 2),
("Properties:default", 31, 15),
("Character:default", 42, 21),
("Character:default", 46, 22),
("Paragraph:default", 26, 13),
("Align:default", 12, 0),
("Tracker:default", 11, 3),
@@ -186,7 +186,7 @@ fn audit(h: &Harness<'_, EffectcraftApp>, scenario: &str, scope: Rect, since: Op
let role = a.role();
let actionable = a.data().supports_action(Action::Click) || a.data().supports_action(Action::Focus);
let control = CONTROL_ROLES.contains(&role);
if !control && !(actionable && matches!(role, Role::Unknown | Role::GenericContainer)) {
if !(control || (actionable && matches!(role, Role::Unknown | Role::GenericContainer))) {
continue;
}
let name = a.label().unwrap_or_default();