aleleba/vectorcraft
1
0
Fork 0
mirror of https://github.com/storytold/vectorcraft.git synced 2026-10-28 03:37:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4288 from Silvertree2010/fix/h2791-mcp-resource-uri-percent-decoder

Browse Source 
Only treat % plus two hex digits as an escape in MCP resource URIs
This commit is contained in:
BFlat
2026-10-27 15:08:50 +07:00
committed by GitHub
parent 8d854bda27 76e0e5b0ac
commit 355dcf53d6
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/mcp/src/resources.rs
+11
View File
@@ -166,6 +166,8 @@ fn decode(s: &str) -> String {
while let Some(b) = bytes.get(i).copied() {
if b == b'%'
&& i + 2 < bytes.len()
&& let Some(digits) = bytes.get(i + 1..i + 3)
&& digits.iter().all(u8::is_ascii_hexdigit)
&& let Ok(byte) = u8::from_str_radix(s.get(i + 1..i + 3).unwrap_or(""), 16)
{
out.push(byte);
@@ -211,6 +213,15 @@ const MAX_CATALOGUE: usize = 20_000;
mod tests {
use super::*;
#[test]
fn decode_only_accepts_two_hex_digits() {
assert_eq!(decode("a%+1b"), "a%+1b");
assert_eq!(decode("a%-1b"), "a%-1b");
assert_eq!(decode("a%+Fb"), "a%+Fb");
assert_eq!(decode("a%4"), "a%4");
assert_eq!(decode("Brand%2040%25"), "Brand 40%");
}
#[test]
fn variables_are_split_out_and_decoded() {
assert_eq!(variable("vectorcraft://object/42", "vectorcraft://object/{id}"), "42");