aleleba/vectorcraft
1
0
Fork 0
mirror of https://github.com/storytold/vectorcraft.git synced 2026-11-13 01:14:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

Character Styles: a tint error names the Fill Tint or Stroke Tint field

Browse Source 
An out-of-range or non-numeric tint in Character Style Options and New
Character Style gave "Tint must be a number from 0 to 100" for both
fields, so the message did not say which of the two to correct. It now
names "Fill Tint" or "Stroke Tint", the names the two fields carry.
This commit is contained in:
dotCooCoo
2026-11-10 23:27:36 -08:00
parent 6a5854ec5f
commit 2443d1250b
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/dialogs/char_style_options.rs
+4 -3
View File
@@ -251,7 +251,8 @@ fn optional_number(d: &Dialog, key: &str) -> Result<Option<Value>, String> {
"v_scale" => tl!("Vertical Scale"),
"baseline_shift" => tl!("Baseline Shift"),
"rotation" => tl!("Character Rotation"),
"fill_tint" | "stroke_tint" => tl!("Tint"),
"fill_tint" => tl!("Fill Tint"),
"stroke_tint" => tl!("Stroke Tint"),
"stroke_width" => tl!("Weight"),
_ => return Err("unknown character style number field".into()),
};
@@ -1649,8 +1650,8 @@ mod tests {
fn color_tint_and_weight_outside_their_limits_are_errors() {
let linked = json!({"type": "solid", "color": {"model": "gray", "k": 0.5}, "swatch": "Ink"});
for (key, value, message) in [
("fill_tint", "150", "Tint must be a number from 0 to 100"),
("stroke_tint", "-1", "Tint must be a number from 0 to 100"),
("fill_tint", "150", "Fill Tint must be a number from 0 to 100"),
("stroke_tint", "-1", "Stroke Tint must be a number from 0 to 100"),
("stroke_width", "-1", "Weight must be a number from 0 to 4000000"),
("stroke_width", "thick", "Weight must be a number"),
] {