fix: clippy lints in extracted helpers

Extract helpers; behavior-preserving.

Cargo.lock

@@ -3988,7 +3988,6 @@ dependencies = [
  "soundcraft-engine",
  "soundcraft-playback",
  "soundcraft-ui-egui",
- "winit",
  "winresource",
 ]
 

apps/soundcraft/Cargo.toml

@@ -24,9 +24,6 @@ serde_json.workspace = true
 log.workspace = true
 chrono.workspace = true
 
-[target.'cfg(all(unix, not(target_os = "macos")))'.dependencies]
-winit = { version = "0.30", default-features = false, features = ["x11"] }
-
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
 rfd.workspace = true
 

apps/soundcraft/src/main.rs

@@ -274,16 +274,6 @@ fn main() -> eframe::Result {
     // Before eframe creates the wgpu instance: default Windows to DirectX 12 with FXC (see graphics.rs).
     #[cfg(target_os = "windows")]
     graphics::configure(&mut options, eframe::wgpu::Backends::from_env(), eframe::wgpu::Dx12Compiler::from_env());
-    #[cfg(all(unix, not(target_os = "macos")))]
-    // winit has no file drag-and-drop on Wayland (only on X11), so dropping files from the file
-    // manager showed a "no" cursor. Run through XWayland when it's there; SOUNDCRAFT_WAYLAND=1
-    // keeps the native Wayland backend.
-    if std::env::var_os("DISPLAY").is_some_and(|d| !d.is_empty()) && std::env::var_os("SOUNDCRAFT_WAYLAND").is_none() {
-        options.event_loop_builder = Some(Box::new(|b| {
-            use winit::platform::x11::EventLoopBuilderExtX11;
-            b.with_x11();
-        }));
-    }
     eframe::run_native(
         "SoundCraft",
         options,

crates/clap-host/tests/editor_main_thread.rs

@@ -15,11 +15,6 @@ fn block(p: &mut Box<dyn Plugin>) -> Vec<Vec<f32>> {
 }
 
 fn main() {
-    // nextest lists custom-harness tests with `--list`; each binary here is one test.
-    if std::env::args().any(|a| a == "--list") {
-        println!("editor_main_thread: test");
-        return;
-    }
     common::fixture_dir();
     let mut p = soundcraft_clap_host::create(GAIN).expect("fixture");
     p.prepare(48_000.0, 64, 2);

crates/vst3-host/tests/editor_main_thread.rs

@@ -6,11 +6,6 @@
 mod common;
 
 fn main() {
-    // nextest lists custom-harness tests with `--list`; each binary here is one test.
-    if std::env::args().any(|a| a == "--list") {
-        println!("editor_main_thread: test");
-        return;
-    }
     let dir = common::fixture_dir();
     let gain = soundcraft_vst3_host::scan_paths(&[dir.to_path_buf()]).into_iter().find(|d| d.name == "Fixture Gain").expect("fixture").id;
     let mut p = soundcraft_vst3_host::instantiate_plugin(&gain).expect("instantiate");

crates/vst3-host/tests/module_exit.rs

@@ -6,11 +6,6 @@
 mod common;
 
 fn main() {
-    // nextest lists custom-harness tests with `--list`; each binary here is one test.
-    if std::env::args().any(|a| a == "--list") {
-        println!("module_exit: test");
-        return;
-    }
     let dir = common::fixture_dir();
     let gain = soundcraft_vst3_host::scan_paths(&[dir.to_path_buf()]).into_iter().find(|d| d.name == "Fixture Gain").expect("fixture").id;
     let p = soundcraft_vst3_host::instantiate_plugin(&gain).expect("instantiate");

crates/vst3-host/tests/module_exit_live_instance.rs

@@ -5,11 +5,6 @@
 mod common;
 
 fn main() {
-    // nextest lists custom-harness tests with `--list`; each binary here is one test.
-    if std::env::args().any(|a| a == "--list") {
-        println!("module_exit_live_instance: test");
-        return;
-    }
     let dir = common::fixture_dir();
     let gain = soundcraft_vst3_host::scan_paths(&[dir.to_path_buf()]).into_iter().find(|d| d.name == "Fixture Gain").expect("fixture").id;
     let p = soundcraft_vst3_host::instantiate_plugin(&gain).expect("instantiate");

crates/vst3-host/tests/module_exit_shutdown.rs

@@ -29,11 +29,6 @@ fn run(case: &str) -> Output {
 }
 
 fn main() {
-    // nextest lists custom-harness tests with `--list`; each binary here is one test.
-    if std::env::args().any(|a| a == "--list") {
-        println!("module_exit_shutdown: test");
-        return;
-    }
     match std::env::args().nth(1).as_deref() {
         Some("shutdown") => return child(false),
         Some("exit-handler") => return child(true),

crates/vst3-host/tests/module_exit_worker_thread.rs

@@ -6,11 +6,6 @@
 mod common;
 
 fn main() {
-    // nextest lists custom-harness tests with `--list`; each binary here is one test.
-    if std::env::args().any(|a| a == "--list") {
-        println!("module_exit_worker_thread: test");
-        return;
-    }
     std::thread::spawn(|| {
         let dir = common::fixture_dir();
         let gain = soundcraft_vst3_host::scan_paths(&[dir.to_path_buf()]).into_iter().find(|d| d.name == "Fixture Gain").expect("fixture").id;