aleleba/pdfcraft
1
0
Fork 0
mirror of https://github.com/storytold/pdfcraft.git synced 2026-11-01 05:58:12 -06:00
Code Issues Packages Projects Releases Wiki Activity

M3: pin the reported OS in the panel snapshot harness

Browse Source 
Shortcut labels follow the OS egui reports ("Ctrl+B" against "⌘B"), so
the snapshots were only host-independent because kittest happens to
default to Nix. Pin it explicitly. With the OS set to Mac the test fails
on the Bookmarks panel's "New bookmark (⌘B)" button.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Dubblbindong
2026-10-20 20:46:47 +02:00
co-authored by Claude Opus 5.5
parent 14471d76f4
commit 93945aeade
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/tests/panel_snapshots.rs
+7 -4
View File
@@ -1,8 +1,9 @@
//! Snapshot tests of every side panel (M3): each panel opens on one synthetic document and its
//! AccessKit tree (the roles, labels, values and states a screen reader gets) is compared with a
//! text file in `tests/snapshots/`. Text rather than pixels: it is the same on every platform and
//! GPU, it is not an asset (AGENTS.md §1), and a reviewer can read a change in the diff. Positions
//! are left out, so moving a widget is not a change but adding, removing or renaming one is.
//! text file in `tests/snapshots/`. Text rather than pixels: with the reported OS pinned (shortcut
//! labels follow it) it is the same on every platform and GPU, it is not an asset (AGENTS.md §1),
//! and a reviewer can read a change in the diff. Positions are left out, so moving a widget is not
//! a change but adding, removing or renaming one is.
//!
//! `UPDATE_SNAPSHOTS=1 cargo test -p pdfcraft-ui-egui --test panel_snapshots` rewrites the files.
@@ -73,7 +74,9 @@ fn fixture() -> Vec<u8> {
fn harness(panel: &'static str) -> Harness<'static, PdfCraftApp> {
let bytes = fixture();
let mut h = Harness::builder().with_size(egui::vec2(1400.0, 900.0)).build_eframe(move |_cc| {
// Shortcut labels follow the reported OS ("Ctrl+B" against "⌘B"), so pin it rather than rely
// on kittest's default; the snapshots then match on every host.
let mut h = Harness::builder().with_size(egui::vec2(1400.0, 900.0)).with_os(egui::os::OperatingSystem::Nix).build_eframe(move |_cc| {
let mut app = PdfCraftApp::new();
app.set_option("language", "en").unwrap();
app.open_bytes("panels.pdf", None, bytes).expect("opens");