aleleba/lightcraft
1
0
Fork 0
mirror of https://github.com/storytold/lightcraft.git synced 2026-10-29 04:27:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Docking: a panel with no recorded place opens beside the photo on its side

Browse Source 
Showing a panel that has no hidden entry skips craft-ui's right-edge
fallback and opens it beside the photo view on the panel's default side.
Test: Library opens to the left of the photo, Presets to the right.
This commit is contained in:
aiongg
2026-10-24 23:36:03 +00:00
parent ee1576682a
commit e442e3d220
1 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/docking.rs
+19 -4
View File
@@ -128,10 +128,14 @@ fn set_visible(workspace: &mut Workspace, panel: Panel, visible: bool) -> Result
return apply(workspace, Action::Close { panel });
}
validate(workspace)?;
let mut next = workspace.clone();
if next.set_visible(panel, true, None, permissions).is_ok() && validate(&next).is_ok() {
*workspace = next;
return Ok(());
// Without a recorded place craft-ui opens the panel at the right edge; LightCraft puts it
// beside the photo instead.
if workspace.hidden.iter().any(|(hidden, _)| *hidden == panel) {
let mut next = workspace.clone();
if next.set_visible(panel, true, None, permissions).is_ok() && validate(&next).is_ok() {
*workspace = next;
return Ok(());
}
}
apply(workspace, Action::OpenAt { panel, anchor: Panel::Canvas, placement: Placement::Split(panel.default_side()) })
}
@@ -578,4 +582,15 @@ mod tests {
assert_eq!(saved["version"], 2);
assert_eq!(saved["layout"]["floating"][0]["panels"], json!(["tools"]), "a one-group window keeps the v1 shape");
}
#[test]
fn a_panel_without_a_recorded_place_opens_beside_the_photo_on_its_side() {
for (panel, zone) in [(Panel::Library, Zone::Left), (Panel::Presets, Zone::Right)] {
let root = split(SplitAxis::Horizontal, SplitSize::FixedSecond(300.0), tabs(Panel::Canvas), tabs(Panel::Tools));
let mut workspace = Workspace::new(Layout { root: Some(root), floating: Vec::new() });
set_visible(&mut workspace, panel, true).unwrap();
let location = workspace.layout.location(&panel).unwrap();
assert_eq!((location.anchor, location.placement), (Some(Panel::Canvas), Placement::Split(zone)), "{panel:?}");
}
}
}