aleleba/lightcraft
1
0
Fork 0
mirror of https://github.com/storytold/lightcraft.git synced 2026-10-27 19:47:35 -06:00
Code Issues Packages Projects Releases Wiki Activity

LR-VIEW-ZOOM: hidden-window test drags twice so it catches a missing frame-time bound (#330)

Browse Source 
One slow drag only makes the pair suspect, so a single hidden-window
drag passed even without the FRAME_MS_KNOWN upper bound. Two such drags
followed by a full-size third fail (0.6) when the bound is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Matthew James Sivak
2026-10-13 14:11:27 +02:00
co-authored by Claude Opus 5.5
parent 8d91abe603
commit 6a66860ea9
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/region.rs
+9 -6
View File
@@ -703,18 +703,21 @@ mod tests {
}
// Given draft frames that took seconds (the window hidden or occluded mid-drag), they count as
// unknown: fast renders don't mark the drag slow because the window wasn't drawing
// unknown: fast renders don't mark the drag slow because the window wasn't drawing. Two such
// drags, since one slow drag only makes the pair suspect
#[test]
fn a_hidden_windows_frame_times_dont_mark_a_drag_slow() {
use lightcraft_catalog::PhotoId;
let mut d = DragScale::default();
let drag = Some((PhotoId(1), "Exposure"));
d.scale(drag, true, None, 0.0);
for key in 1..=6 {
d.observe(key, 6.0, Some(4000.0));
for t in 0..2u32 {
assert_eq!(d.scale(drag, true, None, f64::from(t)), Some(1.0), "drag {}", t + 1);
for key in 1..=6 {
d.observe(u64::from(t) * 10 + key, 6.0, Some(4000.0));
}
d.scale(None, true, None, f64::from(t));
}
d.scale(None, true, None, 0.0);
assert_eq!(d.scale(drag, true, None, 0.0), Some(1.0));
assert_eq!(d.scale(drag, true, None, 2.0), Some(1.0), "after two hidden-window drags: still full size");
}
// Given full-size drafts far over budget (a refined mask the CPU renders at 190 ms a step),