mirror of
https://github.com/storytold/lightcraft.git
synced 2026-10-28 20:17:18 -06:00
Merge pull request #2700 from dylanmtaylor/sonar/security-reliability
fix: document the deliberate buffer leak during thread teardown (SonarCloud)
This commit is contained in:
@@ -118,7 +118,9 @@ impl Drop for Buf {
|
||||
let mut b = Some(b);
|
||||
let _ = RETIRED.try_with(|r| r.0.borrow_mut().extend(b.take()));
|
||||
match b {
|
||||
Some(b) => std::mem::forget(b),
|
||||
// Leaking is deliberate during thread teardown — dropping a wgpu buffer whose device
|
||||
// thread-locals have already gone can abort the process. The device owns it.
|
||||
Some(b) => std::mem::forget(b), // NOSONAR
|
||||
None => {
|
||||
RETIRED_BYTES.fetch_add(size, Ordering::Relaxed);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user