aleleba/lightcraft
1
0
Fork 0
mirror of https://github.com/storytold/lightcraft.git synced 2026-10-28 20:17:18 -06:00
Code Issues Packages Projects Releases Wiki Activity

Issue #989: the Export dialog height test expects the macOS row (Add to Apple Photos, 876 pt)

Browse Source 
export_dialog_is_unchanged_in_a_tall_window expected 846 pt on every platform.
a6431c15 (add exported files to Apple Photos, #236) put a macOS-only checkbox at
the end of the dialog, so on macOS it is 876 pt tall at 1600x1000 (measured:
[[492 62] - [1107.2 938]]). The test failed on macOS on upstream main (76b53778)
with no other change; it is unchanged on other platforms.

Run on macOS (rustc 1.99.0): the five tests in tests_dialog_fit pass, cargo fmt
is clean, clippy over lightcraft-ui-egui with --all-targets is clean. Not run on
Linux or FreeBSD, where the expectation stays 846.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Alfons Hoogervorst
2026-10-11 17:42:25 +02:00
co-authored by Claude Sonnet 5.5
parent 76b5377868
commit 0e53cfc240
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/tests_dialog_fit.rs
+4 -2
View File
@@ -94,8 +94,10 @@ fn export_dialog_is_unchanged_in_a_tall_window() {
assert_fits(&h, "Export at 1600×1000");
let dialog = rect(&h, "dialog:window");
// (846 tall as before #781: the whole dialog, nothing scrolled away; 615 wide since the
// format row gained JPEG XL, #780)
assert!((dialog.height() - 846.0).abs() <= 1.0, "{dialog:?}");
// format row gained JPEG XL, #780. On macOS the dialog has one more row, "Add to Apple Photos"
// (#236), so it is 876 tall there)
let height = if cfg!(target_os = "macos") { 876.0 } else { 846.0 };
assert!((dialog.height() - height).abs() <= 1.0, "{dialog:?}");
assert!((dialog.width() - 615.2).abs() <= 1.0, "{dialog:?}");
}