aleleba/lightcraft
1
0
Fork 0
mirror of https://github.com/storytold/lightcraft.git synced 2026-10-26 11:09:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

LRC-LIB-SMARTCOLL: yes/no rule values accept 1.0 and 0.0

Browse Source 
From review: an agent sending a float (1.0) was refused while 1 was
accepted. Any number equal to 1 or 0 now reads as yes or no; other
numbers (2, 0.5, -1) are still refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Nathaniel Ledford
2026-10-09 10:54:56 -04:00
co-authored by Claude Opus 5.5
parent b0de6d3fef
commit 07d5bc3152
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/catalog/src/rules.rs
+8 -8
View File
@@ -146,15 +146,15 @@ pub fn field_group(field: &str) -> Option<&'static str> {
FIELD_GROUPS.iter().find(|g| g.1.contains(&field)).map(|g| g.0)
}
/// What a yes/no rule's value means: `true`, `"yes"`, `1` or no value is yes; `false`, `"no"`, `0`
/// is no (strings in any case); `None` for anything else, which matches nothing.
/// What a yes/no rule's value means: `true`, `"yes"`, `1` (or `1.0`) or no value is yes; `false`,
/// `"no"`, `0` is no (strings in any case); `None` for anything else, which matches nothing.
pub fn bool_value(value: &Value) -> Option<bool> {
match value {
Value::Bool(b) => Some(*b),
Value::Null => Some(true),
Value::Number(n) => match n.as_u64() {
Some(1) => Some(true),
Some(0) => Some(false),
Value::Number(n) => match n.as_f64() {
Some(1.0) => Some(true),
Some(0.0) => Some(false),
_ => None,
},
Value::String(s) => match s.trim().to_lowercase().as_str() {
@@ -907,13 +907,13 @@ mod tests {
/// are yes. Anything else is reported, not silently taken as yes.
#[test]
fn yes_no_values() {
for v in [json!(true), json!("true"), json!("Yes"), json!(1), json!(null)] {
for v in [json!(true), json!("true"), json!("Yes"), json!(1), json!(1.0), json!(null)] {
assert_eq!(bool_value(&v), Some(true), "{v}");
}
for v in [json!(false), json!("false"), json!(" NO "), json!(0)] {
for v in [json!(false), json!("false"), json!(" NO "), json!(0), json!(0.0)] {
assert_eq!(bool_value(&v), Some(false), "{v}");
}
for v in [json!("maybe"), json!(2), json!([true]), json!({"x": 1})] {
for v in [json!("maybe"), json!(2), json!(0.5), json!(-1), json!([true]), json!({"x": 1})] {
assert_eq!(bool_value(&v), None, "{v}");
}
assert_eq!((bool_label(true), bool_label(false)), ("Yes", "No"));