aleleba/gridcraft
1
0
Fork 0
mirror of https://github.com/storytold/gridcraft.git synced 2026-10-24 10:46:50 -06:00
Code Issues Packages Projects Releases Wiki Activity

perf(engine): scan only the precedent area's stored cells

Browse Source 
iter_range walks the sparse store's bands for the area's row range
only, so a chain of N formulas no longer rescans every stored cell of
the sheet per area.

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
bfenty
2026-10-19 19:47:07 +00:00
co-authored by Claude
parent d19627fc26
commit 871c4e6c8f
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/engine/src/cmd/formulas.rs
+6 -5
View File
@@ -498,12 +498,13 @@ fn select_trace_cells(s: &mut Session, p: &Json, precedents: bool) -> Result<Jso
if precedents {
for a in d.calc.graph.precedents_of((ks, kc)) {
if all {
// Walk the sheet's stored cells inside the precedent area: blanks are
// never selected and only formula cells extend the frontier, so a
// formula late in a large range is not skipped.
// Walk only the stored cells inside the precedent area (sparse
// range iterator, not the whole sheet): blanks are never selected
// and only formula cells extend the frontier, so a formula late in
// a large range is not skipped.
let Some(sh) = d.wb.sheet(a.sheet) else { continue };
for (c, cell) in sh.cells.iter() {
if !a.range.contains(c) || matches!(cell.value, Value::Empty) {
for (c, cell) in sh.cells.iter_range(a.range) {
if matches!(cell.value, Value::Empty) {
continue;
}
if seen.insert((a.sheet, c)) {