mirror of
https://github.com/storytold/gridcraft.git
synced 2026-10-25 19:26:50 -06:00
Review fix-up: ignore the wall-clock scaling test by default; check its values every run
recalc_with_range_formulas_scales_linearly is flaky under load, so it is #[ignore]d (run with --ignored in release). A small range_formulas_recalc_and_bulk_edit_correctly test keeps the helper's value check in every run. The helper reads Instant::now, so it allows clippy::disallowed_methods (required once #125's clippy.toml lands). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
11472b340b
commit
86328ec843
@@ -953,6 +953,7 @@ mod tests {
|
||||
}
|
||||
|
||||
/// Opening (full recalc), changing every value of a column, and re-entering every formula.
|
||||
#[allow(clippy::disallowed_methods)] // a native-only timing test: the clock is read off wasm
|
||||
fn open_and_bulk_edit(rows: u32) -> Duration {
|
||||
let mut wb = sum_rows(rows);
|
||||
let mut calc = Calc::new();
|
||||
@@ -975,6 +976,14 @@ mod tests {
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn range_formulas_recalc_and_bulk_edit_correctly() {
|
||||
// The values behind the timing test below, checked on every run.
|
||||
open_and_bulk_edit(500);
|
||||
}
|
||||
|
||||
#[test]
|
||||
#[ignore = "timing-sensitive; run with --ignored in release"]
|
||||
#[allow(clippy::disallowed_methods)]
|
||||
fn recalc_with_range_formulas_scales_linearly() {
|
||||
// Each row's SUM reads a range in the same columns. Recalculating on open used to walk
|
||||
// every row per range read (the used range), and finding a cell's dependents scanned
|
||||
|
||||
Reference in New Issue
Block a user