aleleba/filmcraft
1
0
Fork 0
mirror of https://github.com/storytold/filmcraft.git synced 2026-10-24 10:10:05 -06:00
Code Issues Packages Projects Releases Wiki Activity

security(dnx): validate fields before frame allocation (#2914)

Browse Source
This commit is contained in:
Earl Co
2026-10-23 10:53:38 -04:00
committed by GitHub
parent b12336cf73
commit 70d0260b6e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/dnx/src/decode.rs
+3 -1
View File
@@ -54,9 +54,11 @@ pub fn decode_frame_with(data: &[u8], opts: &DecodeOptions) -> Result<Frame> {
} else {
(decode_unit(&h1, &data[..off], opts), decode_unit(&h2, &data[off..], opts))
};
let (top, bottom) = if h1.field == FieldCode::Field2 { (p2?, p1?) } else { (p1?, p2?) };
// Both field payloads must be valid before committing the full-frame
// allocation; a damaged header alone must not allocate an output picture.
let mut f = Frame::new_like(&h1, h1.width, h1.lines * 2);
f.interlace = Interlace::TopFieldFirst;
let (top, bottom) = if h1.field == FieldCode::Field2 { (p2?, p1?) } else { (p1?, p2?) };
top.copy_into(&mut f, 0, 2);
bottom.copy_into(&mut f, 1, 2);
Ok(f)