aleleba/effectcraft
1
0
Fork 0
mirror of https://github.com/storytold/effectcraft.git synced 2026-10-26 11:07:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

D2a: dock tabs carry their drawn titles as automation labels; group top borders get panel.border ids

Browse Source 
Tab and stacked-header automation labels name what the panel shows
("Composition A"), as the tabs do. The top border above a group's tabs,
a craft-ui drag source, registers panel.border.<Panel>, which the agent
audit found without an id.
This commit is contained in:
aiongg
2026-10-25 05:41:47 +00:00
parent 85ffe0ca1c
commit e89aff1e99
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/dock.rs
+2 -1
View File
@@ -180,7 +180,8 @@ pub fn permissions(_panel: &PanelKind) -> Permissions {
pub fn tabs(p: &[PanelKind], active: usize) -> Node<PanelKind> {
Node::Tabs { panels: p.to_vec(), active }
}
/// Stacked panels: (panel, open, height).
/// Stacked panels: (panel, open, height). Open entries share the stack's height in proportion to
/// their heights; an entry without one counts as craft-ui's `DockStyle::min_pane` (40).
pub fn stack(e: &[(PanelKind, bool, Option<f32>)]) -> Node<PanelKind> {
Node::Stack { entries: e.iter().map(|&(panel, open, height)| StackEntry { panel, open, height }).collect() }
}
crates/ui-egui/src/dock_ui.rs
+9 -4
View File
@@ -447,20 +447,25 @@ impl EffectcraftApp {
}
/// Automation ids for craft-ui's gesture sources: `panel.tab.<Panel>`, `panel.drag.<Panel>`
/// (the group's drag bar), `panel.tabs.more.<Panel>`, `panel.header.<Panel>` (a stacked
/// panel's open/close button), `panel.float.<n>.move`, `.close`, `.resize` (bottom-right
/// (the group's drag bar), `panel.border.<Panel>` (the top border above its tabs),
/// `panel.tabs.more.<Panel>`, `panel.header.<Panel>` (a stacked panel's open/close button),
/// `panel.float.<n>.move`, `.close`, `.resize` (bottom-right
/// corner) and `.resize.<Edge>`, `dock.gutter.<path>` (`a`/`b` per split level; a stack's gap
/// below entry `i` adds `s<i>`), `dock.corner.<outer>.<inner>` where two dividers meet, and
/// the same inside floating window `n` as `panel.float.<n>.gutter.…` and `.corner.…`.
fn register_dock_hits(&mut self, hits: &[(Hit<PanelKind>, Rect)]) {
let window = |panel: &PanelKind| self.ui.dock.layout.floating.iter().position(|window| window.contains(panel));
// Tabs are labelled as drawn: "Composition Intro", not "Composition".
let titles = self.tab_titles();
let title = |panel: &PanelKind| titles.iter().find(|(p, _)| p == panel).map_or_else(|| panel.title().to_string(), |(_, t)| t.clone());
let mut found = Vec::new();
for (hit, rect) in hits {
let entry = match hit {
Hit::Tab(panel) => (format!("panel.tab.{}", panel.id()), panel.title().to_string()),
Hit::Tab(panel) => (format!("panel.tab.{}", panel.id()), title(panel)),
Hit::DragBar(panel) => (format!("panel.drag.{}", panel.id()), "Move panel group".into()),
Hit::Border(panel) => (format!("panel.border.{}", panel.id()), "Move panel group".into()),
Hit::Overflow(panel) => (format!("panel.tabs.more.{}", panel.id()), "More tabs".into()),
Hit::StackToggle(panel) => (format!("panel.header.{}", panel.id()), panel.title().to_string()),
Hit::StackToggle(panel) => (format!("panel.header.{}", panel.id()), title(panel)),
Hit::Title(panel) => match window(panel) {
Some(index) => (format!("panel.float.{index}.move"), "Move floating panel".into()),
None => continue,