aleleba/effectcraft
1
0
Fork 0
mirror of https://github.com/storytold/effectcraft.git synced 2026-10-30 13:08:07 -06:00
Code Issues Packages Projects Releases Wiki Activity

Reject '+' signs in Lottie text stroke colour hex pairs

Browse Source 
Found while testing crates/lottie/src/import.rs:48-51 (hex_color)

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
NetterSilver
2026-10-28 00:43:35 +01:00
co-authored by Claude Haiku 5.5
parent af415aa6e1
commit d6308c6eed
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/lottie/src/import.rs
+15 -1
View File
@@ -47,7 +47,9 @@ fn s<'a>(j: &'a Json, k: &str) -> Option<&'a str> {
fn hex_color(sc: &str) -> [f32; 3] {
let h = sc.trim_start_matches('#');
let c = |i: usize| h.get(i..i + 2).and_then(|x| u8::from_str_radix(x, 16).ok()).unwrap_or(0) as f32 / 255.0;
let c = |i: usize| {
h.get(i..i + 2).filter(|x| x.bytes().all(|b| b.is_ascii_hexdigit())).and_then(|x| u8::from_str_radix(x, 16).ok()).unwrap_or(0) as f32 / 255.0
};
[c(0), c(2), c(4)]
}
@@ -485,3 +487,15 @@ fn build_layers(cx: &mut Ctx, project: &mut Project, comp: &mut Comp, layers: &[
}
}
}
#[cfg(test)]
mod hex_color_tests {
use super::hex_color;
#[test]
fn hex_color_rejects_plus_sign() {
assert_eq!(hex_color("#+f0000"), [0.0, 0.0, 0.0]);
assert_eq!(hex_color("#zz0000"), [0.0, 0.0, 0.0]);
assert_eq!(hex_color("#ff0000"), [1.0, 0.0, 0.0]);
}
}