aleleba/designcraft
1
0
Fork 0
mirror of https://github.com/storytold/designcraft.git synced 2026-10-24 10:16:59 -06:00
Code Issues Packages Projects Releases Wiki Activity

Keep text of inline content controls in DOCX import

Browse Source 
Found while testing crates/textimport/src/docx.rs:354

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
NetterSilver
2026-10-15 15:24:11 +00:00
co-authored by Claude Haiku 5.5
parent a930276fd7
commit 108427e216
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/textimport/src/docx.rs
+20
View File
@@ -352,6 +352,12 @@ impl Ctx {
// Tracked changes import as accepted: insertions and move destinations are kept,
// deletions (`del`) and move sources (`moveFrom`) are dropped.
"hyperlink" | "smartTag" | "ins" | "moveTo" | "fldSimple" | "customXml" => self.inline(e, st, allow_notes),
// A content control (date picker, drop-down, plain text) keeps its runs in `sdtContent`.
"sdt" => {
if let Some(c) = e.child("sdtContent") {
self.inline(c, st, allow_notes);
}
}
_ => {}
}
}
@@ -620,6 +626,20 @@ mod tests {
assert_eq!(i.char_styles[0].chars.font_style.as_deref(), Some("Italic"));
}
/// A content control inside a paragraph (`w:sdt`) keeps its text, also around a hyperlink.
#[test]
fn inline_content_control_text_is_kept() {
let document = format!(
r#"<w:document {W}><w:body>
<w:p><w:r><w:t xml:space="preserve">Date: </w:t></w:r><w:sdt><w:sdtPr><w:alias w:val="d"/></w:sdtPr><w:sdtContent><w:r><w:t>1 May 2026</w:t></w:r></w:sdtContent></w:sdt><w:r><w:t>.</w:t></w:r></w:p>
<w:p><w:sdt><w:sdtContent><w:hyperlink><w:r><w:t>Link</w:t></w:r></w:hyperlink></w:sdtContent></w:sdt></w:p>
</w:body></w:document>"#
);
let st = import(&docx(&document, "", "")).unwrap().story;
st.check().unwrap();
assert_eq!(st.text, "Date: 1 May 2026.\nLink");
}
/// A page break ends its paragraph: the text after it is a paragraph of its own (same style).
#[test]
fn page_break_ends_its_paragraph() {