mirror of
https://github.com/storytold/deckcraft.git
synced 2026-11-09 11:59:36 -06:00
FredAppsandFredApps
90058395b7
* docs: track WASM presenter popout work (#729) * Fix presenter transport retries and initialize popup note fonts * Clarify optional font coverage and source-verified popup lifecycle --------- Co-authored-by: FredApps <FredApps@users.noreply.github.com>
66 lines
4.2 KiB
Markdown
66 lines
4.2 KiB
Markdown
# WASM presenter-view popout (#729)
|
|
|
|
Tracks https://github.com/storytold/deckcraft/issues/729 (the reporter moved duplicate #726 here).
|
|
|
|
## Implementation
|
|
|
|
The browser presenter opens the same DeckCraft web build in a separate, same-origin window.
|
|
That window starts its own eframe runner and renders only presenter controls, current/next
|
|
previews and notes. The audience window remains the sole owner of slideshow state, animations,
|
|
media and navigation. Presenter keyboard input uses the same navigation handler as the native
|
|
presenter, so an input is applied once rather than advancing two independent shows.
|
|
|
|
Messages check the exact origin, source window and a per-opening session identifier. Input
|
|
queues and preview dimensions are bounded. Previews use the audience's rendered current frame;
|
|
unchanged preview pixels are not retransmitted. Presenter updates are limited to five per second.
|
|
|
|
If the browser blocks the initial popup, an explicit Open presenter window button calls the
|
|
browser API directly from its click handler. Browser policy can still require the user to allow
|
|
popups, or choose to open a tab instead of a window. Closing the presenter leaves the audience
|
|
running and offers the same button to reopen it. Ending the show closes the presenter. The
|
|
presenter reports a closed or unresponsive audience rather than continuing an independent show.
|
|
Native presenter view continues to use its existing egui viewport.
|
|
|
|
No native second-display placement, Linux display-counting policy, laser/rehearsal changes or
|
|
other contributors' unmerged presenter work is included.
|
|
|
|
## Validation
|
|
|
|
Candidate implementation; not yet qualified for release. The current-main reconciliation and
|
|
transport/font corrections have had source inspection and static diff checks only. No local Rust
|
|
builds, tests or formatter were run for this candidate; hosted compilation and regression tests
|
|
remain pending. Earlier-head validation recorded in the PR does not qualify this changed tree.
|
|
The original bug was reproduced on the deployed 0.7.0 browser build on 2026-10-14; that
|
|
deployment's exact commit is unknown.
|
|
|
|
Regression coverage submitted for hosted execution checks successful image deduplication,
|
|
failed-send retries, session/reload refresh and clearing previews. The independent popup uses
|
|
the existing interface font definitions and UiFonts fallback discovery before laying out notes,
|
|
discarding font-install passes before input forwarding. Its font regression checks bundled
|
|
Arabic/Japanese/Hangul glyphs when those optional font inputs are present; missing optional
|
|
inputs do not establish script coverage.
|
|
|
|
Source inspection verifies these lifecycle paths: a blocked popup offers an explicit retry
|
|
whose click handler calls the browser API; closing the popup offers reopening; ending the show
|
|
closes the popup; incoming messages check origin, source window and opening-session token.
|
|
This establishes the intended control flow, not empirical compatibility with each browser.
|
|
|
|
Runtime checks that would add empirical coverage with a synthetic deck:
|
|
|
|
- Popup allowed and blocked, explicit retry, and independent window positioning.
|
|
- Initial popup behavior in Safari and Firefox, including whether explicit retry is needed on
|
|
each show start. These browser families have not been exercised for this candidate; missing
|
|
manual coverage alone is not evidence of a defect or a mandatory merge blocker.
|
|
- Next/Previous, Home/End, numeric navigation, and no double advance on Space/Enter.
|
|
- Current/next previews, notes, pause/reset, black/white screens, All Slides and zoom.
|
|
- Navigation from both windows, including animation steps and the end screen.
|
|
- Close/reopen the presenter, reload it, end/restart the show, and close/reload the audience.
|
|
- Rejection of messages from the wrong origin, source window or prior session.
|
|
- Native presenter regressions, WASM compilation and the full repository quality gates.
|
|
|
|
All runtime items above, including actual browser popup/reload/end-show execution, remain
|
|
unexecuted for this candidate. Shared native tests and source inspection do not constitute
|
|
browser-executed validation. Font subsets can legitimately omit individual script families;
|
|
the regression always checks installation/layout/discard handling, and checks a script's glyphs
|
|
only when its corresponding bundled face is present.
|