aleleba/deckcraft
1
0
Fork 0
mirror of https://github.com/storytold/deckcraft.git synced 2026-11-03 08:50:47 -06:00
Code Issues Packages Projects Releases Wiki Activity

PPTX: reflection angles, skews and start position are written inside the schema's ranges

Browse Source
This commit is contained in:
Brandon Thomas
2026-11-03 08:50:28 -05:00
parent b61c5f11bd
commit c7b91ff2ec
2 changed files with 31 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/pptx/src/write/dml.rs
+8 -5
View File
@@ -357,13 +357,16 @@ pub fn effects(w: &mut W, fx: &Effects) {
.a("endA", pct(r.end_alpha.clamp(0.0, 1.0)))
.a("endPos", pct(r.end_pos.clamp(0.0, 1.0)))
.a("dist", emu(r.dist).max(0))
.o("stPos", r.st_pos)
.o("dir", r.dir)
.o("fadeDir", r.fade_dir)
// Kept from a file as read: held to the schema's ranges so a stray value can't
// make PowerPoint repair the file (ST_PositiveFixedAngle, ST_FixedAngle,
// ST_PositiveFixedPercentage).
.o("stPos", r.st_pos.map(|v| v.clamp(0, 100_000)))
.o("dir", r.dir.map(|v| v.rem_euclid(21_600_000)))
.o("fadeDir", r.fade_dir.map(|v| v.rem_euclid(21_600_000)))
.o("sx", r.sx)
.o("sy", r.sy)
.o("kx", r.kx)
.o("ky", r.ky)
.o("kx", r.kx.map(|v| v.clamp(-5_399_999, 5_399_999)))
.o("ky", r.ky.map(|v| v.clamp(-5_399_999, 5_399_999)))
.o("algn", r.align.as_deref())
.b("rotWithShape", r.rotate_with_shape),
);
crates/pptx/tests/it/roundtrip.rs
+23
View File
@@ -2094,3 +2094,26 @@ fn default_durations_match_powerpoint() {
assert_eq!(a.4, ms, "{effect}");
}
}
#[test]
fn reflection_angles_and_skews_out_of_range_are_written_inside_the_schema() {
let mut p = Presentation::default();
let mut slide = new_slide(&mut p, "Reflection ranges");
let mut s = shape(&mut p, "Reflected", 10.0, 10.0, 200.0, 80.0);
s.effects = Some(deckcraft_model::style::Effects {
reflection: Some(deckcraft_model::style::Reflection {
st_pos: Some(150_000),
dir: Some(-5),
fade_dir: Some(21_600_000),
kx: Some(9_000_000),
ky: Some(-9_000_000),
..Default::default()
}),
..Default::default()
});
slide.shapes.push(s);
p.slides.push(Arc::new(slide));
let r = round(&p).slides.last().and_then(|sl| by_name(sl, "Reflected").effects.clone()).and_then(|fx| fx.reflection).expect("reflection");
assert_eq!((r.st_pos, r.dir, r.fade_dir, r.kx, r.ky), (Some(100_000), Some(21_599_995), Some(0), Some(5_399_999), Some(-5_399_999)));
}