aleleba/deckcraft
1
0
Fork 0
mirror of https://github.com/storytold/deckcraft.git synced 2026-10-31 22:16:59 -06:00
Code Issues Packages Projects Releases Wiki Activity

Use scale-relative degeneracy check in linear trendline fit

Browse Source 
Found while testing crates/model/src/trendline.rs:281-313 (linreg)

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
NetterSilver
2026-10-22 19:21:18 +02:00
co-authored by Claude Haiku 5.5
parent a2435383b1
commit c0128a0eb8
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/model/src/trendline.rs
+10 -2
View File
@@ -289,7 +289,7 @@ fn linreg(xs: &[f64], ys: &[f64], intercept: Option<f64>) -> Option<(f64, f64)>
sxx += x * x;
sxy += x * (y - b);
}
if sxx.abs() < 1e-18 {
if sxx <= 0.0 {
return None;
}
let m = sxy / sxx;
@@ -304,7 +304,7 @@ fn linreg(xs: &[f64], ys: &[f64], intercept: Option<f64>) -> Option<(f64, f64)>
sxy += x * y;
}
let den = n * sxx - sx * sx;
if den.abs() < 1e-18 {
if den.abs() <= 1e-12 * n * sxx {
return None;
}
let m = (n * sxy - sx * sy) / den;
@@ -547,6 +547,14 @@ mod tests {
Trendline { kind, ..Default::default() }
}
#[test]
fn linear_fits_tiny_x_values() {
let xs = [1e-10, 2e-10, 3e-10, 4e-10, 5e-10];
let ys = [1.0, 2.0, 3.0, 4.0, 5.0];
let fit = line(TrendlineType::Linear).fit(&xs, &ys).expect("fit of tiny x values");
assert!((fit.y(3e-10).unwrap() - 3.0).abs() < 1e-6);
}
#[test]
fn linear_recovers_slope_and_a_fixed_intercept() {
let xs = [1.0, 2.0, 3.0, 4.0];