aleleba/deckcraft
1
0
Fork 0
mirror of https://github.com/storytold/deckcraft.git synced 2026-10-30 21:47:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1537

Browse Source 
Reject invalid slide index in animation.clear
This commit is contained in:
Brandon Thomas
2026-10-30 15:42:13 -04:00
parent 3465ed9d47 1bdd63dabe
commit 81ab1bce0d
1 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/engine/src/cmd/animation.rs
+17 -1
View File
@@ -339,7 +339,10 @@ fn options(s: &mut Session, p: &Value) -> Result<Value> {
}
fn clear(s: &mut Session, p: &Value) -> Result<Value> {
let i = usize_param(p, "index").unwrap_or(s.doc()?.selection.slide);
let i = match opt_usize_param(p, "index", "animation.clear")? {
Some(i) => i,
None => s.doc()?.selection.slide,
};
s.edit(|doc, _| {
if let Some(sl) = doc.slides.get_mut(i) {
Arc::make_mut(sl).animations.clear();
@@ -434,6 +437,19 @@ mod tests {
use super::*;
#[test]
fn clear_rejects_invalid_index() {
let mut s = Session::with_new();
let r = s.execute("shape.insert", &json!({"preset": "rect", "rect": [10.0, 10.0, 100.0, 100.0]})).unwrap();
let id = r.get("id").unwrap().as_u64().unwrap();
s.execute("animation.add", &json!({"effect": "fade", "class": "entrance", "ids": [id]})).unwrap();
for bad_index in [json!(-1), json!(1.5)] {
assert!(s.execute("animation.clear", &json!({"index": bad_index})).is_err());
let left = s.execute("animation.get", &json!({})).unwrap();
assert_eq!(left.as_array().unwrap().len(), 1);
}
}
#[test]
fn animation_painter_copies_effects_between_shapes() {
let mut s = Session::with_new();