aleleba/deckcraft
1
0
Fork 0
mirror of https://github.com/storytold/deckcraft.git synced 2026-10-24 10:37:03 -06:00
Code Issues Packages Projects Releases Wiki Activity

Render: a quick style on an empty placeholder is covered by a test (#832)

Browse Source 
The fix changed the empty-placeholder fill gate, but nothing locked the
behaviour in: a quick style's fill has to appear on an empty placeholder,
and a placeholder with no style at all still has to stay empty.

The new render test draws an empty body placeholder in the editor with a
quick style and checks that the accent fill is painted - every channel of
it - and that the same placeholder without a style stays white. With the
gate reverted to `s.fill.is_none()` alone the first assertion fails - the
placeholder stays white - so the test is red on the unfixed code.
This commit is contained in:
Sazid Al Bayazid
2026-10-20 09:09:28 +06:00
parent 8e83e8bb81
commit 52a9a45f6a
1 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/render/src/tests.rs
+28 -1
View File
@@ -2,7 +2,7 @@ use super::*;
use deckcraft_model::chart::{ChartType, Trendline, TrendlineType};
use deckcraft_model::style::ColorRef;
use deckcraft_model::text::TextBody;
use deckcraft_model::{Chart, Geom, Presentation, Shape, ShapeId, ShapeKind, ShapeStyle, Table, Xfrm};
use deckcraft_model::{Chart, Geom, PhType, Placeholder, Presentation, Shape, ShapeId, ShapeKind, ShapeStyle, Table, Xfrm};
fn deck_with(shapes: Vec<Shape>) -> Presentation {
let mut p = Presentation::default();
@@ -35,6 +35,33 @@ fn shape_fill_uses_theme_accent() {
assert_eq!(img.pixel(50, 50), [255, 255, 255, 255]);
}
/// #832: a quick style on an empty placeholder paints its fill. The style reference
/// (`s.style`) carries the fill, but the empty-placeholder gate skipped the fill whenever the
/// shape had no local fill, so the quick style only appeared once text was added. A
/// placeholder with no style at all still shows nothing but its dashed outline.
#[test]
fn a_quick_style_fills_an_empty_placeholder() {
let placeholder = || Shape {
id: ShapeId(910),
xfrm: Some(Xfrm::new(100.0, 100.0, 200.0, 100.0)),
ph: Some(Placeholder { kind: PhType::Body, idx: 1, ..Default::default() }),
..Default::default()
};
let p = deck_with(vec![Shape { style: Some(ShapeStyle::accent(deckcraft_color::SchemeSlot::Accent1)), ..placeholder() }]);
let img = render_slide(&p, 0, &RenderOpts { scale: 1.0, edit: true, ..Default::default() });
let accent = p.masters[0].theme.colors.get(deckcraft_color::SchemeSlot::Accent1);
// Lower right of the shape: the prompt text sits at the top of the text rect.
let px = img.pixel(280, 185);
assert!(
(px[0] as i32 - accent.r as i32).abs() <= 2 && (px[1] as i32 - accent.g as i32).abs() <= 2 && (px[2] as i32 - accent.b as i32).abs() <= 2,
"the quick style's fill is drawn on the empty placeholder: {px:?} vs {accent:?}"
);
// An unformatted empty placeholder stays empty: the gate is not simply gone.
let p = deck_with(vec![placeholder()]);
let img = render_slide(&p, 0, &RenderOpts { scale: 1.0, edit: true, ..Default::default() });
assert_eq!(img.pixel(280, 185), [255, 255, 255, 255], "an unformatted placeholder has no fill");
}
#[test]
fn render_shapes_draws_the_selection_on_a_transparent_canvas() {
let sh = Shape {