aleleba/cadcraft
1
0
Fork 0
mirror of https://github.com/storytold/cadcraft.git synced 2026-11-09 03:50:04 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): several block references show the dynamic block's name; gaps.md status line

Browse Source 
The Name row of the several-objects Properties palette used the block's own name, which for a
dynamic block is an anonymous `*U..` that differs from one reference to the next. It now resolves
each reference's name as the single-object palette does. docs/gaps.md: status line updated for the
revision entry.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
lforgiarini
2026-10-31 09:38:11 +01:00
co-authored by Claude Sonnet 5.5
parent c223550cb3
commit 6ecabc3451
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/palettes.rs
+14 -1
View File
@@ -1327,8 +1327,21 @@ pub(crate) fn properties_section(app: &mut CadApp, ui: &mut egui::Ui) {
}
EntityKind::Insert(_) => {
let insert = |k: &EntityKind| if let EntityKind::Insert(i) = k { Some(i.clone()) } else { None };
// A dynamic block reference shows its dynamic block's name, as with one reference;
// its anonymous blocks (`*U12`) differ from one reference to the next.
let names: Vec<String> = sel
.iter()
.filter_map(|h| match d.entity(*h).map(|x| &x.kind) {
Some(EntityKind::Insert(i)) => Some(custom_properties(ui, app, *h).map_or_else(|| i.block.clone(), |(n, _)| n)),
_ => None,
})
.collect();
let name = match names.first() {
Some(n0) if names.iter().all(|n| n == n0) => n0.clone(),
_ => VARIES.to_string(),
};
for (label, value) in [
("Name", shared(&|k| insert(k).map(|i| i.block))),
("Name", name),
("Position X", shared(&|k| insert(k).map(|i| len(i.insert.x)))),
("Position Y", shared(&|k| insert(k).map(|i| len(i.insert.y)))),
("Position Z", shared(&|k| insert(k).map(|i| len(i.insert.z)))),