Files
wordcraft/crates/engine/src/lib.rs
T
Saeed AzarehgarandClaude Opus 5.5 5d86dec250 Right-to-left and Persian text support (bidi, shaping, RTL paragraphs, DOCX) (#207)
* feat(doc,docx): complex-script run properties and RTL OOXML round-trip

Model the formatting Word applies to Persian, Arabic and Hebrew text:
cs, font_cs, size_cs, bold_cs, italic_cs and lang_bidi on CharProps,
resolved with Word's fallbacks (ResolvedChar::complex). Size, bold and
italic pair with their complex-script values so a run's size or bold
also covers its Persian characters. Add doc::bidi script helpers, and
keep ZWNJ and Arabic marks inside words for word selection.

DOCX: read and write w:rFonts/@w:cs, w:szCs, w:bCs, w:iCs, w:cs and
w:lang/@w:bidi in schema order; stop using the cs font as the Latin font.
Tests round-trip Persian text with ZWNJ, digits and mixed Latin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(fonts): directional shaping and Persian font fallback

Add shape_run to shape a run in a known bidi direction (Arabic joining,
mirrored brackets). Prefer Persian-capable fonts (Vazirmatn, Noto Naskh/
Sans Arabic…) for right-to-left fallback, pick bold/italic fallback faces,
and map common Persian document fonts (B Nazanin, B Lotus, B Titr,
IRANSans…) to open substitutes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(layout): Unicode Bidirectional Algorithm and right-to-left paragraphs

Run UAX #9 per paragraph (unicode-bidi), shape each level run in its
direction, keep marks and ZWNJ with their letter and a word in one
fallback face. After line breaking, apply rules L1/L2 per line and give
each cluster a visual box; right-to-left paragraphs are laid out from
their start edge and mirrored, so indents, tabs, alignment, list labels,
drop caps, floats and borders sit on the right.

Caret, hit testing and selection use visual geometry (split selections,
caret at bidi boundaries, DocLayout::visual_step for arrow keys). Display
items carry glyph-to-text ranges, which the PDF writer now uses. Plain
left-to-right lines are unchanged. No hyphenation of RTL words.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(engine,ui): paragraph direction commands and RTL editing

Add para.ltr / para.rtl (Word's text direction buttons) that change only
the reading order, and make the alignment buttons visual in right-to-left
paragraphs (para.align also takes start/end). Arrow keys move visually in
bidirectional text, Ctrl+arrows follow reading order, and Bold/Italic/
Size/Font cover complex-script text. Ribbon buttons with code-drawn
icons, a mirrored ruler for RTL paragraphs, translations, catalog,
parity and roadmap updates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore(contributors): add Saeed Azarehgar to people.toml

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(engine): para.align with an explicit value sets it, without toggling

Only the alignment buttons toggle back to the start edge when pressed
again. para.align (used by the Paragraph dialog, scripts and agents) now
sets the requested alignment, as seen on the page, in each selected
paragraph's own direction. Previously pressing OK in the dialog with
Center or Right selected reset the paragraph to the start edge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(ui): Direction option in the Paragraph dialog

Add Word's Direction (Right-to-left / Left-to-right) to the Paragraph
dialog's General section. The dialog now shows alignment and Left/Right
indents as seen on the page, mapping them to the paragraph's logical
start/end values on OK, so an unchanged OK no longer flips a
right-to-left paragraph. OK logic moved to apply_paragraph, with tests;
ja/zh translations.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(layout): allow hanging trailing spaces in the RTL display test

A wrapped right-to-left line's trailing spaces hang past its end edge
(the left margin), as left-to-right lines hang them past the right. The
test failed whenever the loaded fallback fonts made a line end there;
it now checks only visible glyphs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-10 09:26:41 -04:00

162 lines
5.1 KiB
Rust
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
//! WordCraft engine: the editing session and its commands.
//!
//! **Everything is a command.** Each user-visible action is a [`CommandSpec`] with a stable id
//! (`format.bold`, `insert.table`), a label, the ribbon/menu location, a default shortcut, a
//! params description and a `run` function. Menus, ribbon, shortcuts, the command palette, the
//! CLI, the JSON control channel and the MCP server all call [`Session::run`].
#![deny(clippy::unwrap_used, clippy::expect_used, clippy::panic, clippy::unimplemented, clippy::todo, clippy::unreachable)]
pub mod catalog;
pub mod cmd;
pub mod io;
mod io_ext;
pub mod math_gallery;
pub mod sample;
mod session;
pub mod speech;
use std::collections::HashMap;
use serde_json::Value;
pub use session::{EditSnapshot, FindState, MathEdit, Prefs, Selection, Session, ViewState};
pub use wordcraft_doc as doc;
pub use wordcraft_layout as layout;
pub use wordcraft_render as render;
#[derive(Debug, thiserror::Error, Clone, PartialEq)]
pub enum CmdError {
#[error("unknown command `{0}`")]
Unknown(String),
#[error("bad parameters: {0}")]
Params(String),
#[error("not available: {0}")]
Disabled(String),
#[error("{0}")]
Failed(String),
}
impl From<wordcraft_doc::DocError> for CmdError {
fn from(e: wordcraft_doc::DocError) -> Self {
CmdError::Failed(e.to_string())
}
}
pub type CmdResult = Result<Value, CmdError>;
/// A registered command.
#[derive(Clone)]
pub struct CommandSpec {
pub id: &'static str,
pub label: &'static str,
/// Where it lives in the UI: `Home › Font`, `Insert › Tables`, `File`…
pub location: &'static str,
/// Default shortcut in a portable form (`Mod+B`, `Mod+Shift+>`, `F7`). `Mod` = Ctrl, or ⌘ on macOS.
pub shortcut: &'static str,
/// Parameter description for agents (`{"size": number}`).
pub params: &'static str,
pub mutates: bool,
/// `None` = enabled; `Some(reason)` = disabled.
pub enabled: fn(&Session) -> Option<&'static str>,
pub run: fn(&mut Session, &Value) -> CmdResult,
}
fn always(_: &Session) -> Option<&'static str> {
None
}
impl CommandSpec {
pub const fn new(id: &'static str, label: &'static str, location: &'static str, run: fn(&mut Session, &Value) -> CmdResult) -> Self {
CommandSpec { id, label, location, shortcut: "", params: "{}", mutates: true, enabled: always, run }
}
pub const fn key(mut self, s: &'static str) -> Self {
self.shortcut = s;
self
}
pub const fn params(mut self, p: &'static str) -> Self {
self.params = p;
self
}
/// Doesn't change the document (navigation, view, export).
pub const fn pure(mut self) -> Self {
self.mutates = false;
self
}
pub const fn when(mut self, f: fn(&Session) -> Option<&'static str>) -> Self {
self.enabled = f;
self
}
}
/// All commands by id.
pub struct Registry {
specs: Vec<CommandSpec>,
by_id: HashMap<&'static str, usize>,
}
impl Registry {
pub fn new(specs: Vec<CommandSpec>) -> Self {
let mut by_id = HashMap::new();
for (i, s) in specs.iter().enumerate() {
by_id.insert(s.id, i);
}
Registry { specs, by_id }
}
pub fn get(&self, id: &str) -> Option<&CommandSpec> {
self.by_id.get(id).and_then(|i| self.specs.get(*i))
}
pub fn all(&self) -> &[CommandSpec] {
&self.specs
}
/// Command list as JSON (for agents: `commands` / `list_commands`).
pub fn describe(&self) -> Value {
Value::Array(
self.specs
.iter()
.map(|s| serde_json::json!({"id": s.id, "label": s.label, "location": s.location, "shortcut": s.shortcut, "params": s.params, "mutates": s.mutates}))
.collect(),
)
}
/// The command bound to a shortcut, if any.
pub fn by_shortcut(&self, key: &str) -> Option<&CommandSpec> {
self.specs.iter().find(|s| !s.shortcut.is_empty() && s.shortcut.split(" / ").any(|k| k.eq_ignore_ascii_case(key)))
}
}
/// Parameter helpers.
pub mod p {
use serde_json::Value;
use crate::CmdError;
pub fn str<'a>(v: &'a Value, k: &str) -> Option<&'a str> {
v.get(k).and_then(Value::as_str)
}
pub fn req_str<'a>(v: &'a Value, k: &str) -> Result<&'a str, CmdError> {
str(v, k).ok_or_else(|| CmdError::Params(format!("`{k}` (string) is required")))
}
pub fn f32(v: &Value, k: &str) -> Option<f32> {
v.get(k).and_then(Value::as_f64).map(|x| x as f32).filter(|x| x.is_finite())
}
pub fn req_f32(v: &Value, k: &str) -> Result<f32, CmdError> {
f32(v, k).ok_or_else(|| CmdError::Params(format!("`{k}` (number) is required")))
}
pub fn u64(v: &Value, k: &str) -> Option<u64> {
v.get(k).and_then(|x| x.as_u64().or_else(|| x.as_f64().filter(|f| *f >= 0.0 && f.is_finite()).map(|f| f as u64)))
}
pub fn bool(v: &Value, k: &str) -> Option<bool> {
v.get(k).and_then(Value::as_bool)
}
/// The `value` param, or the first positional-ish string.
pub fn value(v: &Value) -> Option<&Value> {
v.get("value")
}
}
#[cfg(test)]
mod tests;
#[cfg(test)]
mod tests_bidi;
#[cfg(test)]
mod tests_typing;