Commit Graph
98 Commits
Author SHA1 Message Date
70ecef86df #7124: mcp refuses to start without both automation roots, and refuses --connect (#7157)
* #7124: mcp refuses to start without both automation roots, and refuses --connect

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* #7124: control protocol says --connect is refused; test folder comment matches

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* #7124: refuse --connect without a value; test folders removed by Drop guards

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* #7124: scratch folders retry only a name that exists

Scratch::new and Folders::new retried every create_dir failure, so a
missing or read-only temp folder looped forever instead of failing the
test (CodeRabbit). Retry only AlreadyExists; any other error panics with
the path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* #7124: mcp's headless session is built by a function the unit tests reach

SonarCloud's new-code coverage was 57%: the session set-up after the
root checks ran only in the subprocess integration tests, which coverage
does not see. headless_mcp builds the confined session and applies
--author; mcp_headless_session_takes_the_author_flag covers it without
confining the test process.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
2026-11-21 10:08:42 +00:00
Martin BallandClaude Opus 5.5 b5e0be7879 Port the UI onto the craft framework (#7101)
* canvas-w21: net change of 3 commits

- canvas-w21: written from its sheet
- canvas-w21: repair 1
- canvas-w21: review fixes (review-1)

* chrome-w8: net change of 2 commits

- chrome-w8: repair 1
- chrome-w8: review fixes (review-1)

* mini_toolbar tests: import egui pos2 and Vec2 the tests use directly (production imports only Rect, Ui)

* App compile: open context_menu, font_box and ribbon::common to their callers; Label and Value import from their framework homes; balloons read command_enabled; wordart test runs fired commands through WordApp::run_fired; delete rtl.rs, which has no reader

* Fix imports (palette, picker, icons, color), expose find helpers, drop old keytip phase state per S-L365

* keytip_places: removed with the old keytip phase machine (S-L365); WordApp, WindowUi and the destructurings no longer carry it

* ribbon submodule imports: Value, Target, Remember, egui geometry, Label, TypeRole, DisclosureGlyph and kittest Node come from their own modules, not the ribbon.rs re-exports ribbon-w8 dropped

* context menu: CanvasState keeps the open point so the menu anchors where it was asked

* Palette derives Default: dialog forms hold an empty palette until prepare fills it

* ribbon: Stack/Row/Menu show need ShowContainer in scope

* canvas Read Mode: reading metrics come from a probe component measured under the theme (S-L355)

* Dialog and mini toolbar call sites follow the framework: Mode into style previews, owned colour key, non-exhaustive DialogResult, struct EditEvent variants, IconButton::command, Props::command on bound toggles

* canvas: the mini toolbar shows inside the page view body, where it maps its anchor through the canvas view

* ribbon: runtime labels as owned Strings, Props in scope for MenuItem::label, RibbonGroup icon 'static

* Tests read the canvas zoom through CanvasState::zoom and pass the context to qat_enabled

* More Colors settle hook returns Settle (S-L280) so it registers as a DialogHooks settle

* ribbon: wordart/shapes galleries take the menu body cx; TextRun built with its builders; symbol tile paints centred by the run's alignment; paint_style gets the content painter cx

* math pictures: MathSource takes an aspect and sizes its layout box from the thumbnail request, with thumb_aspect for the tile or button (S-L393)

* CatalogRef: Debug says whether a catalog is held, since the framework's Catalog has no Debug

* mini toolbar tests: read accessibility labels and popups through kittest's NodeT::accesskit_node

* tests.rs: readers move to the framework and canvas accessors that exist (ScriptedFiles held/queue/answer_to, Host::builder, page_rects()/canvas_rect(), drain_inbox, DefaultAppError, pixel-sized auto_scale_limit_over, ClipItem::Image, DropTarget::Elsewhere, dialogs::close_all)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Reading probe returns an Outcome output; context menu rows label via MenuItem::new; colour preview matches cover non_exhaustive Preview; mini toolbar toggle icon is static

* fu2-app: app batch 2 rulings on batch 1 sets (S-L412, S-L365, S-L410, S-L411, S-L414, S-L419, S-L372, S-L368, S-L364)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Ribbon menu rows take owned labels: framework Label is String or 'static str, not a borrowed &str

* QAT command menu request drops the removed opener field

* Colour child answer: DialogResult is non_exhaustive, so any other result is ignored

* Thickness menu face: Button has no icon_only, so it shows icon and label

* Tests: By filter helper with an explicit lifetime; accessibility label compared as Option<String>

* lead: last compile fixes (menu label lifetime; perf test reads the page view's resident pictures, S-L352)

* lead: binary compile fixes (egui DroppedFile trait, Lang accessor, print test binding)

* lead: dropped file bytes as Arc

* lead: examples reach the framework through craft:: (S-L230)

* lead: examples reach the framework through craft::ui::shell::embed (S-L230)

* lead: ui_shot example runs its main under the test build cl uses (harness = false)

* rr-app-ribbon: the ribbon slots are sized by their content (SlotSize::Content)

The default top slot is one options bar high with a one-line layout: the ribbon's groups landed beside the tabs and all
collapsed. Needs the framework's SlotSize::Content (branch red/ribbon-place).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* app tests: one harness that installs the craft runtime before the first frame

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* lead: WordApp::new registers the app icon set (ribbon-w13 icons::register had no caller)

* red app-t2 g4: tests step with the app's command input; print preview is a group; neutral SmartArt error

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t2 g6: tests step with the app's frame input; integrated frame for the title-bar test; undo list caps rows; table press hold released; test clipboard answers files

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t2 g3: dialog collections cap their rows, tests give dialogs their context and focus, glyph scan skips test data

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t2 g5: tests step frames through frame_input; split-button arrows named; collections capped; stale premises rewritten

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t2 g8: closing guard outlives window swaps, root focus/close, web save undo, collections natural height, test premises

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t2 g2 (lead commit)

* red app-t2 g1 (lead commit)

* red app-t2 g7 (lead commit)

* lead: backstage test row query borrows the name as long as the harness

* red app-t4 g2: key tests step through the app's frame hook; draw paths read format state without running a command

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t4 g8: custom dictionary caps its rows; chrome/language-pack tests press as a person does; sources test steps through the frame hook; audit and pane tests follow the framework's layout

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t4 g3: dialog test premises and Custom Properties labels, colors route, macro names, bookmark delete

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t4 g6: md_source focus waits for a non-measuring pass; window rig reports inner rects; smoke sends a close request; switch windows label; i18n tests

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t4 g5: table borders above selection areas, ruler markers follow drags, proofing list click-activates, test premises (focus, Enter=OK, extra buttons stay open)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t4 g7: failed web save keeps clean state, symbol dialog fields, table margin hold release, object release keeps Alt placement, test premises (toggle off, Escape chord, CJK glyphs, palette swatches, frame gesture)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t4 g4: frame hook in keytips tests, held list previews, crop keys and handles, read-mode context menu, keyboard overrides notes

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t4 g1: frames run the app's input hook and close path; page focus survives measuring runs; stale prompt dropped; recipients/styles collections capped

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* look-backstage: File pages as production: menu rows at the reading start, Discord above About, page titles over sections, Info property labels, Print preview fills the page

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* look-dialogs-b: TOC levels label, Options/Modify row and sample card metrics; watermark layouts in a row; About listed layout and version line

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* look-ribbon-1b: Styles gallery tiles are 2:1 and named under the sample; Paragraph shows whole at 1440 pt

The style gallery asks the framework gallery for 2:1 pictures (the sample crop, STYLE_TILE_W, at the
medium thumbnail height) with the style's name under each, instead of square tiles that shrank the
sample. A test pins the Home tab showing the Paragraph group whole in a 1440 pt window (framework:
red/ribbon-look's ribbon place, short font and size boxes, flat close ribbon buttons).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* look-backstage: the File side menu is as tall as the window (Sizing::FillHeight), About and the community link at its foot

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* look-chrome: title in a native frame; status bar view icons, fonts warning icon, plain zoom rail

The title bar shows the document title under the OS's title bar too
(TitleBar::title_when_native), as the old bar always did. The status bar's
view buttons are icon-only toggles in the old order (Read Mode, Print Layout,
Web Layout) with the current view pressed; the missing-fonts item has its
warning icon; the zoom slider has no fill up to the thumb. Tests
the_title_shows_in_a_native_frame and
status_bar_view_buttons_are_icons_with_the_view_pressed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* look-backstage: File page controls at stacked-row spacing, as production's

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* look-backstage: one contract import in pages.rs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* look-dialogs-a: Zoom opens on the view's percent (fraction x100), radios in a row, slider with its field inline, fit buttons in the body; Word Count as a plain label/count table over Close and Cancel; Font dialog as the old framed boxes: label table, kerning size and Points and above on the check box's line, Effects two to a line, preview at its own size; tests

* backstage test: import NodeT for accesskit_node

* red app-t5 g6: window rig reports the real child, ruler drags free of the framework snap

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t5 g4: smoke drops texture deltas, md_source tests step the hook frame, font list rows are tree items, Escape closes bar then menu, symbol pick confirms twice

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t5 g5: rotate objects about their centre, CJK stand-in in ribbon fit test, caret blink restart, Switch Windows node pair

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t5 g7: nav lists take natural height; menu/keytip tests step the frames the runtime needs

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t5 g8: Size dialog tests step through the app frame hook, Styles pane test scrolls its capped list, pack tests end the agent's injection

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t5 g3: dialog tests read the page's preview, the input hook, framework About key; Alert on refused custom property; Text Pane focus via framework stop

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t5 g1: harness hands app input before the pass; confirm via passes; pane/close/clipboard test premises

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t5 g2: keys tests follow the framework's IME ordering, interrupt and reset; undo folds an open SmartArt run; join survives a later pass

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* look-rest-2: File side menu rows in the side menu place at the side menu's width (production's 200 pt rail of 38 pt rows); Print settings column wraps its notes at the column width

* look-rest-2: side menu imports formatted; test pins the rail's width and row height

* panes test: MouseWheel carries its source

* red app-t6 g8: ribbon end order, cjk stand-in any family, capped findings list

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t6 g6: smoke finds the platform's answer button, info/side-menu tests use the framework's mechanisms, pack-bar click settles

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t6 g3: menus open from their opener, view buttons given, caret test animation time, switch windows rows

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t6 g2: icons dialog owns its scroll, effects grid fills, search opens in place, macros press runs once

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t6 g5: symbol pick OK, md pane Undo/Redo enabled by the field, live rotation pixel preview, text-box turn tolerance

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t6 g7: mini_toolbar and table_resize tests settle on the framework's layer and marker timing

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t6 g4: Alt+Q row follows the engine's build-time binding

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t6 g1: CJK stand-in in the shared harness, late-paste test clipboard, web-layout gutter, search dropped in Focus, split-button and held-Return tests

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* look-rest-3: Print settings column as production's: one Pages heading over both page lists, the page count muted, a rule above the export formats; Word Count rows a control's height apart

* look-ribbon-3: Design's style-set tiles and Home's style samples at the large thumbnail size (Gallery::thumb), as large as the old ribbon's; the samples show unscaled

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Ribbon: the Zotero tab is called Citations; Zotero is its provider

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Citations: a Provider menu with Zotero as its one provider

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* citations tests: hold the layout the tabs borrow; import NodeT

* red app-t7 g6: settle the Install button before the person's click; wait for the caret glide; coverage check skips symbols kept from the English source

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t7 g5: smart-art category list natural height, print panel FillHeight, ribbon fit test checks on-screen controls

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t7 g2: Alt+Q test back on the Focus dialog, Tab hand-off owned by the framework, macros name read from the box, effects as pair rows, caret test waits for focus

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t7 g4: Size dialog fields take edit events, font list opens from the field, test keys release

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t7 g3: keymap test assigns through the keymap's Steal policy; smoke finds the prompt button by its resolved name

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* red app-t7 g1: Escape reaches select.collapse and the window's untaken Cancel (File page, Focus, Full Screen); web width settles after a drag; prompt helper asks the shown window; chord tests step the framework's frames

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* look-ribbon-4: the tab row's Comments and Editing are outlined and Share a filled accent button, as the old strip drew them (StripEnd::variant)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* look-rest-4: Font dialog's Effects columns as wide as their check boxes (production's table, Italic just past Superscript); File page section headings in the heading role (production's 15 pt) and page titles, Options' too, a step above them

* look-5: Home's Font and Paragraph button rows close up as the old ribbon's; Layout's Paragraph group as two label/field grids of small fields, indents to two decimals, a section gap before Spacing

* red stub g2: caret glide compares the view, which the page view reports on every pass

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: crop overlay takes the box as given so a drag survives to its commit

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: Alt+Q to Search Commands off macOS, ui.print state, scripts open no dialogs, equation state read without a command, size and New Label tests on the framework fields

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: collections in scrolling bodies cap their rows or take their natural height, as production shows them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: Escape on the page dismisses an open text menu first

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: format.enclose gives a script an error without a shape, as the engine always has

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: the caret marks are shown over the view, so their strokes are not clipped to an empty rect

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: header/footer presses keep their release; the caret follow settles after a page jump; a wheel zoom keeps its exact zoom

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: tests find the framework's controls by their real roles and names; the ribbon group check covers the ribbon's groups

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: the canvas keeps the whole layout's page rects; the side-by-side test reads every page as production did

* red stub g2: the perf wheel helper sends point travel over the touchpad factor the framework now applies, as production's host did

* red stub g2: the alignment test steps once more for the fired command to run, as the port's command board does

* red stub g2: the Zoom dialog's programmatic OK answers with the percent it shows

* red stub g1: tests install no gallery story command sets (they took Mod+F from Find); the Navigation pane keeps its focus request until a pass takes it; Field Code opens before the first frame; report rows of the input-dialog test expect the report's data

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: a WordArt style pick hands the keyboard to the page

* red stub g1: the language pack bar's slot takes the bar's height, so a failure's line no longer clips Install out of reach

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: a tab click and a dismissed status-bar language menu give the page the keyboard back after the pass; the test reads the framework's open menus

* red stub g2: the caret follow waits for the page's settled rect and places an unplaced page's caret from the whole layout

* red stub g2: the canvas reports the area the pages show in; the wheel-zoom test points at its centre, as production's canvas rect was

* look-6: a script's launcher command (format.fontDialog, Zoom, Page Setup) opens its dialog as production did; commands lacking input still open none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* look-6: the File page body stands on the window background (production's #f9f9f9), not the white panel

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: the app's Host carries the embedded catalogs, so framework words translate; catalog labels and command hints are translated; the canvas's zoom chords are dropped for Word's

* red stub g2: the caret glide test catches the caret the frame after it sets off, as on main (the set-off frame draws it where it was)

* red stub g2: Manage Styles and Customize Ribbon lists scroll their own rows (row caps as main's boxes); the Arabic Go To check compares the targets with the framework dialog's button column

* red stub g1: Alt chords fire from the page (PlainKeysWait; Alt+F7/Alt+F8 left to Word's commands), Macros reopened keeps its hooks, the recipient grid holds its rows through the click that ends an edit, ui.clickText maps page points by the page's scale; chrome tests read the title bar outside the File page and open the desktop chooser as its pump does

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: watermark, citation style, TOC level, Zotero, caption, cross-reference and icon category labels are translated; the audit reads a wrapped marked label's second line as marked, and allows a hover hint's shortcut and separators, listed or cut-short names and trimmed licence texts

* red stub g1: the Print page decides what an opening holds back in the opening frame's first pass, as appeared() now holds through all of that frame's passes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: tests give a key and its text (or one IME batch) one frame, as kittest's event runs a frame per event; Paste Formatting's key reads its chord when the modifiers are already up; ⌘Q is the runtime's close (S-L332); Search's Escape meets the draft rule first

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: wrap the command board's import at the repository width

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: the PDF bytes test expects the equation's x the math face can draw (plain x on a host with no math font, as in the pre-port baseline)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: the smoke test turns AccessKit on for its own context, so the Save Changes prompt's buttons are in the tree it searches

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* look-7b: Custom Watermark's text field asks for 38 characters (Param::field_chars), about the old dialog's 280 pt; the field length gave about 195 pt

* look-7a: File pages: titles at production's 26 pt (WordCraft's display size), the page's 40 pt margin clearing the move band, the rail's footer in the side menu place (white ink), Protect Document a section apart on Info, the Print settings a frameless 380 pt column with chevrons for the sheets; tests

* red stub g2: Shift+Delete cuts the selection and does nothing without one (EditorInput::Delete.shift); the page reports its marked text (EditorState::marked); one-frame input back in the refused-delete and disabled Alt chord tests; a Delete after a commit waits out the framework's composition-key guard; a user binding reaches the keymap a harness frame later; window.move/size keep their defaults

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: Ctrl+wheel zoom test keeps the place under the pointer at each notch: a reflow centres the rows, so the page under the pointer is taken when the notch comes, and a pointer over the centre gutter moves onto a page first

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* merge app-ui: resolve production main into the port's UI

- ribbon/home.rs (4e8c9d55, #3172): the Paste face is named "Paste"; its tooltip adds
  edit.paste's chord as the platform writes it (commands::resolve + tooltip::with_chord).
  tests.rs: the_paste_button_is_named_without_a_mac_key rewritten on the port harness.
- dialogs/paragraph.rs (32b4ab57): the framework ParagraphDialog's Special box does the work;
  intersect leaves By blank when the paragraphs' kinds differ, so a kind picked then starts at
  the half inch. dialogs/tests.rs: the three Special-box tests rewritten on the dialog host.
- dialogs/dialogs_review.rs (bce64c0e): the port's Compare form already names its fields.
- canvas.rs, canvas/tests.rs (07c0a893): keep the port's composition painter and state;
  production's egui composition painter, its fields and its tests are dropped (framework items).

* merge app-shell: resolve production main into the port

- engine lib.rs: export set_bookmark_error/set_reference_error beside system_locale
  (the port dropped the KeyMap re-export; it stays dropped).
- app.rs: logic() sets the PAGEREF/REF error texts in the interface language.
- file_dialogs.rs: Save As starts in the open file's folder, made absolute
  (#4143), through PickRequest::directory; tests carried to ScriptedFiles.
- window_geometry.rs: 600 pt minimum width (#5886) and its test.
- chrome/status_bar.rs: Page item bound to edit.goto so its tooltip shows the
  platform's Go To key (#3172); language tooltip names the language in full.
- chrome/tests.rs: narrow-window title bar and status bar tests rewritten
  against the app harness.
- a11y.rs: test expects zero-based AccessKit levels (#3173); the mapping
  fix is the framework's.
- chrome.rs, theme.rs, app/fonts.rs, windows.rs, windows/tests.rs,
  keytips/tests.rs: production's replaced egui code and cut tests dropped.

* land sync: canvas.rs declares its tests module again (dropped in canvas-w9, so canvas/tests.rs, markup.rs and overlays.rs never compiled)

* land sync: the app takes craft gpu-startup (the sync moved craft::gpu::configure behind it)

* red stub g1: canvas tests compile against the ported canvas (imports, kurbo/Env/commands paths, equation_frame sizes, page_grid)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: canvas tests step through the app's input hook; caret reports the editor from an off-screen page

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: candidate window at the composition cursor; page keeps its keyboard across a document switch; IME, tip and Hide White Space tests on the ported mechanisms

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: a pass whose input edits the document runs again so its frame paints the edit; read-only balloons open no edit; balloon tests type in the card's field

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: a right click selects what it clicked before its menu opens; the page under a point is the nearest shown band; the status bar's page in view measures from the view's top edge

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: Hide White Space gets the page bodies; a refused balloon draft stays when the balloon is left; context menu, crop and ruler tests on the ported mechanisms

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: comment drafts stay with their document across a window switch; Hide White Space test probes the overlap inside the text areas

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g2: rotated effect-extent fixtures use Word's exchanged-frame measure (craft-libs #2227)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* red stub g1: the title bar's search and Discord and the status bar's zoom slider and Focus give way in a narrow window (#5886 fit, measured per step); the IME composition draws in the text's face, size and baseline through Draw::face_run; narrow-window tests read the bar row and the painted texts; production's three composition tests

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* land sync: a refused input-method edit asks the framework for the interrupt (ToolPass::ime_interrupt), so the commit keeps its InputMethod cause

* port build loop: craft-i18n and craft-fonts come from the environment (CRAFT_I18N_DIR, CRAFT_FONTS_DIR), not machine paths in the manifest

* Resolve the craft framework from https://github.com/storytold/craft-libs next at 362eb2820996b475e6f21967c561219dbde24343

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at 362eb2820996b475e6f21967c561219dbde24343

* port: cargo fmt

* fonts: drop the face_names re-export the ported UI fallback no longer uses

* Restore the [patch.crates-io] block: the egui and winit forks and the vendored crates the framework builds with

* Workspace clippy: dead code and unused imports the port left, test-only helpers under cfg(test), the examples report a failed install

* Tests: headings read in tree order, not egui id-map order; the picker Install is aimed after downloading goes off, which adds a licence line to each row and moves it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Ribbon: own icons under wordcraft.* names so the catalog no longer shadows them; 32/17-pt ribbon icons and corner launcher

* Ribbon: filled menu arrows right after the label, as the old ribbon

* Ribbon: 22-point small-row pitch (20-point rows a tight gap apart), RibbonLook

* Ribbon: Draw colour/thickness and Layout align/group/rotate show icons alone; Window collapses to the more icon, as the old ribbon

* Styles gallery: sample letters on the ribbon with no white paper box, as the old ribbon

* Title bar: tool-size QAT icons, the filled undo-list arrow and the small AutoSave switch, as the old title bar

* Ribbon: tabs in the text colour over a 3-point underline

* Ribbon: body on the old lighter band with its rules

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FypgCZhHKRuRB5wZUiw6BE

* Ribbon: framed Styles gallery; Style Sets drop their buttons while all show

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FypgCZhHKRuRB5wZUiw6BE

* wasm: gate native-only craft features (dialogs, update, automation client, default app) off wasm32

craft-dialogs (rfd folder picker, file paths) and craft-update (ureq/ring, getrandom 0.2) are
documented native-only, as are craft::automation's client/security/args/dialogs and
craft::platform::default_app. ui-egui takes `dialogs` and `update` through a
non-wasm32 `craft` dependency; wordcraft-mcp's `Remote` bridge moves to backend/remote.rs,
native only. The code that used them is gated the way production main gated its
native-only paths, with a plain fallback on the web. Also drops dead-code/unused-import
warnings on wasm32 and keeps chrono's parser available there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* MCP: pin the shared server refusing a request without the JSON-RPC version (craft-libs #2444)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Resolve the craft framework from https://github.com/storytold/craft-libs next at a5f6cd7f6ccd560438e3bbeb1209aa117ba957dc

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at a5f6cd7f6ccd560438e3bbeb1209aa117ba957dc

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* port: the default-chords rows stay mutable only where the off-macOS rows extend them (macOS clippy)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* port: the web build embeds its Japanese interface face when the craft-fonts checkout has one, CRAFT_FONTS_REQUIRED binds the native build

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* port: wordcraft-web builds against the ported UI: the host takes the framework language, the legacy prefs parser is imported, no native-window hook on the page

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ui-egui: use the framework constructors for non_exhaustive types

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* port test: the files clipboard keeps any absolute path from a uri-list, so the copied-files trials run on Windows

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Resolve the craft framework from https://github.com/storytold/craft-libs next at 1e48c0807e18c5f5ae25b6227fde52281942f288

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at 1e48c0807e18c5f5ae25b6227fde52281942f288

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* port test: on macOS the smoke close goes to the platform quit, so Don't Save shows as no second prompt

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Resolve the craft framework from https://github.com/storytold/craft-libs next at 1e48c0807e18c5f5ae25b6227fde52281942f288

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at 1e48c0807e18c5f5ae25b6227fde52281942f288

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Resolve the craft framework from https://github.com/storytold/craft-libs next at 27c1c0ebb1d16adf97d09952bb781e69f9962e46

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at 27c1c0ebb1d16adf97d09952bb781e69f9962e46

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Resolve the craft framework from https://github.com/storytold/craft-libs next at 243d68e12d05e89122db6d154924bf1992e10d38

Every framework path dependency and patch is now a git dependency at that revision.
Cargo.lock is regenerated against it separately.

* Cargo.lock: resolve against craft-libs next at 243d68e12d05e89122db6d154924bf1992e10d38

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-20 14:02:07 +00:00
batistalucasv 15d315e3f8 Wayland: 600 pt minimum width for GNOME split window tiling (#5886) 2026-11-17 21:49:07 -03:00
Mex 211f62231d M14: correct control protocol parameter examples (#6684) 2026-11-17 03:03:15 +01:00
8a1f101c46 Save As and Export: Browse in WordCraft when the system dialog doesn't appear (#3535) (#3801) (#5790)
* Save As and Export: Browse in WordCraft when the system dialog doesn't appear (#3535) (#3801)

Ported from #3801 by VoiceLessQ onto current main.

Re-resolved against main:
- file_browser.rs tests: rebuilt whole, keeping main's #3859 tests (browser
  above the dialog, Escape, dialog closing into the browser, modeless
  keyboard, no keytips) and the PR's #3535 export tests.
- print_page.rs: EXPORT_FORMATS now carries main's OpenDocument Text
  Template (*.ott) and Flat OpenDocument Text (*.fodt) in main's order;
  main's tests module kept.
- docs/control-protocol.md: ui.fileBrowser purpose "export" added to main's
  current row (keeps ui.displayServer).
- docs/ui-parity.md: File dialogs row merged with main's Linux display
  server row, #3955 history row kept, status line and revision history
  bumped.

Added a test that the ott and fodt export types get their extension and
write the file.

Co-Authored-By: VoiceLessQ <44067308+VoiceLessQ@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FypgCVCCEo7u5wetHaJRU4

* #3535: Word XML export from the system dialog adds .xml to a typed name

CodeRabbit: the system Save dialog accepts any name, and the engine takes the
explicit Flat OPC format only for an .xml path, so `letter` failed to export. The
extension is added as the built-in browser does; an existing file at the new name
is refused, since the dialog never confirmed replacing it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* #3535: an existing file at the .xml name is refused on the status bar

CodeRabbit: export_dialog drops ask_file's result, so the refusal was silent with a
blocking Save dialog. finish_pick now puts it on the status bar as well.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* #3535: Export refusals show on the Export page; a typed document extension gives way to the chosen type's

A refused or failed export is said on the Export page (Backstage hides the status bar), as Save As does. A known document extension on the typed name is replaced by the chosen Export type's, and any other is kept with the extension added.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* #3535: Print page shows export errors; cancel clears them; export_name edge cases

The export error is drawn inside export_formats, so the Print page shows it as well as the Export page. Cancelling an export drops an earlier error. export_name treats a name that is only a known extension (.txt) as that extension and drops a trailing dot before adding the type's.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FypgCXtSjB6e5jmy9Uq7u8

* #3535: Export error is per window; a dotfile export name gets a real extension

The export error moves from a shared Context-data id into per-window state (swapped with the window like missing_fonts), so one window's frame outside Backstage no longer erases another's message. export_name treats a dotfile name such as .docx as a stem, so the engine's explicit-format guard (Path::extension) accepts the result; Word 2003 XML exports are named the same way.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FypgCXtSjB6e5jmy9Uq7u8

---------

Co-authored-by: Martin Ball <martin.ball@ucsmedical.co.uk>
Co-authored-by: VoiceLessQ <44067308+VoiceLessQ@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-16 10:06:53 +00:00
Valentin Klein bc0e51ee4d Interface size: Auto is capped to what fits the screen, Ctrl+Shift+0 returns to Auto (#4030) (#5203)
Fixes #4030

On a small screen (an 11-inch 1366x768 panel) the system can report a very large display scale. The Auto interface size followed it blindly, so the window and ribbon came out far bigger than the screen and File > Options, where the size is set, could not be reached.

What this changes:
- Auto interface size is now capped so a window of at least 900x460 points still fits the screen (about 152% on 1366x768). Scales that already fit (for example 1920x1080 at 100-150%, or 1366x768 at up to 150%) are unchanged. If the screen size is unknown there is no cap.
- A size chosen in File > Options is still taken as is. If a large size pushes the options out of reach, Ctrl+Shift+0 (Cmd+Shift+0 on Mac) returns to Auto from anywhere. Ctrl+Alt+0 is not used because it is AltGr+0 on some layouts and would type a character.
- `ui.interfaceSize` and the "Auto (n%)" label in Options report the capped value. The cap is never saved to `ui.json`.
- Tests: the cap for several screen sizes, the shortcut, AltGr+0 still typing, and the reported percent. Docs: ui-parity, control-protocol, ROADMAP progress log.

Not covered:
- The root cause of the oversized scale (X11 DPI detection) is handled by #721 and #3240. This change is separate and works with or without them.
- A manually chosen large size can still push controls off screen, but there is now a way back.
- Not tested on a real 1366x768 screen.

`cargo xtask ci` passed locally on the pushed code; GitHub CI has not run yet.

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **New Features**
  * Auto interface sizing now scales down on smaller displays to keep a window of at least 900×460 points within the screen. Sizes selected in Options remain uncapped, and the minimum Auto scale is 100%.
  * Press Ctrl+Shift+0 (⌘⇧0 on Mac) to restore Auto sizing. When Auto sizing is capped, the displayed zoom percentage reflects the screen-fit limit; the cap does not change the saved size.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-11-15 12:12:27 +01:00
batistalucasvandQwen-Coder b8f232ca2e docs: bump touched doc status lines for scroll speed settings (#6146)
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-11-12 18:33:24 -03:00
batistalucasv 51901610fc ui: touchpad and mouse-wheel scroll speed settings (#6146) 2026-11-11 13:57:51 -03:00
batistalucasv ad5e1a65fc #6159: refuse ui.screenshot on secondary document windows and support root window selection (#6169) 2026-11-11 14:22:51 +01:00
FredApps 0655e651fb Merge upstream control delivery changes 2026-11-08 17:35:06 +01:00
FredApps be75ee90e3 Merge upstream main and reconcile control documentation 2026-11-08 17:22:59 +01:00
FredApps 480511eaa5 Merge upstream main into control delivery changes 2026-11-08 17:15:38 +01:00
vangel76andClaude Sonnet 5.5 1c7c4e66e0 Merge upstream/main into control-mcp-delivery-1326-1331
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-07 11:38:09 +01:00
vangel76andClaude Sonnet 5.5 875a62043a Merge upstream/main into feat/322-view-windows
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-07 11:37:52 +01:00
Martin Ballandmatstrange ef35d79cb8 Control channel: a command that discards unsaved work is refused, not carried out (#3284)
Lands #3284.

Co-Authored-By: matstrange <54028700+matstrange@users.noreply.github.com>
2026-11-06 11:44:29 +01:00
vangel76andClaude Sonnet 5.5 4e334166e5 Merge upstream/main into control-mcp-delivery-1326-1331
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-06 01:10:42 +01:00
vangel76andClaude Sonnet 5.5 4ac7292d62 Merge upstream/main into feat/recent-remove-2716
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-06 01:09:58 +01:00
8c57b0775c Status bar: the live count shows words, characters, or characters without spaces (#3187)
Lands #3187.

Co-Authored-By: vangel76 <271991477+vangel76@users.noreply.github.com>
Co-Authored-By: SlavenDj <53652906+SlavenDj@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Codex <noreply@openai.com>
2026-11-06 00:27:28 +01:00
28925fac8c Linux: a setting chooses the display server (Wayland / X11) (#3189)
Lands #3189.

Co-Authored-By: Yasas-Sri <164534752+Yasas-Sri@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: vangel76 <271991477+vangel76@users.noreply.github.com>
2026-11-06 00:04:18 +01:00
vangel76andClaude Sonnet 5.5 401e7c9169 Merge upstream/main into feat/322-view-windows
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 04:13:02 +01:00
vangel76andClaude Sonnet 5.5 951b255b80 Merge upstream/main into control-mcp-delivery-1326-1331
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 03:26:18 +01:00
vangel76andClaude Sonnet 5.5 d5495ea4f8 Merge upstream/main into feat/recent-remove-2716
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 00:12:16 +01:00
LQRDandClaude Opus 5.5 604ac6ddb2 #641: print N-up sheets and folded booklets (#3916)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 15:29:12 +01:00
Martin BallandClaude Sonnet 5.5 c45945a2ea CP4.3: Options > Language: Your languages with proofing status, Add a language picker, Set as default
The Dictionaries folder moves here from Proofing with the Dictionary files list (#1063) kept. Set as
default sets only the saved default proofing language (the new pure review.language.preferred command), and
proof.packs returns the languages rows.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FypgCYmv6UJmY2QcuhfXco
2026-11-03 23:59:42 +00:00
1ff68d64e3 i18n: Arabic interface with mirrored RTL shell (+ parity docs) (#5370)
* Arabic interface: mirrored right-to-left window and Arabic UI fonts

Adds the Arabic (`ar`) interface language's code: its catalogs are craft-i18n's
`locales/ar`, so this changes no catalog.

- `ar` is registered in `i18n::LANGUAGES` and `Lang::rtl()` says it is written
  right to left; its translations are used as written (egui's text layout
  orders each line's bidi text itself). A ribbon location reads from the right
  with a leftwards mark.
- `rtl.rs`: the window is mirrored. Containers open in `rtl::root`; columns,
  grids, checkboxes, radio buttons, menus, rows, panels, the dialog tab strip
  and the ribbon's scrolling row follow the language's direction. Title bar,
  status bar, ribbon tabs and groups, File pages (including Print, with the
  settings on the right and a solid scrollbar gutter), dialogs, menus and the
  task panes (their docking edge swaps) are laid out from the right. egui's
  `Grid` panics in a right-aligned layout, so grids go through `rtl::grid`.
- Arabic UI font fallback: the craft-fonts Arabic face, else an installed
  Arabic font, loaded when the interface is Arabic.
- The "Auto (200%)" size label keeps its percent sign inside the isolated
  number.
- Tests: Arabic locale, saved preference and lookup order on fixture catalogs;
  an interface audit (skipped without the craft-i18n Arabic catalog) that lays
  the app out right to left at several widths, checks tab, group, pane, Print
  and Go To positions and that nothing panics.

The Arabic work builds on Abdelhaq El Amraoui's mirrored-interface PR (#737).

Co-Authored-By: Abdelhaq El Amraoui <abdelhaqelamraoui@gmail.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Arabic interface: pin craft-i18n at a commit with the Arabic catalog; review fixes

- craft-i18n.rev and the Flatpak manifest pin 19358491 (craft-i18n main), the
  first commit line that has locales/ar/wordcraft.tsv. The old pin had no
  Arabic catalog, so `ar` was registered but not embedded and two i18n tests
  (the_language_setting_is_a_ui_command_and_persists,
  the_languages_offered_are_the_embedded_ones_of_the_list) failed in CI.
- The Arabic font fallback is requested for any right-to-left interface
  (`Lang::rtl()`), not only after the language picker sets the flag, so an
  automatic or saved Arabic gets the installed Arabic face.
- The file browser, the update window and Reading Mode's toolbar run their
  bodies in `rtl::root`, so their far-side buttons and rows are mirrored.
- A group in a right-to-left ribbon row is measured from the right edge: the
  cursor's left edge is negative infinity there, so its width was NaN and the
  ribbon planner dropped every group, never compacting a narrow Arabic window.
  A narrow window now folds groups into drop-downs.
- The mirrored checkbox and radio marks are labelled by their text, so screen
  readers name them.
- Tests: group width in a right-to-left row; the Arabic interface audit checks
  Reading Mode's toolbar.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Arabic interface: ask for the installed Arabic font separately from the CJK one

A previous commit made every right-to-left interface request the installed CJK
fallback font (`system_cjk`) so that the installed Arabic font would load. That
also made every Arabic launch read a large system CJK font file when no
craft-fonts input is embedded (the Flatpak build has none).

`install_ui_fonts` now passes a separate `system_arabic` flag (`Lang::rtl()`):
the installed Arabic font is read for it, and `system_cjk` is again set only
by a CJK interface or by CJK text on screen. `WordApp::fonts_system_arabic`
remembers what was installed, so a language change reinstalls the fonts.

Tests: the_installed_arabic_font_is_asked_for_by_arabic_alone (the Arabic flag
adds the installed font only when none is embedded, and the CJK request alone
adds no Arabic font). Checked a headless screenshot of the Arabic interface
without craft-fonts: the installed Arabic font draws the labels.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Fix the AutoSave switch knob: on is at the right, mirrored in Arabic

The title bar's AutoSave knob was placed with `lead_x(rtl == on, ..)`, which
reverses main's mapping in both directions: left to right it drew the knob at
the left when the switch was on, and right to left at the right. main draws it
at the right when on and at the left when off, so the mirrored interface must
draw it at the left when on: `rtl != on`.

The position is now `autosave_knob_x(rtl, on, track)`, pinned by a test for all
four cases. A headless screenshot of the off switch shows the knob at the left
in English and at the right in Arabic.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Arabic interface: file names and paths in right-to-left lines; kerning row order

Tester feedback on the Arabic interface:

- File > Open's Recent list, the built-in file browser and the title bar drew
  file names and paths raw, from the left edge. In an Arabic line the marks of
  a name ("(نهائي) 2.docx") and the folders of a path with Arabic parts were
  scrambled. Rows now start at the side reading starts from (`rtl::lead_x`),
  names go through `i18n::isolate` (a first-strong isolate, with a left-to-right
  mark before the extension so `2.docx` stays `2.docx`) and paths through
  `i18n::isolate_path` (a left-to-right isolate with a mark after every
  separator, so neighbouring Arabic folders do not swap). Other languages get
  the text untouched; saved and spoken text never carries the marks.
- Font dialog, Kerning row: the dialog's grid is drawn left to right inside a
  right-to-left window, so "Points and above" came after its number; in an
  Arabic interface it now comes first, so the line reads "14 نقطة فأكثر" from the
  right. (The grid's columns themselves still keep their left-to-right order.)

Tests: names_and_paths_are_isolated_in_a_right_to_left_interface.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Arabic interface: mirror through craft_ui::direction and Style::right_to_left

The suite's craft-ui now has the direction helpers (`craft_ui::direction`) and
its egui fork a `Style::right_to_left` that mirrors egui's own chrome. Use them
instead of our parallel wrappers:

- `rtl::sync(ctx)` applies the interface direction every frame the language's
  changes (`direction::apply`): it sets the shared direction state and
  `Style::right_to_left` on every theme, which draws check boxes and radio
  buttons with the mark at the reading start, mirrors submenus, scroll bars,
  title bars and the combo boxes' arrows (the Print page's choice lists, the
  font list) and opens combo menus from the right.
- `rtl::checkbox`, `radio_value`, `radio` and `indeterminate_checkbox` are
  gone: about 200 call sites use plain `ui.checkbox`, `ui.radio_value`, ... and
  egui does the mirroring (and names the control by its text, as a plain widget).
- `lead_x`, `lead_center`, `lead_top`, `start_panel` and `end_panel` delegate to
  `craft_ui::direction`. `root`, `flows`, `island`, `grid`, `menu`, `vertical`,
  `far_side` and the other layout helpers stay: the shared crate has no
  equivalent that fits them.

Visual changes: the combo boxes' drop-down arrows and lists are mirrored in
Arabic; nothing changes in left-to-right languages (checked headless
screenshots of the English main window, Font dialog and Print page).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Recent files and the file browser: full path on hover, long names keep their start

Review feedback:

- Each row of File > Open's Recent list shows the document's full path as its
  tooltip (the path line under the name can be longer than the row).
- A long name in the built-in file browser is laid out in one row, with an
  ellipsis at its end, from the side reading starts from, instead of being
  clipped at the row's edge: in a right-to-left interface the old text anchored
  at the right edge cut the end of an Arabic name and the start of a Latin one.
  The whole name is the row's tooltip when it was shortened.

Checked headless screenshots of the file browser with a long English and a long
Arabic name.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Font combos in a right-to-left row: the arrow joins its field on the left

The ribbon's font name and size boxes are drawn from a field and a separate
arrow box that share one outline: the field is square and the arrow's box is
rounded on the side where the arrow goes, painted a border width under the
field. That assumed the arrow is right of the field. In a right-to-left row
(the Arabic ribbon) the arrow comes after the field on its left, so the field
was square on the wrong side and the arrow box rounded on the side facing the
field: two boxes with a gap-like seam, the arrow looking outside the frame.

`arrow_box_shape(rtl, ..)` mirrors the radii and the underlap, and the field's
square corners are chosen by the row's direction (the nw/sw pair in right to
left). Left-to-right rows are drawn exactly as before (English before/after
crops are identical).

Test: the_arrow_box_is_rounded_away_from_its_field.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Pin craft-i18n 4612850 (merged Arabic WordCraft rows, craft-i18n#76)

The pin and the Flatpak manifest commit move from 1935849 to 4612850, which is on
craft-i18n main and adds the 70 Arabic rows this branch relies on.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Pin craft-i18n cac2cf0 (Arabic number agreement and status-bar rows)

Moves the pin and the Flatpak manifest commit from 4612850 to the current craft-i18n
main, which includes craft-i18n#95 (48bed03) and #81 (ef58ff3).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Arabic: isolate paths shown beside labels; mirror the Print page zoom

File > Info shows Location as its own left-to-right path label (cut short with the full path on hover, not wrapped), and the open-failure, Exported and dictionary-file messages isolate their paths. The Print preview zoom puts minus at the slider's left end and plus at its right in Arabic, as the status bar does.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Arabic: mirror the label/field rows of the Font, Info, Paragraph, Page Setup, Insert Table and Options forms

rtl::Table lays a form out as an egui Grid in a left-to-right interface (same id, columns and spacing, so the output is unchanged) and, where the interface is mirrored, with each row's cells running from the right, every column as wide as its widest cell. File > Info puts Properties at the right and Statistics after it, and the Font dialog's kerning row reads 14 points and above.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* docs: record Arabic mirrored interface landing (#1195)

Update the language counts, Arabic parity row, gap #11, and UI/ROADMAP
status so they match the craft-i18n catalog and mirrored shell already
on this branch.

* Fix Organizer Copy arrow in RTL and refresh roadmap status.

Point the Copy glyph at the Document column when the shell is mirrored,
and bump docs/roadmap.md status/revision history for Arabic UI (#1195).

* fix(ui): keep pane dock left/right physical in RTL

ui.paneDock and view.stylesPaneDock now store and report physical window sides; only unset defaults still open on the reading-start edge. Also wrap the language-packs grid for RTL, document the contract, and load a system Arabic face for Arabic names in LTR UIs.

* docs: clarify mirrored default pane edges in RTL

Start-default panes open on the physical right in Arabic; end-default
panes open on the physical left — not every never-docked pane on the right.

* refactor(ui): one PaneState for a saved pane place

The four saved-dock arms built the same PaneState; only the place and
whether it was set explicitly differ.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* style(ui): rustfmt the panes re-exports

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: The Legend Of MTS Dev <tlo.mts.tsh@gmail.com>
Co-authored-by: Abdelhaq El Amraoui <abdelhaqelamraoui@gmail.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: email <email@email.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
2026-11-03 15:00:45 +01:00
vangel76andClaude Sonnet 5.5 45cfc55116 Merge upstream/main
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-02 23:54:30 +01:00
Martin BallandClaude Opus 5.5 c1490c5ba9 CP4.3: review — a click from the control channel never turns on downloading; installs and refreshes run in the background in the app; parked documents proof again after a pack change
- Install, Show available languages and Refresh turn on the font store's downloading only on the
  person's own click (input_from_control, as in #959); a faked click says why instead.
- proof.installPack and proof.packs {refresh} run on the engine's thread in the app ("started"),
  with progress, results and errors in proof.packs; the CLI and headless MCP stay synchronous.
- A session's layout is keyed on the dictionaries' generation, so parked documents proof again.
- proof.removePack refuses while that pack installs; pack commands that need a locale are left out
  of Search; options text names Refresh; licence tooltip says Source; errors go through tl!;
  the bar rescans at most once a second while typing; English names for every pack language and
  sr-latn; About has one Close button; xtask doc comment back on cmd_i18n_report.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FypgCX8LsYYE8fsj4byBm2
2026-11-02 01:04:00 +00:00
Martin BallandClaude Opus 5.5 e5d46bb242 CP4.3: Language packs: proof.packs, proof.installPack, proof.removePack; Options › Language list, missing-pack bar, About › Language data
- engine `packs`: the packs Backend (the font store on the desktop and CLI, a fixed list in tests
  and ui_shot), the pinned index, installs and removals through craft-font-store's
  `language-pack` kind, craft-proof reading the store's `language-packs/` folder at once.
  Commands open nothing and never turn downloading on (only an Install click in the app does);
  confined automation can't write the packs folder outside its write root.
- ui-egui `language_packs`: File › Options › Language › Language packs (name, size, licence,
  source, Install/Remove, progress, errors), the missing-pack bar (dismissible per document,
  never for a language without a pack), About › Language data (full licence texts).
- CP4.4: `cargo xtask language` (in `ci`): the default build embeds only en-* Language data.
- CP4.5: docs (help, MCP, control protocol, gaps #8, localization parity, roadmap).
- Path deps to Lane 4's worktrees while developing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FypgCX8LsYYE8fsj4byBm2
2026-11-02 01:03:59 +00:00
vangel76andClaude Sonnet 5.5 1bbced51a4 Recent list: saved is null when no preferences were written
The desktop hook returns Ok(false) when preferences are switched off or there is
no settings folder; the commands report that like a host without a hook. Also
move add_saved out of works_without_document's doc comment.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-01 13:53:50 +01:00
vangel76andClaude Sonnet 5.5 9de2227af2 Report a failed preferences save from ui.recentRemove and ui.recentClear
The save_prefs hook now returns a Result; both commands add saved/saveError to
their result and the status line says when the write failed.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-01 13:33:45 +01:00
vangel76andCodex 0e7dc8da53 fix(control): prevent ambiguous mutation replay (#2596)
Propagate accept-thread startup errors and remove the key file. Keep image exports from being retried and continue stdio after invalid UTF-8.

Co-Authored-By: Codex <noreply@openai.com>
2026-10-31 22:12:18 +01:00
vangel76andClaude Sonnet 5.5 841dd538dc Merge upstream/main into feat/322-view-windows
Main now gives every document its own native window in one process, with Switch Windows and
New Window. Drop the one-process-per-window registry and peer channel and build Arrange All,
View Side by Side and Synchronous Scrolling on those windows: the drawn window sees the others
by window id, tiles and halves are placed through the windows' viewports, and the scrolling is
handed to the partner window in document points.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-26 19:46:57 +01:00
vangel76andClaude Sonnet 5.5 c85d454e09 Merge upstream/main into feat/recent-remove-2716
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-26 19:27:54 +01:00
aiongg 27068500dd Merge branch 'w2' into w3
# Conflicts:
#	crates/ui-egui/Cargo.toml
#	crates/ui-egui/src/panes.rs
2026-10-26 03:40:18 +00:00
aiongg 7d512a6905 Merge remote-tracking branch 'upstream/main' into w1
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	NOTICE
#	apps/wordcraft/Cargo.toml
#	crates/engine/src/lib.rs
#	crates/ui-egui/Cargo.toml
#	docs/control-protocol.md
#	docs/shared-pdf.md
2026-10-26 03:38:36 +00:00
aiongg 6dca584bbd Task panes: drop a pane outside or inside a docked pane to order a side (#4386)
* Task panes: a pane dropped over a docked pane's outer or inner third docks outside or inside it, and the order is kept (craft-libs#357)

* Pin craft-libs at b74f1b6 (pane order on an edge, craft-libs#357)

* Pin craft-libs at b926b5c (craft-libs main)
2026-10-25 23:29:51 -04:00
aiongg 15090b9d81 Merge pull request #3109 from aiongg/panes-trial
Task panes: draw them with craft_ui::panes; Styles docks left or right or floats
2026-10-25 23:13:49 -04:00
aiongg 5632755be4 Merge branch 'w2' into w3
# Conflicts:
#	Cargo.lock
#	ROADMAP.md
#	apps/wordcraft/src/main.rs
#	crates/ui-egui/Cargo.toml
#	crates/ui-egui/src/backstage.rs
#	crates/ui-egui/src/control.rs
#	crates/ui-egui/src/dialogs.rs
#	crates/ui-egui/src/keys.rs
#	crates/ui-egui/src/lib.rs
#	crates/ui-egui/src/panes.rs
#	crates/ui-egui/src/previews.rs
#	docs/ui-parity.md
2026-10-26 03:09:46 +00:00
aiongg 4029a4e6fc Merge remote-tracking branch 'upstream/main' into w1
# Conflicts:
#	ROADMAP.md
#	crates/engine/src/lib.rs
#	crates/engine/src/session.rs
#	crates/mcp/src/tools.rs
#	crates/ui-egui/src/control.rs
#	crates/ui-egui/src/i18n/bg.tsv
#	crates/ui-egui/src/i18n/cs.tsv
#	crates/ui-egui/src/i18n/da.tsv
#	crates/ui-egui/src/i18n/de.tsv
#	crates/ui-egui/src/i18n/es.tsv
#	crates/ui-egui/src/i18n/et.tsv
#	crates/ui-egui/src/i18n/fr.tsv
#	crates/ui-egui/src/i18n/hr.tsv
#	crates/ui-egui/src/i18n/hu.tsv
#	crates/ui-egui/src/i18n/it.tsv
#	crates/ui-egui/src/i18n/ja.tsv
#	crates/ui-egui/src/i18n/ko.tsv
#	crates/ui-egui/src/i18n/nl.tsv
#	crates/ui-egui/src/i18n/pl.tsv
#	crates/ui-egui/src/i18n/pt-br.tsv
#	crates/ui-egui/src/i18n/ro.tsv
#	crates/ui-egui/src/i18n/ru.tsv
#	crates/ui-egui/src/i18n/sl.tsv
#	crates/ui-egui/src/i18n/sr-latn.tsv
#	crates/ui-egui/src/i18n/sr.tsv
#	crates/ui-egui/src/i18n/sv.tsv
#	crates/ui-egui/src/i18n/tr.tsv
#	crates/ui-egui/src/i18n/uk.tsv
#	crates/ui-egui/src/i18n/vi.tsv
#	crates/ui-egui/src/i18n/zh-hans.tsv
#	crates/ui-egui/src/i18n/zh-hant.tsv
#	crates/ui-egui/src/lib.rs
#	docs/gaps.md
#	docs/mcp.md
#	docs/parity-checklist.md
#	docs/ui-parity.md
2026-10-26 03:01:45 +00:00
aiongg f501f7cb5f Task panes: Dock Left, Dock Right and Float run ui.paneDock for every pane but Styles 2026-10-24 23:43:01 +00:00
vangel76andClaude Sonnet 5.5 d7c7889c82 Merge upstream/main into feat/recent-remove-2716
Interface catalogs now live in craft-i18n; the PR's tsv rows are dropped.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-24 14:18:34 +02:00
vangel76andClaude Sonnet 5.5 28b5cba00c Merge upstream/main into feat/322-view-windows
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-24 13:53:17 +02:00
Martin BallandClaude Opus 5.5 08da5c5433 #3699: MCP bridge sends the control key only to 127.0.0.1, where the app listens
Audit finding 9 (CWE-522). The bridge sent the reusable control key to any
loopback peer (127.0.0.0/8, ::1) and tried every address `localhost`
resolved to, while the app binds only 127.0.0.1. Another local user could
listen on ::1 or 127.0.0.2 and receive the key. Now `localhost` connects to
127.0.0.1 only, and the key goes only to a 127.0.0.1 peer.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-23 20:19:49 +01:00
Gabriel Luís da Silva 05839461af #3734: ui.resize refuses sizes that aren't positive and clamps to the GPU's limit (#3920)
* #3734: ui.resize refuses sizes that aren't positive and clamps to the GPU's limit

The control channel forwarded any width/height to the viewport. Zero, negative and huge sizes now get an error or a size the window can have: the app's minimum and the largest texture the GPU draws (at most 16384 points). The reply carries the size asked for.

* #3734: refuse non-finite sizes, and let the GPU limit win over the minimum

Review follow-up: an infinite side (1e300 once read as f32) is refused rather than clamped, and a GPU limit below the app's minimum caps the size instead of being raised to it.
2026-10-23 12:03:33 -04:00
vangel76 c488558a1c Merge upstream/main into feat/recent-remove-2716 2026-10-22 19:10:34 +02:00
aiongg 3a6f3fbb17 W3b: docs: one window per document (control protocol, UI parity, progress log) 2026-10-22 16:54:37 +00:00
vangel76 65f36f9b8a Merge upstream/main into feat/322-view-windows 2026-10-22 18:53:05 +02:00
aiongg a2ca57ca3f W1: MCP, control channel and CLI address an open document by id
- MCP: execute, batch, type_text, select_text, get_text, inspect_document,
  render_page and save_document take an optional doc (an open document's
  id); the headless server runs them through Session::with_document and
  the bridge passes doc to the app. New list_documents tool; new_document
  replies with the new document's id. Tool descriptions and the server
  instructions say that file.new and file.open open another document.
- Control channel: engine.execute, document.inspect and ui.render take
  doc and work on that document while the window keeps the active one;
  file.close on an addressed document refuses unsaved changes unless
  forced; ui.* commands need the document on screen. ui.inspect reports
  document and documents. Unknown or malformed ids are errors.
- CLI run starts with one open document; help and docs describe how
  file.new, file.open and view.switchWindows work in a run.
- docs/mcp.md and docs/control-protocol.md describe document ids and doc.
2026-10-22 14:53:21 +00:00
aiongg 0b81f22d5b Merge PR #3258: Docs: control protocol's Methods table renders again
docs/control-protocol.md: one engine.execute row, main's current text (the template save command, focusRibbon) with the PR's \| escapes and its ui.contextMenu entry
2026-10-22 01:22:01 +00:00
5a6d2b6070 File › New: personal templates from a user templates folder (#2852) (#3133)
* #2852: personal templates in File › New, Save as Word Template

File › New lists the .dotx/.dotm files in the user templates folder under
Personal (a subfolder per category, search covers them); a click makes an
untitled document attached to the template. Save As › Save as Word Template
starts in that folder (<settings>/Templates, made on first use; File ›
Options › Advanced › File locations › User templates overrides it).
Engine: file.listTemplates (bounded, network folders refused, read root
applies), file.newFromTemplate sets the attached template, file.options
userTemplatesFolder, file.saveTemplate keeps a .dotm name. UI:
ui.saveAsTemplate; Save dialog requests carry a start folder.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012WEhZXSxzS8orX7f9J3qpr

* #2852: review — a personal template asks about unsaved changes; network templates folder refused before it's looked at; New lists the folder once per visit with Refresh; .dotx/.dotm labels alike

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012WEhZXSxzS8orX7f9J3qpr

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: aiongg <aiongtaigi@gmail.com>
2026-10-21 20:18:50 -04:00