mirror of
https://github.com/storytold/vectorcraft.git
synced 2026-10-24 09:46:59 -06:00
Taha-Mahmoodi
eb4635fd4b
The drawing-modes help page (https://helpx.adobe.com/illustrator/desktop/draw-shapes-and-paths/learn-drawing-basics/drawing-modes-overview.html) has you draw or paste into the selected object in Draw Inside. It also says the modes apply to Paste in Place and Paste on All Artboards but not to Paste in Front or Paste in Back. Cause: only new art (create::insert_look) read the drawing mode. The paste commands (edit::paste_clip) always used the insertion parent, so a paste in Draw Inside landed on the layer above the object, outside the clip. Double-clicking the object first only isolated the bare path, which didn't change where the paste went. Separately, view.drawMode {} went from Draw Behind to Draw Inside whenever one object was selected, then refused it unless the object was a path, compound path or type. So with one group selected (such as the clip group Draw Inside makes), Shift+D and the toolbar button failed every time and stayed in Draw Behind. Change: the clip-group wrapping moves into create::draw_inside_group, which new art and pastes now share. In Draw Inside, Paste, Paste in Place and Paste on All Artboards insert the copies at the top of that group, in the paste's one undo step, ignoring Paste Remembers Layers. In Draw Behind, Paste in Place and Paste on All Artboards go just below the selection, as Paste in Back does. Paste in Front, Paste in Back and pasted artboards keep their placement. Shift+D goes on to Draw Inside only when it can draw into the selection, and otherwise back to Draw Normal. Verification: pasting_in_draw_inside_puts_the_copies_inside_the_object, paste_in_place_in_draw_behind_goes_behind_the_selection and shift_d_goes_past_draw_behind_whatever_is_selected all fail without the change ("Layer" != "Clip Group"; index 3 != 0; the Draw Inside error on a selected group). cargo xtask ci: all 10 steps passed.