mirror of
https://github.com/storytold/vectorcraft.git
synced 2026-10-24 09:46:59 -06:00
Hamza
7bc7025a62
Two review points on #2880. The reproducibility claim needed qualifying. PDF encryption draws its AES initialisation vectors and the file `/ID` from a random seed, which `SOURCE_DATE_EPOCH` deliberately does not reach, so a PDF exported with a password never repeats however the variable is set. The docs and the ROADMAP line say so now. The byte-identity test passes an explicit `created`, so it never exercised the clock-or-variable fallback. `pinned_or` takes the environment and the clock as arguments, and the new test shows the variable is preferred, that a blank, negative or non-numeric value leaves it to the clock, and that a host with neither has no date to record. The environment is injected rather than set: a test that changes this process's environment is `unsafe` under edition 2024 and would reach every other test running beside it, which is why `cursor_theme` takes a lookup closure too.