mirror of
https://github.com/storytold/vectorcraft.git
synced 2026-10-24 09:46:59 -06:00
A filter plug-in had nowhere to keep settings that belong to the whole document rather than to one object, such as the pens a plotter holds or a machine profile: it could only ask for them again on every run. - A filter's output may hold documentData: any JSON of at most 1 MiB (objects::MAX_DOCUMENT_DATA) that replaces what the plug-in keeps with the document, null removing it, in the same undo step as its objects (objects::decode_output). Too much refuses the output and the document stays as it was. - A filter gets it back in _context.documentData (null until it keeps something). A filter reads and writes only its own. - It is the document's foreign data, Document::unknown["pluginData"] by plug-in id (vectorcraft_doc::plugin_data), where the perspective grid and the brushes keep theirs. So the native file needs no section of its own for it, and hosts from before keep it when they save. An exporter is given the whole document, so it can read every plug-in's. Nothing else lists it, as the reference app's Document Info lists no plug-in data. A live effect isn't given it: its geometry is worked out from the object alone wherever it is drawn. Tests: plugin_data.rs (each plug-in its own entry, forgetting what isn't kept copies nothing, a damaged value holds nothing), objects/tests.rs (kept, forgotten, refused over the limit), tests_plugins.rs (one undo step with the objects, read back, not given to another filter, kept by the native file among its foreign data, refused over the limit with the document unchanged, null removes it) and tests/plugin_export.rs (an exporter finds another plug-in's). The size error has its row in each complete catalog (COMPLETE_MESSAGES). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HhvnnnD5fTFupK8WWq35un
87 lines
3.7 KiB
Rust
87 lines
3.7 KiB
Rust
//! What plug-ins keep with a document: settings that belong to the whole document rather than to
|
|
//! one object, such as the pens a plotter holds or a machine's profile.
|
|
//!
|
|
//! They are the document's foreign data ([`Document::unknown`], under [`PLUGIN_DATA`]), as the
|
|
//! perspective grid and the brushes are, so the native file has no section of its own for them
|
|
//! and a version from before them keeps them when it saves. The host never reads them: a filter
|
|
//! plug-in writes its own and reads only its own back, and an exporter, which is given the whole
|
|
//! document, can read them all (`vectorcraft-plugins`, which caps what one plug-in keeps).
|
|
|
|
use serde_json::{Map, Value};
|
|
|
|
use crate::Document;
|
|
|
|
/// `Document::unknown` key: `{"<plug-in id>": <what it keeps>}`.
|
|
pub const PLUGIN_DATA: &str = "pluginData";
|
|
|
|
impl Document {
|
|
/// What plug-in `id` keeps with the document, if anything.
|
|
pub fn plugin_data(&self, id: &str) -> Option<&Value> {
|
|
self.unknown.get(PLUGIN_DATA).and_then(|m| m.get(id))
|
|
}
|
|
|
|
/// Keeps `data` for plug-in `id` in place of what it kept; `None` forgets it, and the key goes
|
|
/// once no plug-in keeps anything. A value under the key that isn't a map of plug-in ids (a
|
|
/// damaged file) is replaced when a plug-in keeps something.
|
|
pub fn set_plugin_data(&mut self, id: &str, data: Option<Value>) {
|
|
let Some(data) = data else {
|
|
// Nothing to forget: don't copy the foreign data the undo history shares.
|
|
if self.plugin_data(id).is_none() {
|
|
return;
|
|
}
|
|
let Some(m) = self.unknown.get_mut(PLUGIN_DATA).and_then(Value::as_object_mut) else { return };
|
|
m.remove(id);
|
|
if m.is_empty() {
|
|
self.unknown.remove(PLUGIN_DATA);
|
|
}
|
|
return;
|
|
};
|
|
let kept = self.unknown.entry(PLUGIN_DATA.to_string()).or_insert_with(|| Value::Object(Map::new()));
|
|
if !kept.is_object() {
|
|
*kept = Value::Object(Map::new());
|
|
}
|
|
if let Some(m) = kept.as_object_mut() {
|
|
m.insert(id.to_string(), data);
|
|
}
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use serde_json::json;
|
|
|
|
use super::*;
|
|
|
|
/// Each plug-in has its own entry, replaced when it keeps something else; forgetting the last
|
|
/// one removes the key, and forgetting what isn't kept copies nothing.
|
|
#[test]
|
|
fn each_plug_in_keeps_its_own_data() {
|
|
let mut d = Document::new(10.0, 10.0);
|
|
assert_eq!(d.plugin_data("a"), None);
|
|
d.set_plugin_data("a", Some(json!({"pens": 2})));
|
|
d.set_plugin_data("b", Some(json!([1, 2])));
|
|
d.set_plugin_data("a", Some(json!({"pens": 3})));
|
|
assert_eq!((d.plugin_data("a"), d.plugin_data("b")), (Some(&json!({"pens": 3})), Some(&json!([1, 2]))));
|
|
d.set_plugin_data("a", None);
|
|
assert_eq!(d.unknown[PLUGIN_DATA], json!({"b": [1, 2]}));
|
|
let before = d.clone();
|
|
d.set_plugin_data("a", None);
|
|
assert!(crate::Shared::ptr_eq(&before.unknown, &d.unknown), "still shared with the earlier version");
|
|
d.set_plugin_data("b", None);
|
|
assert!(!d.unknown.contains_key(PLUGIN_DATA));
|
|
}
|
|
|
|
/// A damaged file's value under the key holds nothing for any plug-in, stays while there is
|
|
/// nothing to forget, and is replaced when a plug-in keeps something.
|
|
#[test]
|
|
fn a_damaged_value_holds_nothing() {
|
|
let mut d = Document::new(10.0, 10.0);
|
|
d.unknown.insert(PLUGIN_DATA.into(), json!(5));
|
|
assert_eq!(d.plugin_data("a"), None);
|
|
d.set_plugin_data("a", None);
|
|
assert_eq!(d.unknown[PLUGIN_DATA], json!(5));
|
|
d.set_plugin_data("a", Some(json!(true)));
|
|
assert_eq!(d.unknown[PLUGIN_DATA], json!({"a": true}));
|
|
}
|
|
}
|