aleleba/vectorcraft
1
0
Fork 0
mirror of https://github.com/storytold/vectorcraft.git synced 2026-11-10 18:10:01 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5135 from dotCooCoo/fix/vars-p15

Browse Source 
Variables: Rename reports a missing variable or data set before a taken name
This commit is contained in:
Brandon Thomas
2026-11-01 15:27:45 -05:00
committed by GitHub
parent 0271e034ce f98b086c5f
commit 7e5eebc3ed
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/engine/src/tests/variables.rs
+14
View File
@@ -652,6 +652,20 @@ fn renaming_carries_the_bindings_and_values_with_it() {
assert!(s.execute("dataset.rename", &json!({"name": "Title", "newName": "Taken"})).is_err());
}
/// Renaming a name that does not exist onto one that does reports the missing name, the same
/// error a rename to a free name gives.
#[test]
fn renaming_a_missing_name_onto_a_taken_one_reports_the_missing_name() {
let mut s = session();
s.execute("variable.define", &json!({"name": "A", "kind": "text"})).unwrap();
s.execute("dataset.new", &json!({"name": "A"})).unwrap();
let e = s.execute("variable.rename", &json!({"name": "Nope", "newName": "A"})).unwrap_err().to_string();
assert!(e.contains("no variable named `Nope`"), "{e}");
let e = s.execute("dataset.rename", &json!({"name": "Nope", "newName": "A"})).unwrap_err().to_string();
assert!(e.contains("no dataset named `Nope`"), "{e}");
}
/// `dataset.set` is how a value changes after the row exists: replacing it must not need the
/// dataset to be deleted and rebuilt (which loses its place in the list and the active one).
#[test]