From cfdeda35c473e87795f9d561c47ae89ee060e37f Mon Sep 17 00:00:00 2001 From: dotCooCoo Date: Thu, 29 Oct 2026 02:38:00 -0700 Subject: [PATCH] Tests: the non-sRGB Drop Shadow test fails when its child test does not run svg_darkness_uses_rendered_shadow_in_non_srgb_working_space runs itself again in a child process with --exact and checked only the exit status. libtest exits 0 when --exact matches no test, so a rename of the test would have left the parent passing without running the non-sRGB check. The parent now also requires "1 passed" in the child's output, as layout_cache_follows_fonts_added_later in crates/tools does. --- crates/engine/src/cmd/fileio/tests_svg.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/crates/engine/src/cmd/fileio/tests_svg.rs b/crates/engine/src/cmd/fileio/tests_svg.rs index 3b9d793aa..f9b8316e8 100644 --- a/crates/engine/src/cmd/fileio/tests_svg.rs +++ b/crates/engine/src/cmd/fileio/tests_svg.rs @@ -356,7 +356,12 @@ fn svg_darkness_uses_rendered_shadow_in_non_srgb_working_space() { .env(CHILD, "1") .output() .unwrap(); - assert!(output.status.success(), "{}\n{}", String::from_utf8_lossy(&output.stdout), String::from_utf8_lossy(&output.stderr)); + let stdout = String::from_utf8_lossy(&output.stdout); + assert!( + output.status.success() && stdout.contains("test result: ok. 1 passed; 0 failed;"), + "isolated color profile test failed:\n{stdout}\n{}", + String::from_utf8_lossy(&output.stderr), + ); return; } use vectorcraft_color::{Color, Paint, cms};