aleleba/vectorcraft
1
0
Fork 0
mirror of https://github.com/storytold/vectorcraft.git synced 2026-11-10 09:59:47 -06:00
Code Issues Packages Projects Releases Wiki Activity

Symbols: Replace Symbol clears the old symbol's dynamic overrides

Browse Source 
An override on a dynamic symbol instance names an object of its symbol's
art by path. Replace Symbol kept every override whose path the new
symbol's art also had, so a change made to one object of the old symbol
was applied to an unrelated object of the new one. An instance given a
different symbol now drops its overrides; an instance replaced with its
own symbol keeps them. Undo brings them back.
This commit is contained in:
dotCooCoo
2026-11-01 16:24:33 -08:00
parent 639c9d6ce9
commit 2adf5a9a61
5 changed files with 34 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/engine/src/tests/dynamic_symbols.rs
+22
View File
@@ -111,6 +111,28 @@ fn redefining_the_symbol_keeps_the_changes_whose_objects_remain() {
assert_eq!(overrides(&s, inst), 0);
}
#[test]
fn replace_symbol_drops_the_changes_made_for_the_old_symbol() {
let mut s = session();
// "Other": two blue squares in the same places, the instance taken off the canvas.
let (a, b) = (square(&mut s, 10.0), square(&mut s, 60.0));
let first = id(&s.execute("symbol.new", &json!({"name": "Other", "ids": [a.0, b.0], "type": "dynamic"})).unwrap());
s.execute("edit.clear", &json!({"ids": [first.0]})).unwrap();
let inst = pair(&mut s, "dynamic");
s.execute("symbol.instance.setAppearance", &json!({"id": inst.0, "path": [1], "fill": "#ff0000"})).unwrap();
// The same symbol: nothing changes.
s.execute("symbol.replace", &json!({"name": "Pair", "ids": [inst.0]})).unwrap();
assert_eq!(overrides(&s, inst), 1);
assert_eq!(pixel(&s, 80, 30), RED);
s.execute("symbol.replace", &json!({"name": "Other", "ids": [inst.0]})).unwrap();
assert_eq!(overrides(&s, inst), 0, "the change named an object of Pair's art");
assert_eq!(pixel(&s, 80, 30), BLUE, "Other's art draws as the symbol has it");
s.execute("edit.undo", &json!({})).unwrap();
assert!(matches!(&node(&s, inst).kind, NodeKind::SymbolInstance { symbol, .. } if symbol == "Pair"));
assert_eq!(overrides(&s, inst), 1);
assert_eq!(pixel(&s, 80, 30), RED);
}
#[test]
fn reset_and_static_drop_the_changes_and_undo_brings_them_back() {
let mut s = session();