mirror of
https://github.com/storytold/vectorcraft.git
synced 2026-10-31 13:17:19 -06:00
Plug-ins: filters keep data with the document (G17)
A filter plug-in had nowhere to keep settings that belong to the whole document rather than to one object, such as the pens a plotter holds or a machine profile: it could only ask for them again on every run. - A filter's output may hold documentData: any JSON of at most 1 MiB (objects::MAX_DOCUMENT_DATA) that replaces what the plug-in keeps with the document, null removing it, in the same undo step as its objects (objects::decode_output). Too much refuses the output and the document stays as it was. - A filter gets it back in _context.documentData (null until it keeps something). A filter reads and writes only its own. - It is the document's foreign data, Document::unknown["pluginData"] by plug-in id (vectorcraft_doc::plugin_data), where the perspective grid and the brushes keep theirs. So the native file needs no section of its own for it, and hosts from before keep it when they save. An exporter is given the whole document, so it can read every plug-in's. Nothing else lists it, as the reference app's Document Info lists no plug-in data. A live effect isn't given it: its geometry is worked out from the object alone wherever it is drawn. Tests: plugin_data.rs (each plug-in its own entry, forgetting what isn't kept copies nothing, a damaged value holds nothing), objects/tests.rs (kept, forgotten, refused over the limit), tests_plugins.rs (one undo step with the objects, read back, not given to another filter, kept by the native file among its foreign data, refused over the limit with the document unchanged, null removes it) and tests/plugin_export.rs (an exporter finds another plug-in's). The size error has its row in each complete catalog (COMPLETE_MESSAGES). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HhvnnnD5fTFupK8WWq35un
This commit is contained in:
committed by
bflatastic
co-authored by
Claude Opus 5.5
parent
e93a73f60b
commit
1505384501
@@ -330,6 +330,53 @@ fn rough_frame_test_filter() {
|
||||
std::fs::write(std::path::Path::new(&dir).join("rough-frame-test-filter.wasm"), wat::parse_str(src).unwrap()).unwrap();
|
||||
}
|
||||
|
||||
/// A filter keeps data with the document: it writes it with `documentData` in the same undo step as
|
||||
/// its objects (`null` removes it) and reads what it last wrote in `_context.documentData`, which
|
||||
/// no other filter is given. It is the document's foreign data, so the native file keeps it with
|
||||
/// no section of its own. More than the limit is refused.
|
||||
#[test]
|
||||
fn filters_keep_their_data_with_the_document() {
|
||||
let mut s = session();
|
||||
let id = rect(&mut s, 10.0, "#ff0000");
|
||||
let pid = "test.engine.data";
|
||||
let returning = |out: Value| tpl::returning(&tpl::manifest(pid, "filter", "{}"), &out.to_string());
|
||||
let keep = |data: Value| json!({"objects": [{"id": id.0}], "documentData": data});
|
||||
let data = |s: &Session| s.doc().unwrap().doc.plugin_data(pid).cloned();
|
||||
let filter = |s: &mut Session, pid: &str| s.execute("plugin.run", &json!({"id": pid, "ids": [id.0]}));
|
||||
install_wat(&mut s, &returning(keep(json!({"pen": 2}))));
|
||||
filter(&mut s, pid).unwrap();
|
||||
assert_eq!(data(&s), Some(json!({"pen": 2})));
|
||||
run(&mut s, "edit.undo", json!({}));
|
||||
assert_eq!(data(&s), None, "one undo step with the objects");
|
||||
run(&mut s, "edit.redo", json!({}));
|
||||
// Read back: these name the object only when they are given what they look for.
|
||||
let named = |name: &str| json!({"objects": [{"id": id.0, "name": name}]}).to_string();
|
||||
let when_given =
|
||||
|pid: &str, needle: &str, name: &str| tpl::when_given(&tpl::manifest(pid, "filter", "{}"), tpl::Given::Params, needle, &named(name));
|
||||
install_wat(&mut s, &when_given(pid, r#""documentData":{"pen":2}"#, "Pen 2"));
|
||||
filter(&mut s, pid).unwrap();
|
||||
assert_eq!(node(&s, id).name.as_deref(), Some("Pen 2"));
|
||||
// Another filter is given nothing: what a filter keeps is its own.
|
||||
let other = "test.engine.other";
|
||||
install_wat(&mut s, &when_given(other, r#""documentData":null"#, "Nothing kept"));
|
||||
filter(&mut s, other).unwrap();
|
||||
assert_eq!(node(&s, id).name.as_deref(), Some("Nothing kept"));
|
||||
// Saved with the document, among its foreign data.
|
||||
let saved = vectorcraft_format::load(&vectorcraft_format::save(&s.doc().unwrap().doc, false)).unwrap();
|
||||
assert_eq!(saved.plugin_data(pid), Some(&json!({"pen": 2})));
|
||||
assert_eq!(saved.unknown.get(vectorcraft_doc::plugin_data::PLUGIN_DATA), Some(&json!({pid: {"pen": 2}})));
|
||||
// Too much is refused, and the document stays as it was; null removes the data.
|
||||
let before = s.doc().unwrap().doc.clone();
|
||||
let big = "x".repeat(vectorcraft_plugins::objects::MAX_DOCUMENT_DATA);
|
||||
install_wat(&mut s, &returning(keep(json!(big))));
|
||||
let e = filter(&mut s, pid).unwrap_err().to_string();
|
||||
assert!(e.contains("documentData"), "{e}");
|
||||
assert_eq!(s.doc().unwrap().doc, before);
|
||||
install_wat(&mut s, &returning(keep(Value::Null)));
|
||||
filter(&mut s, pid).unwrap();
|
||||
assert_eq!(data(&s), None);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn plugin_management_commands() {
|
||||
let mut s = session();
|
||||
|
||||
Reference in New Issue
Block a user