Variables: a CSV header that names one variable twice is refused

dataset.import read two header cells that named one variable (City
and City, or Shown and #Shown) into the same column, so each row kept
only the last non-blank cell and the other value was dropped without a
word. The import is now refused with the two column numbers, and the
message has a row in every complete-message catalog.

crates/engine/src/cmd/variablecmds/csv.rs

@@ -252,8 +252,8 @@ fn header_variable(
 /// names; the other headers name variables, as [`header_variable`] reads them, and the
 /// variables the document doesn't define yet are defined, unbound. Without the `name` column,
 /// every header names a variable and the rows take the first free names "Data Set 1", "Data
-/// Set 2" and so on. Existing rows of the same name are replaced; new names are appended. One
-/// undo step.
+/// Set 2" and so on. Two headers that name one variable are refused. Existing rows of the same
+/// name are replaced; new names are appended. One undo step.
 pub(super) fn dataset_import(s: &mut Session, p: &Value) -> Result<Value> {
     const C: &str = "dataset.import";
     let bytes = datasets_csv_bytes(p, C)?;
@@ -277,6 +277,10 @@ pub(super) fn dataset_import(s: &mut Session, p: &Value) -> Result<Value> {
             return Err(bad(C, format!("empty header in column {}", i + 1)));
         }
         let (name, kind) = header_variable(cell, i + 1, &kinds, &mut defined, C)?;
+        if let Some(&(first, ..)) = columns.iter().find(|(_, n, _)| *n == name) {
+            let (first, column) = (first + 1, i + 1);
+            return Err(bad(C, format!("columns {first} and {column} both name the variable `{name}`")));
+        }
         columns.push((i, name, kind));
     }
     // Lock Variables refuses New Variable, so the import is refused when a header would define one.