From 5afc2aab66b4ce4a48e45ca6bd33fc5dcaf97152 Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Mon, 2 Nov 2026 20:21:57 -0500 Subject: [PATCH] clap-host tests: scan a freshly created private directory for the garbage-file test The test reused a PID-named directory under the shared temp dir after ignoring a failed cleanup, then loaded every .clap candidate in it. Another local account could pre-create that directory and plant a native library that the test runner would load. Create the directory exclusively (mode 0700 on Unix) and fail instead of reusing one that already exists. --- crates/clap-host/src/lib.rs | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/crates/clap-host/src/lib.rs b/crates/clap-host/src/lib.rs index 7142a9ee..943ae947 100644 --- a/crates/clap-host/src/lib.rs +++ b/crates/clap-host/src/lib.rs @@ -222,10 +222,22 @@ mod tests { assert!(plugin_info("reverb").is_none()); } + /// A new directory under the temp dir that this test alone created, readable only by its user + /// on Unix. Creation fails if the path already exists: the test then loads native libraries + /// from it, so it must never reuse a directory someone else could have put a library in. + fn fresh_private_dir(prefix: &str) -> std::path::PathBuf { + let nanos = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).map_or(0, |t| t.as_nanos()); + let d = std::env::temp_dir().join(format!("{prefix}-{}-{nanos}", std::process::id())); + let mut builder = std::fs::DirBuilder::new(); + #[cfg(unix)] + std::os::unix::fs::DirBuilderExt::mode(&mut builder, 0o700); + builder.create(&d).unwrap_or_else(|e| panic!("cannot create a fresh test directory {}: {e}", d.display())); + d + } + #[test] fn garbage_files_are_errors_not_crashes() { - let d = std::env::temp_dir().join(format!("soundcraft-clap-garbage-{}", std::process::id())); - let _ = std::fs::remove_dir_all(&d); + let d = fresh_private_dir("soundcraft-clap-garbage"); std::fs::create_dir_all(d.join("Bundle.clap/Contents/MacOS")).unwrap(); std::fs::write(d.join("garbage.clap"), b"\x7fELF this is not a plugin \x00\x01\x02").unwrap(); std::fs::write(d.join("empty.clap"), b"").unwrap();