mirror of
https://github.com/storytold/photocraft.git
synced 2026-10-31 21:37:08 -06:00
Tanish MankuandClaude Opus 5.5
07174271d5
Main's CI was effectively unverified: with cancel-in-progress on every ref, each merge cancelled the run of the one before. Between 09:56 and 20:34 UTC on 2026-10-07, 80 of 83 push runs on main were cancelled, and a formatting break from two PRs that were each green alone (#663 + #700) went unnoticed until PRs updated to main started failing. - ci.yml: cancel-in-progress only for pull_request. Main runs finish; a merge that lands meanwhile waits and runs next. - ci.yml: a `platforms` job picks the test matrix. main, manual runs and PRs labelled `full-ci` get Linux, macOS and Windows. Other PRs get Linux only, unless they touch code whose behaviour differs by platform (apps/, ui-egui, text, gpu, tablet, heif, build.rs, Cargo.lock, ci.yml). - ci.yml: the second Linux test run with craft-fonts covers only the crates that use the fonts (photocraft-text, photocraft-ui-egui), not the whole workspace again. - freebsd.yml, windows-arm64.yml: nightly on main instead of on every push and every Cargo.toml change; PRs touching their own packaging still run them. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
92 lines
3.6 KiB
YAML
92 lines
3.6 KiB
YAML
# Windows on ARM: package the ARM64 release the way release.yml does (cross-compiled on an x64
|
|
# runner, unsigned here), then install that MSI on a Windows 11 ARM64 runner, check the installed
|
|
# binaries are ARM64, run the CLI natively, and uninstall. (A native ARM64 `cargo test` job is left
|
|
# out for now: PdfCraft saw an intermittent access violation in egui UI tests there.)
|
|
name: Windows ARM64
|
|
|
|
# Nightly on main (dependency and runner-image drift shows up within a day), and on PRs that
|
|
# change the Windows packaging itself.
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- .github/workflows/windows-arm64.yml
|
|
- packaging/windows/**
|
|
schedule:
|
|
- cron: "41 4 * * *"
|
|
workflow_dispatch:
|
|
|
|
concurrency:
|
|
group: windows-arm64-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
env:
|
|
CARGO_TERM_COLOR: always
|
|
CARGO_INCREMENTAL: 0
|
|
|
|
jobs:
|
|
package:
|
|
name: package (cross-compiled on x64)
|
|
runs-on: windows-latest
|
|
timeout-minutes: 90
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable
|
|
with:
|
|
targets: aarch64-pc-windows-msvc
|
|
- uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2
|
|
with:
|
|
key: windows-arm64-package
|
|
- name: Install WiX
|
|
shell: pwsh
|
|
run: dotnet tool install --global wix --version 5.0.2
|
|
- name: Build and package (unsigned)
|
|
shell: pwsh
|
|
env:
|
|
DIST: ${{ github.workspace }}\dist\arm64
|
|
run: ./packaging/windows/package.ps1 -Arch arm64
|
|
- uses: actions/upload-artifact@v4
|
|
with:
|
|
name: photocraft-windows-arm64
|
|
path: dist/arm64/*
|
|
if-no-files-found: error
|
|
retention-days: 7
|
|
|
|
install:
|
|
name: install and run on ARM64
|
|
needs: package
|
|
runs-on: windows-11-arm
|
|
timeout-minutes: 30
|
|
steps:
|
|
- uses: actions/download-artifact@v4
|
|
with:
|
|
name: photocraft-windows-arm64
|
|
path: dist
|
|
- name: Install the MSI, check it, run it, uninstall it
|
|
shell: pwsh
|
|
run: |
|
|
$ErrorActionPreference = 'Stop'
|
|
$msi = (Get-ChildItem dist/*.msi | Select-Object -First 1).FullName
|
|
$p = Start-Process msiexec.exe -ArgumentList '/i', "`"$msi`"", '/qn', '/l*v', 'install.log' -Wait -PassThru
|
|
if ($p.ExitCode -ne 0) { Get-Content install.log -Tail 60; throw "msiexec /i exited $($p.ExitCode)" }
|
|
$dir = Join-Path $env:ProgramFiles 'PhotoCraft'
|
|
foreach ($exe in 'photocraft.exe', 'photocraft-cli.exe') {
|
|
$path = Join-Path $dir $exe
|
|
if (-not (Test-Path $path)) { throw "$exe not installed in $dir" }
|
|
$bytes = [System.IO.File]::ReadAllBytes($path)
|
|
$machine = [BitConverter]::ToUInt16($bytes, [BitConverter]::ToInt32($bytes, 0x3C) + 4)
|
|
if ($machine -ne 0xAA64) { throw "$exe is for machine 0x$('{0:X}' -f $machine), not ARM64" }
|
|
Write-Output "ok $path (ARM64)"
|
|
}
|
|
# The installed CLI runs natively on ARM64.
|
|
$cli = Join-Path $dir 'photocraft-cli.exe'
|
|
$out = & $cli --version 2>&1 | Out-String
|
|
if ($LASTEXITCODE -ne 0) { Write-Output $out; throw "photocraft-cli --version exited $LASTEXITCODE" }
|
|
Write-Output "ok photocraft-cli --version: $($out.Trim())"
|
|
$p = Start-Process msiexec.exe -ArgumentList '/x', "`"$msi`"", '/qn' -Wait -PassThru
|
|
if ($p.ExitCode -ne 0) { throw "msiexec /x exited $($p.ExitCode)" }
|
|
if (Test-Path (Join-Path $dir 'photocraft.exe')) { throw 'uninstall left photocraft.exe behind' }
|
|
Write-Output 'ok uninstalled'
|