mirror of
https://github.com/storytold/photocraft.git
synced 2026-10-28 03:47:00 -06:00
BFlatandClaude Opus 5.5
f0208fd798
- A layer about the canvas's size keeps its whole effect region even where it overhangs the edge, so the region keeps its size while the layer is dragged and the GPU moves its effect maps with it instead of rebuilding the shape, distance fields and every effect each frame. - Surface::translated moves a surface by copying encoded tile bytes tile to tile (no float round trip, no full-size intermediate; whole-tile moves share the tiles): 2.3x faster than to_interleaved + write_interleaved. Used by layer.translate, Move tool drags and algo::resample::translate_surface. - perf_scenarios: Move tool drag frame rows (styled layer, full-canvas layer with and without a drop shadow). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
60 lines
2.7 KiB
Rust
60 lines
2.7 KiB
Rust
//! Layer bounds exactly as `photocraft-compose` computes them (`layer_bounds`), with the per-tile
|
|
//! content scan cached by copy-on-write tile identity, so an effect layer's region costs a hash
|
|
//! lookup per tile instead of a pixel scan per frame.
|
|
|
|
use photocraft_doc::Layer;
|
|
use photocraft_geom::Rect;
|
|
#[cfg(test)]
|
|
use photocraft_raster::Surface;
|
|
|
|
pub use photocraft_compose::bounds::content_bounds;
|
|
|
|
/// Bounds of a layer's own pixels: `photocraft_compose::layer_bounds`.
|
|
pub fn layer_bounds(layer: &Layer, canvas: Rect) -> Rect {
|
|
photocraft_compose::layer_bounds(layer, canvas)
|
|
}
|
|
|
|
/// The region a layer's effect maps cover: its bounds grown by the effect reach, within the
|
|
/// canvas grown likewise (`photocraft_compose::effect_maps`) when the layer reaches far beyond
|
|
/// it. A layer about the canvas's size keeps its whole region even where it overhangs the edge:
|
|
/// then the region keeps its size while the layer moves (a Move tool drag), so its maps move with
|
|
/// it instead of being rebuilt every frame (#761). The maps are exact either way.
|
|
pub fn effect_region(layer: &Layer, canvas: Rect) -> Rect {
|
|
let m = photocraft_compose::effects::margin(layer);
|
|
let (whole, window) = (layer_bounds(layer, canvas).inflate(m), canvas.inflate(m));
|
|
let area = |r: Rect| u64::from(r.width()) * u64::from(r.height());
|
|
if area(whole) <= area(window).saturating_add(area(window) / 4) { whole } else { whole.intersect(&window) }
|
|
}
|
|
|
|
/// `photocraft_compose::transparent_outside`.
|
|
pub fn transparent_outside(layer: &Layer) -> bool {
|
|
photocraft_compose::transparent_outside(layer)
|
|
}
|
|
|
|
/// `photocraft_compose::composite_bounds`: where compositing the layer can change anything.
|
|
pub fn composite_bounds(layer: &Layer, canvas: Rect) -> Option<Rect> {
|
|
photocraft_compose::composite_bounds(layer, canvas)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
use photocraft_color::PixelFormat;
|
|
|
|
#[test]
|
|
fn matches_surface_content_bounds() {
|
|
let mut s = Surface::new(PixelFormat::RGBA8);
|
|
assert_eq!(content_bounds(&s), s.content_bounds());
|
|
s.fill_rect(Rect::new(10, 300, 40, 700), &[1.0, 0.0, 0.0, 1.0]);
|
|
s.fill_rect(Rect::new(-50, 5, -3, 9), &[0.0, 0.0, 1.0, 0.5]);
|
|
assert_eq!(content_bounds(&s), s.content_bounds());
|
|
// Cached a second time, and after a change.
|
|
assert_eq!(content_bounds(&s), s.content_bounds());
|
|
s.fill_rect(Rect::new(600, 600, 601, 601), &[0.0, 1.0, 0.0, 1.0]);
|
|
assert_eq!(content_bounds(&s), s.content_bounds());
|
|
let mut g = Surface::with_default(PixelFormat::GRAY8, &[1.0]);
|
|
g.fill_rect(Rect::new(3, 3, 9, 9), &[0.5]);
|
|
assert_eq!(content_bounds(&g), g.content_bounds());
|
|
}
|
|
}
|