mirror of
https://github.com/storytold/photocraft.git
synced 2026-10-26 02:47:07 -06:00
404a17e711
The PR stopped writing PhotoCraft's defaults for params a step leaves out. Checked against Photoshop, that is fine for Fill opacity and mode, Crop delete, Selective Color method, Channel Mixer monochrome, Paint Bucket contiguous and Gradient Map reverse/dither, but Photoshop plays other missing keys differently: Canvas Size anchors top left (PhotoCraft: centre), Apply Image blends Normal (Multiply), Color Balance turns preserve luminosity off (on), and a Paint Bucket step without a tolerance doesn't play at all. Those, and the unverified Hue/Saturation, Color Balance tone and Save for Web keys, are written again as before. - `tools.setColors` exported only the foreground of a step that sets both colours; such a step now doesn't export (the strict save refuses it, as before the PR). - `kind` on an imported `layer.setAdjustment` made Photoshop's "reset to default" (`set` with an empty `T`) a no-op merge; it now joins only params that edit something. - `cargo xtask corpus --atn` (and `--all`) failed on Windows: the Bjango archive has a macOS `Icon\r` file tar can't create there; it's skipped. - `test-corpus --changed` now runs for `atn_cmds` changes, and the `ALL` doc comment is back on `ALL`. Tests: defaults_photoshop_plays_differently_are_written, set_colors_exports_only_a_single_colour and adjustment_layer_reset_still_resets fail without this commit; the psd and engine .atn corpus tests still pass (16 files byte-identical; 513 kept Photoshop steps). Co-authored-by: Fabio Lissi <3223836+FabioLissi@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>