aleleba/photocraft
1
0
Fork 0
mirror of https://github.com/storytold/photocraft.git synced 2026-10-24 09:57:08 -06:00
Code Issues Packages Projects Releases Wiki Activity

Address CodeRabbit review: only this call's failed start opens the updates window (#5485)

Browse Source 
b1b6bd248 opened the window whenever the status was Failed after an
error, which includes a Failed left from an earlier check, so a later call
refused for bad params opened it too. It now opens only when this call's
start failed: the status changed to Failed, or the error is the Failed
message (the same start failure again). The test covers bad params after a
failed check, bad params from Idle, and a repeated start failure.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
David Mann
2026-10-23 00:48:03 +02:00
co-authored by Claude Opus 5.5
parent 7d13c854a3
commit 7c4af5bdf1
1 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/updates_ui.rs
+18 -3
View File
@@ -12,9 +12,16 @@ pub(crate) struct Runtime {
}
pub(crate) fn check(app: &mut PhotocraftApp, _ctx: &egui::Context, params: Value) -> Result<Value, String> {
let before = app.session.updates.status.clone();
let result = app.run("help.checkForUpdates", params);
// A check that fails to start still shows its failure and Check Again; the command error stands.
if result.is_ok() || matches!(app.session.updates.status, Status::Failed { .. }) {
// A check that fails to start still shows its failure and Check Again; the command error
// stands. Only this call's failure: a Failed left from an earlier check doesn't open the
// window for a call refused for another reason (bad params).
let failed_to_start = match (&result, &app.session.updates.status) {
(Err(error), status @ Status::Failed { message }) => *status != before || (!message.is_empty() && error.contains(message.as_str())),
_ => false,
};
if result.is_ok() || failed_to_start {
app.ui.updates_open = true;
app.updates_rt.startup_checked = true;
}
@@ -222,11 +229,19 @@ mod tests {
assert!(error.contains("Could not start worker"), "{error}");
assert!(matches!(app.session.updates.status, Status::Failed { .. }));
assert!(app.ui.updates_open, "the failure and Check Again are shown");
// Bad params are a caller error, not a failed check: nothing opens.
// Bad params are a caller error, not a failed check: nothing opens, also while the earlier
// failure is still the status.
app.ui.updates_open = false;
assert!(menus::invoke(&mut app, &ctx, "help.checkForUpdates", serde_json::json!({"x": 1})).is_err());
assert!(matches!(app.session.updates.status, Status::Failed { .. }), "the earlier failure stays");
assert!(!app.ui.updates_open, "bad params after a failed check");
app.session.updates.status = Status::Idle;
assert!(menus::invoke(&mut app, &ctx, "help.checkForUpdates", serde_json::json!({"x": 1})).is_err());
assert!(!app.ui.updates_open);
// The same start failure again opens it again.
app.session.updates.status = Status::Failed { message: "Could not start worker".into() };
assert!(menus::invoke(&mut app, &ctx, "help.checkForUpdates", serde_json::json!({})).is_err());
assert!(app.ui.updates_open, "a repeated start failure");
}
#[test]