From 1941e24b8bc1a9454ed0ff78fdbd93d60f5e6da8 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 8 Oct 2026 21:32:27 +0000 Subject: [PATCH] Pipette cursor test: Windows draws the precise crosshair itself input_tests::eyedropper_and_alt_sampling_show_a_pipette (#1028) expected the OS crosshair with Other Cursors = Precise, but on Windows the canvas draws its own crosshair and hides the OS cursor (visible_crosshair), so the test failed on every Windows run. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01UHgFEHEsefoQoBParH47JA --- crates/ui-egui/src/input_tests.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/ui-egui/src/input_tests.rs b/crates/ui-egui/src/input_tests.rs index 98fdde7ca2..2ea0270ce9 100644 --- a/crates/ui-egui/src/input_tests.rs +++ b/crates/ui-egui/src/input_tests.rs @@ -384,8 +384,10 @@ fn eyedropper_and_alt_sampling_show_a_pipette() { h.event(egui::Event::ModifiersChanged(Modifiers::ALT)); assert_eq!(cursor(&mut h), egui::CursorIcon::None, "⌥ samples with a pipette"); h.state_mut().run("prefs.set", json!({"values": {"cursors.other": "precise"}})).unwrap(); - assert_eq!(cursor(&mut h), egui::CursorIcon::Crosshair, "Precise keeps the crosshair"); + // Windows draws the crosshair on the canvas and hides the OS cursor (`visible_crosshair`). + let crosshair = if cfg!(target_os = "windows") { egui::CursorIcon::None } else { egui::CursorIcon::Crosshair }; + assert_eq!(cursor(&mut h), crosshair, "Precise keeps the crosshair"); h.event(egui::Event::ModifiersChanged(Modifiers::NONE)); h.state_mut().ui.tool = crate::state::Tool::Eyedropper; - assert_eq!(cursor(&mut h), egui::CursorIcon::Crosshair); + assert_eq!(cursor(&mut h), crosshair); }