mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-10-24 18:17:44 -06:00
Adrian
eaed3409f8
The settings scroll when the window is short, but OK was the last thing inside the scrolled content, so in a short window it was off screen until you scrolled to it, and the dialog was cut off partway through the theme cards. OK is now a row below the scroll area, outside it. The scroll area gets the height the window leaves (at least 60 pt, so OK stays on screen in the smallest window, 520 pt, at the largest interface size, 300%) and a scrollbar of its own instead of the floating one that lay over the right edge of the theme cards. A scroll area starts from the room its modal offers, and a modal offers more each frame for the first few, so with OK outside the scroll the dialog opened small and stretched by about 45 pt a frame for ten frames, and clicks in the first frames missed. The scroll area is asked for its full height from the start (min_scrolled_height, which egui applies only when the settings overflow it), so it opens at full size and does not stretch in a tall window. - test: OK and the title are on screen at window heights from 173 to 1100; OK closes the dialog and does not move while the settings scroll, and a far-down setting scrolls into view between the title and OK; the dialog does not grow after it opens; a very tall window has no blank gap above OK. Both the original layout and the stretching variants fail them. - parity: misc.preferences-dialog evidence and what is still missing.