mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-10-25 18:47:22 -06:00
* M6: flattening removes empty fields it cannot draw (#4017) Flattening kept every widget without an appearance so that its value was not lost with nothing drawn in its place (#1794). A field without a value has nothing to lose, yet it stayed in /AcroForm /Fields and on the page, so a flattened file could still be filled in. A widget without an appearance now stays only when its field has a value: its /V, or the nearest one inherited through /Parent. A missing value, an empty string or an empty array is no value. Comments and valued widgets are unchanged. Fixes #4017 * M6: flattening keeps a widget whose value is past the parent limit (#4017) has_value walks at most 64 levels up /Parent. When it ran out it said "no value", so a widget whose /V sat on the 64th ancestor was removed. Running out now counts as a value: one that wasn't checked must not be removed.
407 lines
20 KiB
Rust
407 lines
20 KiB
Rust
//! Flatten (Acrobat: Fill & Sign ▸ flatten, Print production ▸ Flattener, Prepare form ▸
|
|
//! Flatten): annotation appearances become ordinary page content and the annotations go away.
|
|
//!
|
|
//! Each visible annotation's normal appearance (for check boxes and radio buttons, the one its
|
|
//! `/AS` selects) is drawn into the page with the matrix of ISO 32000-2 §12.5.5 (Algorithm 8.1:
|
|
//! the appearance's bounding box, transformed by its `/Matrix`, mapped onto `/Rect`). Hidden
|
|
//! annotations are left alone; links are kept (they have no ink and stay clickable). Flattened
|
|
//! comments take their pop-ups and replies with them; flattened widgets are removed from the
|
|
//! form's field tree. An annotation whose appearance cannot be drawn is not flattened: it stays
|
|
//! as it is, so no comment or field value is lost with nothing in its place.
|
|
|
|
use std::collections::{HashMap, HashSet};
|
|
|
|
use pdfcraft_cos::{Dict, Document, ObjRef, Object};
|
|
|
|
use crate::{EditError, check, n, page_list, place_tagged};
|
|
|
|
const HIDDEN: i64 = 2;
|
|
const NO_VIEW: i64 = 32;
|
|
|
|
fn nums(doc: &Document, o: Option<&Object>) -> Option<Vec<f64>> {
|
|
let o = doc.resolve(o?);
|
|
o.as_array()?.iter().map(|x| doc.resolve(x).as_f64()).collect()
|
|
}
|
|
|
|
/// The appearance stream to draw for an annotation, if it has one.
|
|
fn appearance(doc: &Document, d: &Dict) -> Option<ObjRef> {
|
|
let ap = doc.resolve(d.get(b"AP")?);
|
|
let n = ap.as_dict()?.get(b"N")?.clone();
|
|
match &n {
|
|
Object::Ref(r) if matches!(&*doc.get(*r), Object::Stream(_)) => Some(*r),
|
|
_ => {
|
|
let states = doc.resolve(&n);
|
|
let state = d.name(b"AS")?;
|
|
states.as_dict()?.get(state)?.as_ref().filter(|r| matches!(&*doc.get(*r), Object::Stream(_)))
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Whether a widget's field has a value: its `/V`, or the nearest one inherited through `/Parent`
|
|
/// (ISO 32000-2 §12.7.4.1). An empty string or array is no value. Past the depth limit the answer
|
|
/// is yes: a value that wasn't checked must not be removed.
|
|
fn has_value(doc: &Document, widget: &Dict) -> bool {
|
|
let mut d = widget.clone();
|
|
let mut seen = HashSet::new();
|
|
for _ in 0..64 {
|
|
if let Some(v) = d.get(b"V") {
|
|
return match &*doc.resolve(v) {
|
|
Object::Null => false,
|
|
Object::String(s) => !s.to_text().is_empty(),
|
|
Object::Array(a) => !a.is_empty(),
|
|
_ => true,
|
|
};
|
|
}
|
|
let Some(parent) = d.reference(b"Parent").filter(|p| seen.insert(*p)) else { return false };
|
|
let Some(next) = doc.get(parent).as_dict().cloned() else { return false };
|
|
d = next;
|
|
}
|
|
true
|
|
}
|
|
|
|
/// Algorithm 8.1: the matrix that maps the form's bounding box onto the annotation rectangle.
|
|
fn placement(doc: &Document, form: &Dict, rect: [f64; 4]) -> Option<[f64; 6]> {
|
|
let bbox = nums(doc, form.get(b"BBox")).filter(|b| b.len() == 4)?;
|
|
let m = nums(doc, form.get(b"Matrix")).filter(|m| m.len() == 6).unwrap_or_else(|| vec![1.0, 0.0, 0.0, 1.0, 0.0, 0.0]);
|
|
let pts = [(bbox[0], bbox[1]), (bbox[2], bbox[1]), (bbox[0], bbox[3]), (bbox[2], bbox[3])]
|
|
.map(|(x, y)| (m[0] * x + m[2] * y + m[4], m[1] * x + m[3] * y + m[5]));
|
|
let (x0, x1) = pts.iter().fold((f64::MAX, f64::MIN), |(a, b), p| (a.min(p.0), b.max(p.0)));
|
|
let (y0, y1) = pts.iter().fold((f64::MAX, f64::MIN), |(a, b), p| (a.min(p.1), b.max(p.1)));
|
|
if x1 - x0 < 1e-9 || y1 - y0 < 1e-9 {
|
|
return None; // empty appearance (e.g. replies): nothing to draw
|
|
}
|
|
let (sx, sy) = ((rect[2] - rect[0]) / (x1 - x0), (rect[3] - rect[1]) / (y1 - y0));
|
|
Some([sx, 0.0, 0.0, sy, rect[0] - x0 * sx, rect[1] - y0 * sy])
|
|
}
|
|
|
|
#[derive(Clone, Copy)]
|
|
enum Which {
|
|
/// Every comment and/or every form field.
|
|
Comments { comments: bool, fields: bool },
|
|
/// Fill & Sign text, marks and signatures only.
|
|
FillSign,
|
|
}
|
|
|
|
fn selected(doc: &Document, d: &Dict, which: Which) -> bool {
|
|
let subtype = d.name(b"Subtype").unwrap_or_default();
|
|
match which {
|
|
// Comments are what the comment list calls comments: links, pop-ups and the non-markup
|
|
// multimedia and print-production annotations (3D, Screen, Movie, RichMedia,
|
|
// PrinterMark, TrapNet, Watermark) are neither comments nor fields, and stay (#3087).
|
|
Which::Comments { comments, fields } => {
|
|
if subtype == b"Widget" {
|
|
fields
|
|
} else {
|
|
comments && pdfcraft_annot::is_comment_subtype(&String::from_utf8_lossy(subtype))
|
|
}
|
|
}
|
|
Which::FillSign => !matches!(subtype, b"Link" | b"Popup" | b"Widget") && pdfcraft_annot::is_fill_sign(doc, d),
|
|
}
|
|
}
|
|
|
|
/// An XObject name that is not already on the page, so a later flatten cannot replace `PCFl0`.
|
|
fn xobject_name(existing: &Dict, pending: &Dict, n: &mut u32) -> String {
|
|
loop {
|
|
let name = format!("PCFl{n}");
|
|
if *n == u32::MAX {
|
|
return format!("PCFl{}", existing.len().saturating_add(pending.len()));
|
|
}
|
|
*n += 1;
|
|
if !existing.contains(name.as_bytes()) && !pending.contains(name.as_bytes()) {
|
|
return name;
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Flatten comments and/or form fields on `pages`. Returns how many annotations were merged
|
|
/// into page content.
|
|
pub fn flatten(doc: &mut Document, pages: &[usize], comments: bool, fields: bool) -> Result<usize, EditError> {
|
|
flatten_which(doc, pages, Which::Comments { comments, fields })
|
|
}
|
|
|
|
/// Bake Fill & Sign text, marks and signatures into `pages` and remove those annotations.
|
|
/// Other comments, links and form fields stay. Returns how many appearances were drawn.
|
|
/// Does not modify the document when nothing matches.
|
|
pub fn flatten_fill_sign(doc: &mut Document, pages: &[usize]) -> Result<usize, EditError> {
|
|
flatten_which(doc, pages, Which::FillSign)
|
|
}
|
|
|
|
/// The first annotation flattening would turn into page content with `?` in it, before anything
|
|
/// changes: one whose appearance PdfCraft drew with `?` for characters its fonts can't draw
|
|
/// (`pdfcraft_fonts::UNDRAWN_MARK`: a form field's value, a comment's text), or a comment without
|
|
/// an appearance whose text the standard fonts can't draw. Its page (0-based), whether it is a
|
|
/// form field, and the character.
|
|
fn undrawn_on(doc: &Document, all: &[pdfcraft_model::Page], pages: &[usize], which: Which) -> Option<(usize, bool, char)> {
|
|
for &i in pages {
|
|
let list = all.get(i)?.dict.get(b"Annots").map(|a| doc.resolve(a)).and_then(|a| a.as_array().cloned()).unwrap_or_default();
|
|
for entry in &list {
|
|
let Some(d) = doc.resolve(entry).as_dict().cloned() else { continue };
|
|
let flags = d.get(b"F").and_then(|f| doc.resolve(f).as_int()).unwrap_or(0);
|
|
if !selected(doc, &d, which) || flags & (HIDDEN | NO_VIEW) != 0 {
|
|
continue;
|
|
}
|
|
let widget = d.name(b"Subtype") == Some(b"Widget");
|
|
let drawn = pdfcraft_fonts::undrawn_mark(&d);
|
|
let would_draw = || (!widget && appearance(doc, &d).is_none()).then(|| pdfcraft_annot::appearance::undrawable_text(&d)).flatten();
|
|
if let Some(c) = drawn.or_else(|| would_draw().map(|(_, c)| c)) {
|
|
return Some((i, widget, c));
|
|
}
|
|
}
|
|
}
|
|
None
|
|
}
|
|
|
|
/// Runs [`flatten_in`] on a copy of `doc` (unchanged objects are shared) and keeps it only on
|
|
/// success, so a page refused part way leaves the pages before it as they were.
|
|
fn flatten_which(doc: &mut Document, pages: &[usize], which: Which) -> Result<usize, EditError> {
|
|
let mut work = doc.clone();
|
|
let drawn = flatten_in(&mut work, pages, which)?;
|
|
*doc = work;
|
|
Ok(drawn)
|
|
}
|
|
|
|
fn flatten_in(doc: &mut Document, pages: &[usize], which: Which) -> Result<usize, EditError> {
|
|
let all = page_list(doc);
|
|
check(pages, all.len())?;
|
|
// `?` in an appearance can still be fixed (a field's value, a comment's text are stored as
|
|
// typed, and other viewers redraw form fields); flattened, it would be the page for good.
|
|
if let Some((i, widget, c)) = undrawn_on(doc, &all, pages, which) {
|
|
return Err(EditError::Invalid(format!(
|
|
"can't flatten {} on page {}: it shows ? in place of \"{}\" (U+{:04X}), which its font can't draw, and flattening would make that permanent (nothing was flattened); change or remove that text first",
|
|
if widget { "a form field" } else { "a comment" },
|
|
i + 1,
|
|
c.escape_debug(),
|
|
u32::from(c)
|
|
)));
|
|
}
|
|
let mut drawn = 0;
|
|
let mut removed_widgets: HashSet<ObjRef> = HashSet::new();
|
|
for &i in pages {
|
|
let page = all[i].clone();
|
|
let annots_obj = page.dict.get(b"Annots").cloned();
|
|
let Some(list) = annots_obj.as_ref().map(|a| doc.resolve(a)).and_then(|a| a.as_array().cloned()) else { continue };
|
|
let mut content = String::new();
|
|
let mut xobjects = Dict::new();
|
|
let mut name_n = 0u32;
|
|
let existing_xo = page
|
|
.dict
|
|
.get(b"Resources")
|
|
.map(|r| doc.resolve(r))
|
|
.and_then(|r| r.as_dict().cloned())
|
|
.and_then(|r| r.get(b"XObject").map(|x| doc.resolve(x)).and_then(|x| x.as_dict().cloned()))
|
|
.unwrap_or_default();
|
|
let mut gone: HashSet<ObjRef> = HashSet::new();
|
|
let mut gone_inline: HashSet<usize> = HashSet::new();
|
|
// Selected, but nothing was drawn for it: it stays, pop-up and reply handling included.
|
|
let mut undrawn: HashSet<ObjRef> = HashSet::new();
|
|
// A viewer draws many comments from their dictionary even when the file stores no
|
|
// appearance (notes, FreeText, ink, stamps…). Build the appearance it would show, so
|
|
// flattening keeps a comment that still has ink on screen instead of deleting it.
|
|
for entry in &list {
|
|
let Some(r) = entry.as_ref() else { continue };
|
|
let d = doc.resolve(entry).as_dict().cloned().unwrap_or_default();
|
|
let subtype = d.name(b"Subtype").unwrap_or_default();
|
|
if subtype == b"Widget" || !selected(doc, &d, which) {
|
|
continue;
|
|
}
|
|
let flags = d.get(b"F").and_then(|f| doc.resolve(f).as_int()).unwrap_or(0);
|
|
if flags & (HIDDEN | NO_VIEW) != 0 || appearance(doc, &d).is_some() {
|
|
continue;
|
|
}
|
|
// A subtype this build cannot draw fails here and is kept below, so the comment is
|
|
// not deleted with nothing drawn in its place. (Text the standard fonts can't draw
|
|
// was refused before anything changed: `undrawn_on`.)
|
|
let _ = pdfcraft_annot::set_appearance(doc, r);
|
|
}
|
|
for (k, entry) in list.iter().enumerate() {
|
|
let obj = doc.resolve(entry);
|
|
let Some(d) = obj.as_dict() else { continue };
|
|
let subtype = d.name(b"Subtype").unwrap_or_default();
|
|
let widget = subtype == b"Widget";
|
|
if !selected(doc, d, which) {
|
|
continue;
|
|
}
|
|
let flags = d.get(b"F").and_then(|f| doc.resolve(f).as_int()).unwrap_or(0);
|
|
if flags & (HIDDEN | NO_VIEW) != 0 {
|
|
continue;
|
|
}
|
|
let rect = nums(doc, d.get(b"Rect")).filter(|r| r.len() == 4).map(|r| [r[0].min(r[2]), r[1].min(r[3]), r[0].max(r[2]), r[1].max(r[3])]);
|
|
let mut drew = false;
|
|
if let (Some(ap), Some(rect)) = (appearance(doc, d), rect) {
|
|
let form = doc.get(ap).as_dict().cloned().unwrap_or_default();
|
|
if let Some(m) = placement(doc, &form, rect) {
|
|
let name = xobject_name(&existing_xo, &xobjects, &mut name_n);
|
|
content.push_str(&format!("q {} {} {} {} {} {} cm /{name} Do Q\n", n(m[0]), n(m[1]), n(m[2]), n(m[3]), n(m[4]), n(m[5])));
|
|
xobjects.set(name.into_bytes(), Object::Ref(ap));
|
|
drawn += 1;
|
|
drew = true;
|
|
}
|
|
}
|
|
// A comment whose ink was not written into the page stays. Removing it would drop
|
|
// the annotation (a cloudy square this builder cannot draw, for example) with nothing
|
|
// left on the page. A widget stays when it has no appearance to draw at all (none
|
|
// stored, or none for its selected state): removing it would lose the field's value
|
|
// with nothing in its place (#1794). One whose appearance draws nothing (an empty
|
|
// stream) shows nothing anywhere, so flattening still removes it, and so does one whose
|
|
// field has no value: there is nothing to lose (#4017).
|
|
if !drew {
|
|
let keep = appearance(doc, d).is_none() && (!widget || has_value(doc, d));
|
|
if keep && let Some(r) = entry.as_ref() {
|
|
undrawn.insert(r);
|
|
}
|
|
if !widget || keep {
|
|
continue;
|
|
}
|
|
}
|
|
match entry.as_ref() {
|
|
Some(r) => {
|
|
gone.insert(r);
|
|
if widget {
|
|
removed_widgets.insert(r);
|
|
}
|
|
}
|
|
None => {
|
|
gone_inline.insert(k);
|
|
}
|
|
}
|
|
}
|
|
if gone.is_empty() && gone_inline.is_empty() {
|
|
continue;
|
|
}
|
|
// Pop-ups and replies of what was flattened go too, except a reply that stayed because
|
|
// it could not be drawn: its content would go with nothing in its place.
|
|
for entry in &list {
|
|
let Some(r) = entry.as_ref() else { continue };
|
|
if undrawn.contains(&r) {
|
|
continue;
|
|
}
|
|
let obj = doc.get(r);
|
|
let Some(d) = obj.as_dict() else { continue };
|
|
let points_at = |k: &[u8]| d.reference(k).is_some_and(|t| gone.contains(&t));
|
|
if points_at(b"Parent") && d.name(b"Subtype") == Some(b"Popup") || points_at(b"IRT") {
|
|
gone.insert(r);
|
|
}
|
|
}
|
|
let kept: Vec<Object> = list
|
|
.iter()
|
|
.enumerate()
|
|
.filter(|(k, e)| !gone_inline.contains(k) && !e.as_ref().is_some_and(|r| gone.contains(&r)))
|
|
.map(|(_, e)| e.clone())
|
|
.collect();
|
|
if !content.is_empty() {
|
|
// The page's own resources, with the appearances as XObjects.
|
|
let mut res = page.dict.get(b"Resources").map(|r| doc.resolve(r)).and_then(|r| r.as_dict().cloned()).unwrap_or_default();
|
|
let mut xo = res.get(b"XObject").map(|x| doc.resolve(x)).and_then(|x| x.as_dict().cloned()).unwrap_or_default();
|
|
for (k, v) in xobjects.iter() {
|
|
xo.set(k.clone(), v.clone());
|
|
}
|
|
res.set(b"XObject".to_vec(), Object::Dict(xo));
|
|
doc.update_dict(page.obj, |d| d.set(b"Resources".to_vec(), Object::Dict(res)))?;
|
|
let page = page_list(doc)[i].clone();
|
|
place_tagged(doc, &page, "Flattened", content.into_bytes(), false)?;
|
|
}
|
|
let page_now = page_list(doc)[i].clone();
|
|
match page_now.dict.get(b"Annots").and_then(|a| a.as_ref()).filter(|r| doc.get(*r).as_array().is_some()) {
|
|
Some(r) => doc.set(r, Object::Array(kept)),
|
|
None => doc.update_dict(page.obj, |d| {
|
|
if kept.is_empty() {
|
|
d.remove(b"Annots");
|
|
} else {
|
|
d.set(b"Annots".to_vec(), Object::Array(kept));
|
|
}
|
|
})?,
|
|
}
|
|
}
|
|
// A field whose widgets are on no page has nothing to draw, but flattening every field of the
|
|
// document must still take it out of the form, or other software keeps seeing one (#1470).
|
|
let orphans = matches!(which, Which::Comments { fields: true, .. }) && (0..all.len()).all(|i| pages.contains(&i));
|
|
if !removed_widgets.is_empty() || orphans {
|
|
let on_page: HashSet<ObjRef> = page_list(doc)
|
|
.iter()
|
|
.filter_map(|p| p.dict.get(b"Annots").map(|a| doc.resolve(a)).and_then(|a| a.as_array().cloned()))
|
|
.flatten()
|
|
.filter_map(|e| e.as_ref())
|
|
.collect();
|
|
prune_fields(doc, &removed_widgets, orphans.then_some(&on_page))?;
|
|
}
|
|
Ok(drawn)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
thread_local! {
|
|
/// How many field-tree nodes `prune_fields` visited on this thread.
|
|
pub(crate) static KEEP_CALLS: std::cell::Cell<usize> = const { std::cell::Cell::new(0) };
|
|
}
|
|
|
|
/// Remove flattened widgets from the AcroForm field tree, and fields left without widgets. With
|
|
/// `on_page`, also the widgets (fields without kids) that are on no page.
|
|
fn prune_fields(doc: &mut Document, widgets: &HashSet<ObjRef>, on_page: Option<&HashSet<ObjRef>>) -> Result<(), EditError> {
|
|
let Some(root) = doc.root() else { return Ok(()) };
|
|
let Some(af) = doc.get(root).as_dict().and_then(|d| d.get(b"AcroForm").cloned()) else { return Ok(()) };
|
|
let af_ref = af.as_ref();
|
|
let mut af_dict = doc.resolve(&af).as_dict().cloned().unwrap_or_default();
|
|
let fields = af_dict.get(b"Fields").map(|f| doc.resolve(f)).and_then(|f| f.as_array().cloned()).unwrap_or_default();
|
|
// Returns whether the node survives, and whether that answer depends on the depth cutoff.
|
|
// `known` holds each node's answer once it is visited, so a node listed twice is pruned once,
|
|
// and one still being visited (a cycle) survives. An answer the cutoff decided records the depth
|
|
// it was reached at, and a shallower path visits the node again: at most once per depth.
|
|
fn keep(
|
|
doc: &mut Document,
|
|
r: ObjRef,
|
|
widgets: &HashSet<ObjRef>,
|
|
on_page: Option<&HashSet<ObjRef>>,
|
|
known: &mut HashMap<ObjRef, (bool, Option<usize>)>,
|
|
depth: usize,
|
|
) -> (bool, bool) {
|
|
#[cfg(test)]
|
|
KEEP_CALLS.with(|c| c.set(c.get().saturating_add(1)));
|
|
if widgets.contains(&r) {
|
|
return (false, false);
|
|
}
|
|
if depth > 64 {
|
|
return (true, true);
|
|
}
|
|
match known.get(&r) {
|
|
Some(&(survives, None)) => return (survives, false),
|
|
Some(&(survives, Some(at))) if depth >= at => return (survives, true),
|
|
_ => {}
|
|
}
|
|
known.insert(r, (true, None));
|
|
let Some(d) = doc.get(r).as_dict().cloned() else { return (true, false) };
|
|
let Some(kids) = d.get(b"Kids").map(|k| doc.resolve(k)).and_then(|k| k.as_array().cloned()) else {
|
|
let survives = on_page.is_none_or(|p| p.contains(&r));
|
|
known.insert(r, (survives, None));
|
|
return (survives, false);
|
|
};
|
|
let mut cut = false;
|
|
let survivors: Vec<Object> = kids
|
|
.iter()
|
|
.filter(|k| {
|
|
k.as_ref().is_none_or(|kr| {
|
|
let (survives, kid_cut) = keep(doc, kr, widgets, on_page, known, depth + 1);
|
|
cut |= kid_cut;
|
|
survives
|
|
})
|
|
})
|
|
.cloned()
|
|
.collect();
|
|
if survivors.len() != kids.len() {
|
|
let _ = doc.update_dict(r, |d| d.set(b"Kids".to_vec(), Object::Array(survivors.clone())));
|
|
}
|
|
known.insert(r, (!survivors.is_empty(), cut.then_some(depth)));
|
|
(!survivors.is_empty(), cut)
|
|
}
|
|
let mut known = HashMap::new();
|
|
let survivors: Vec<Object> =
|
|
fields.iter().filter(|f| f.as_ref().is_none_or(|r| keep(doc, r, widgets, on_page, &mut known, 0).0)).cloned().collect();
|
|
if survivors.len() == fields.len() && widgets.is_empty() {
|
|
return Ok(()); // only looked for fields on no page, and there were none
|
|
}
|
|
af_dict.set(b"Fields".to_vec(), Object::Array(survivors));
|
|
match af_ref {
|
|
Some(r) => doc.set(r, Object::Dict(af_dict)),
|
|
None => doc.update_dict(root, |d| d.set(b"AcroForm".to_vec(), Object::Dict(af_dict)))?,
|
|
}
|
|
Ok(())
|
|
}
|