mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-10-27 03:27:21 -06:00
MichaelandClaude Sonnet 5
c38cdbf0be
CodeRabbit review on #3471: even with the gap >= 0.0 overlap guard, two equal-size rows with no horizontal overlap (not just overlapping ones) could still land inside the widened 50% baseline tolerance at a 5pt shift that the original 20% tolerance would have rejected, merging distinct body-text lines into one row. The wider tolerance is meant for a run distinctly smaller or larger than its neighbour (a super/subscript), not two ordinary same-size rows. Require prev.size.min(line.size) < prev.size.max(line.size) * 0.9 before taking it; equal-size runs keep the original 20% tolerance regardless of overlap. Added equal_size_rows_need_the_tighter_tolerance_even_without_overlap, confirmed it fails without this change (merges into one row/block) and passes with it, alongside the two existing regression tests from the earlier rounds of this fix. cargo test -p pdfcraft-edit (198 passed), fmt, clippy -D warnings, xtask layers and xtask assets all clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>